diff mbox

Kbuild: fix mismatched if/endif pairs

Message ID 180617191612798b1a5d7a74c59e7905c31fd3f36f5d@stu.xidian.edu.cn (mailing list archive)
State New, archived
Headers show

Commit Message

Xi Ruoyao June 17, 2018, 10:16 a.m. UTC 
In scripts/Makefile.build, there are two mismatched if/endif pairs.
They stop the generation of orc unwind table if CONFIG_FTRACE_MCOUNT_RECORD
is not set.  dmesg complains:

WARNING: WARNING: Bad or missing .orc_unwind table.  Disabling unwinder.

This comment moves an endif to match the if/endif pairs.

Signed-off-by: Xi Ruoyao <ryxi@stu.xidian.edu.cn>
---
 scripts/Makefile.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Josh Poimboeuf June 20, 2018, 3:35 p.m. UTC | #1 
On Sun, Jun 17, 2018 at 06:16:07PM +0800, Xi Ruoyao wrote:
> In scripts/Makefile.build, there are two mismatched if/endif pairs.
> They stop the generation of orc unwind table if CONFIG_FTRACE_MCOUNT_RECORD
> is not set.  dmesg complains:
> 
> WARNING: WARNING: Bad or missing .orc_unwind table.  Disabling unwinder.
> 
> This comment moves an endif to match the if/endif pairs.
> 
> Signed-off-by: Xi Ruoyao <ryxi@stu.xidian.edu.cn>

Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>
diff mbox

Patch

diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 34d9e9ce97c2..16509a038d77 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -239,6 +239,7 @@  cmd_record_mcount =						\
 	     "$(CC_FLAGS_FTRACE)" ]; then			\
 		$(sub_cmd_record_mcount)			\
 	fi;
+endif # cc-option(-mrecord-mcount)
 endif # CONFIG_FTRACE_MCOUNT_RECORD
 
 ifdef CONFIG_STACK_VALIDATION
@@ -263,7 +264,6 @@  ifneq ($(RETPOLINE_CFLAGS),)
   objtool_args += --retpoline
 endif
 endif
-endif
 
 
 ifdef CONFIG_MODVERSIONS