| Message ID | 20180619202357.10805-1-efremov@linux.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
On Tue, Jun 19, 2018 at 11:23:57PM +0300, efremov@linux.com wrote: > The function skcipher_walk_next declared as static and marked as > EXPORT_SYMBOL_GPL. It's a bit confusing for internal function to be > exported. The area of visibility for such function is its .c file > and all other modules. Other *.c files of the same module can't use it, > despite all other modules can. Relying on the fact that this is the > internal function and it's not a crucial part of the API, the patch > just removes the EXPORT_SYMBOL_GPL marking of skcipher_walk_next. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Denis Efremov <efremov@linux.com> Patch applied. Thanks.
diff --git a/crypto/skcipher.c b/crypto/skcipher.c index 0fe2a2923ad0..7d6a49fe3047 100644 --- a/crypto/skcipher.c +++ b/crypto/skcipher.c @@ -387,7 +387,6 @@ static int skcipher_walk_next(struct skcipher_walk *walk) } return err; } -EXPORT_SYMBOL_GPL(skcipher_walk_next); static int skcipher_copy_iv(struct skcipher_walk *walk) {
The function skcipher_walk_next declared as static and marked as EXPORT_SYMBOL_GPL. It's a bit confusing for internal function to be exported. The area of visibility for such function is its .c file and all other modules. Other *.c files of the same module can't use it, despite all other modules can. Relying on the fact that this is the internal function and it's not a crucial part of the API, the patch just removes the EXPORT_SYMBOL_GPL marking of skcipher_walk_next. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Denis Efremov <efremov@linux.com> --- crypto/skcipher.c | 1 - 1 file changed, 1 deletion(-)