ARM: dts: am3517-evm: Create dummy regulator to squelch noise
diff mbox

Message ID 20180619224131.25497-1-aford173@gmail.com
State New
Headers show

Commit Message

Adam Ford June 19, 2018, 10:41 p.m. UTC
There are several peripherals who generate some extra noise when
they don't have a regulator assigned to them.  This patch
creates a dummy regulator to reduce the noise.

Signed-off-by: Adam Ford <aford173@gmail.com>

Comments

Tony Lindgren July 3, 2018, 7:26 a.m. UTC | #1
* Adam Ford <aford173@gmail.com> [180619 15:44]:
> There are several peripherals who generate some extra noise when
> they don't have a regulator assigned to them.  This patch
> creates a dummy regulator to reduce the noise.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> diff --git a/arch/arm/boot/dts/am3517-evm.dts b/arch/arm/boot/dts/am3517-evm.dts
> index d7eb6ad76c29..0d56c3f56a6d 100644
> --- a/arch/arm/boot/dts/am3517-evm.dts
> +++ b/arch/arm/boot/dts/am3517-evm.dts
> @@ -31,6 +31,13 @@
>                  regulator-max-microvolt = <3300000>;
>          };
>  
> +	dummy_reg: dummy_reg {
> +		compatible = "regulator-fixed";
> +		regulator-name = "dummy_reg";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +	};
> +

How about just rename it to something like reg_3v3 instead of dummy?
Then if you find some GPIO or PMIC register controlling it you don't
have to change the naming again?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/arch/arm/boot/dts/am3517-evm.dts b/arch/arm/boot/dts/am3517-evm.dts
index d7eb6ad76c29..0d56c3f56a6d 100644
--- a/arch/arm/boot/dts/am3517-evm.dts
+++ b/arch/arm/boot/dts/am3517-evm.dts
@@ -31,6 +31,13 @@ 
                 regulator-max-microvolt = <3300000>;
         };
 
+	dummy_reg: dummy_reg {
+		compatible = "regulator-fixed";
+		regulator-name = "dummy_reg";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+	};
+
 	gpio-keys {
 		compatible = "gpio-keys-polled";
 		poll-interval = <100>;
@@ -127,7 +134,7 @@ 
 		status = "okay";
 		pinctrl-names = "default";
 		enable-gpios = <&gpio6 16 GPIO_ACTIVE_HIGH>;	/* gpio176, lcd INI */
-
+		vcc-supply = <&dummy_reg>;
 		port {
 			lcd_in: endpoint {
 				remote-endpoint = <&dpi_out>;
@@ -154,6 +161,7 @@ 
 	bl: backlight {
 		compatible = "pwm-backlight";
 		pinctrl-names = "default";
+		power-supply = <&dummy_reg>;
 		pinctrl-0 = <&backlight_pins>;
 		pwms = <&pwm11 0 5000000 0>;
 		brightness-levels = <0 10 20 30 40 50 60 70 80 90 100>;
@@ -203,6 +211,7 @@ 
 		reg = <0x21>;
 		gpio-controller;
 		#gpio-cells = <2>;
+		vcc-supply = <&dummy_reg>;
 	};
 };