From patchwork Wed Jun 20 07:34:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Esben Haabendal X-Patchwork-Id: 10476651 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BECE1604D3 for ; Wed, 20 Jun 2018 09:06:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B011D28758 for ; Wed, 20 Jun 2018 09:06:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A4C6828C0C; Wed, 20 Jun 2018 09:06:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5185428758 for ; Wed, 20 Jun 2018 09:06:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753853AbeFTIhF (ORCPT ); Wed, 20 Jun 2018 04:37:05 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:32891 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750793AbeFTIhD (ORCPT ); Wed, 20 Jun 2018 04:37:03 -0400 Received: by mail-lf0-f67.google.com with SMTP id y20-v6so3694746lfy.0; Wed, 20 Jun 2018 01:37:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=O0vJUcT4Mc+H9wUe3QEqBqdbXIDak+uMs4CoMKKvHTA=; b=JOEfEQBIjXYzn/vuXqmXtseykNqihRjle8cAO6+y8a2RNR5NEsZdgwNZYZXe5W8DlU FxQ9e5qB4Q/49uhwJ31J6D46pxmYHv/wKFp/hnloFjPEmA5n5R1NgCWDAVMXHWPpMKPT JMWi6osjOak7enZbxoD1FowlsMq/xM2wBC9WA/lcrW9apzA4T92/UlsQLa8ohWtFhRhs 3rJLsJLTUP2oQaJqvHIF/ASMY9ArvlpgHy+57NSux9eGMErDagKDMEtk1nmj85VoaN4O HXlIxaRKzXkXdPPAb9nBAE56TD5wESt6zsNLYsb3OhYUdwrD375PclvtUPg56OnrYXlU junA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=O0vJUcT4Mc+H9wUe3QEqBqdbXIDak+uMs4CoMKKvHTA=; b=gt1rLL8F9nbYa1fjFktk89IPFdTlgSbHo+qjFPREQv3sg1LMHMjjgcF1F1N0mzTikV l2umoIbjRLTH60Gu41xxNRsG/46Crr2CSO7SZ/p1VJTwN3eivurmtjQyLxb3Bw9wsMg8 YB3fQUGluhYWMb9vAIpU5l+1VFsOZUEODqjfF/dEAJQWEF+vWkmjnLzMxvcjuQ+12bBp Az5fLN8+XypZOTSqH6AT9DGQ6Y2eBLYcu7I1lQzu2D5yffE7tOW+R95Ckj2NcbSq6Zvy /i1ZR8HqwRiBiNJeEd+eMWjXt3+BPkh0CMqf1Mn1Xi8iv9i0vLNvWNQ6iHo91K0rq91k ZTQA== X-Gm-Message-State: APt69E2aXMpSzVxdOzVfPMjoBlh35rNuU0kSGrSIXfXj/RAuutYigwxF ySiPOJNKOk0N38hEGmsCFuv59W92 X-Google-Smtp-Source: ADUXVKIP8Y2GnxEm65O8FXJ+02vDfRNfBpq3ZEqpSi4vqCdXN48UsexTr5SlIT08E5V9ICkV0HI2Ow== X-Received: by 2002:a19:ccc6:: with SMTP id c189-v6mr3044347lfg.88.1529480087204; Wed, 20 Jun 2018 00:34:47 -0700 (PDT) Received: from localhost (87-57-30-174-static.dk.customer.tdc.net. [87.57.30.174]) by smtp.gmail.com with ESMTPSA id z3-v6sm284167lfg.47.2018.06.20.00.34.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Jun 2018 00:34:46 -0700 (PDT) From: Esben Haabendal To: Mark Brown , linux-spi@vger.kernel.org Cc: Kurt Kanzenbach , Angelo Dureghello , Nikita Yushchenko , Sanchayan Maity , Yuan Yao , linux-kernel@vger.kernel.org, Esben Haabendal , =?UTF-8?q?Martin=20Hundeb=C3=B8ll?= Subject: [PATCH 01/12] spi: spi-fsl-dspi: Drop unreachable else if statement Date: Wed, 20 Jun 2018 09:34:31 +0200 Message-Id: <20180620073442.20913-2-esben.haabendal@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180620073442.20913-1-esben.haabendal@gmail.com> References: <20180620073442.20913-1-esben.haabendal@gmail.com> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Esben Haabendal The if statement just above this if/else statement triggers on the same condition, and then invalidates it. Signed-off-by: Esben Haabendal Cc: Martin Hundebøll --- drivers/spi/spi-fsl-dspi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c index 0630962ce442..3ca9b9608801 100644 --- a/drivers/spi/spi-fsl-dspi.c +++ b/drivers/spi/spi-fsl-dspi.c @@ -593,8 +593,7 @@ static int dspi_eoq_write(struct fsl_dspi *dspi) dspi_pushr |= SPI_PUSHR_EOQ; if ((dspi->cs_change) && (!dspi->len)) dspi_pushr &= ~SPI_PUSHR_CONT; - } else if (tx_word && (dspi->len == 1)) - dspi_pushr |= SPI_PUSHR_EOQ; + } regmap_write(dspi->regmap, SPI_PUSHR, dspi_pushr);