diff mbox

[1/3] add missing entry for OP_FNEG in kill_insn() & validate_insn()

Message ID 20180622211619.27168-2-luc.vanoostenryck@gmail.com (mailing list archive)
State Mainlined, archived
Headers show

Commit Message

Luc Van Oostenryck June 22, 2018, 9:16 p.m. UTC
These functions must have en entry fro almost all instructions
but OP_FNEG was missing.

Fix this by adding the entry for OP_FNEG.

Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
 ir.c       | 2 +-
 simplify.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Ramsay Jones June 23, 2018, 12:35 a.m. UTC | #1
On 22/06/18 22:16, Luc Van Oostenryck wrote:
> These functions must have en entry fro almost all instructions

s/en/an/ and s/fro/for/

[Yes, I do read your patches. ;-) Often, there is nothing to
comment on!]

ATB,
Ramsay Jones

--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Luc Van Oostenryck June 23, 2018, 5:41 a.m. UTC | #2
On Sat, Jun 23, 2018 at 01:35:31AM +0100, Ramsay Jones wrote:
> 
> 
> On 22/06/18 22:16, Luc Van Oostenryck wrote:
> > These functions must have en entry fro almost all instructions
> 
> s/en/an/ and s/fro/for/

*Sigh* I'm often completly blind to this sort of typos.

> [Yes, I do read your patches. ;-) Often, there is nothing to
> comment on!]

Thank you, very much.
-- Luc 
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/ir.c b/ir.c
index 205bd6396..5116beaac 100644
--- a/ir.c
+++ b/ir.c
@@ -100,7 +100,7 @@  static int validate_insn(struct instruction *insn)
 	case OP_SCAST:
 	case OP_FPCAST:
 	case OP_PTRCAST:
-	case OP_NOT: case OP_NEG:
+	case OP_NOT: case OP_NEG: case OP_FNEG:
 	case OP_SLICE:
 	case OP_SYMADDR:
 	case OP_PHISOURCE:
diff --git a/simplify.c b/simplify.c
index be7208608..eabe63cac 100644
--- a/simplify.c
+++ b/simplify.c
@@ -256,7 +256,7 @@  int kill_insn(struct instruction *insn, int force)
 	case OP_FPCAST:
 	case OP_PTRCAST:
 	case OP_SETVAL:
-	case OP_NOT: case OP_NEG:
+	case OP_NOT: case OP_NEG: case OP_FNEG:
 	case OP_SLICE:
 		kill_use(&insn->src1);
 		break;