diff mbox

[v3,09/10] multipathd: fix buffer size in cli_getprkey()

Message ID 20180624190944.27158-10-mwilck@suse.com (mailing list archive)
State Not Applicable, archived
Delegated to: christophe varoqui
Headers show

Commit Message

Martin Wilck June 24, 2018, 7:09 p.m. UTC 
gcc 8.1 warned about this.

Signed-off-by: Martin Wilck <mwilck@suse.com>
---
 multipathd/cli_handlers.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox

Patch

diff --git a/multipathd/cli_handlers.c b/multipathd/cli_handlers.c
index 47830e1c..5682b5c2 100644
--- a/multipathd/cli_handlers.c
+++ b/multipathd/cli_handlers.c
@@ -1449,7 +1449,7 @@  cli_getprkey(void * v, char ** reply, int * len, void * data)
 	if (!mpp)
 		return 1;
 
-	*reply = malloc(20);
+	*reply = malloc(26);
 
 	if (!get_be64(mpp->reservation_key)) {
 		sprintf(*reply, "none\n");
@@ -1458,7 +1458,7 @@  cli_getprkey(void * v, char ** reply, int * len, void * data)
 	}
 	if (mpp->sa_flags & MPATH_F_APTPL_MASK)
 		flagstr = ":aptpl";
-	snprintf(*reply, 20, "0x%" PRIx64 "%s\n",
+	snprintf(*reply, 26, "0x%" PRIx64 "%s\n",
 		 get_be64(mpp->reservation_key), flagstr);
 	(*reply)[19] = '\0';
 	*len = strlen(*reply) + 1;