[V3] ARM: dts: omap3: Fix am3517 mdio and emac clock references
diff mbox

Message ID 20180625124133.21839-1-aford173@gmail.com
State New
Headers show

Commit Message

Adam Ford June 25, 2018, 12:41 p.m. UTC
A previous patch removed OMAP clock aliases that were perceived
to be unnecessary.  Unfortunately, it broke the ethernet on the
am3517-evm.  This patch enables the MDIO clock and EMAC clock.

Fixes: 0ed266d7ae5e ("clk: ti: omap3: cleanup unnecessary clock aliases")
Cc: stable@vger.kernel.org #4.16+

Signed-off-by: Adam Ford <aford173@gmail.com>
---
V3:  Fix subject heading since we're no longer modifying the clk driver

V2:  Instead of modifying clk-3xxx.c, this patch modifie the device tree
     to work like the original patch intended.

Comments

Derald D. Woods June 25, 2018, 1:19 p.m. UTC | #1
On Mon, Jun 25, 2018 at 07:41:33AM -0500, Adam Ford wrote:
> A previous patch removed OMAP clock aliases that were perceived
> to be unnecessary.  Unfortunately, it broke the ethernet on the
> am3517-evm.  This patch enables the MDIO clock and EMAC clock.
> 

Tested-by: Derald D. Woods <woods.technical@gmail.com>

> Fixes: 0ed266d7ae5e ("clk: ti: omap3: cleanup unnecessary clock aliases")
> Cc: stable@vger.kernel.org #4.16+
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> V3:  Fix subject heading since we're no longer modifying the clk driver
> 
> V2:  Instead of modifying clk-3xxx.c, this patch modifie the device tree
>      to work like the original patch intended.
>      
> diff --git a/arch/arm/boot/dts/am3517.dtsi b/arch/arm/boot/dts/am3517.dtsi
> index ca294914bbb1..4b6062b631b1 100644
> --- a/arch/arm/boot/dts/am3517.dtsi
> +++ b/arch/arm/boot/dts/am3517.dtsi
> @@ -39,6 +39,8 @@
>  			ti,davinci-ctrl-ram-size = <0x2000>;
>  			ti,davinci-rmii-en = /bits/ 8 <1>;
>  			local-mac-address = [ 00 00 00 00 00 00 ];
> +			clocks = <&emac_ick>;
> +			clock-names = "ick";
>  		};
>  
>  		davinci_mdio: ethernet@5c030000 {
> @@ -49,6 +51,8 @@
>  			bus_freq = <1000000>;
>  			#address-cells = <1>;
>  			#size-cells = <0>;
> +			clocks = <&emac_fck>;
> +			clock-names = "fck";
>  		};
>  
>  		uart4: serial@4809e000 {
> -- 
> 2.17.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren July 3, 2018, 7:39 a.m. UTC | #2
* Adam Ford <aford173@gmail.com> [180625 05:44]:
> A previous patch removed OMAP clock aliases that were perceived
> to be unnecessary.  Unfortunately, it broke the ethernet on the
> am3517-evm.  This patch enables the MDIO clock and EMAC clock.
> 
> Fixes: 0ed266d7ae5e ("clk: ti: omap3: cleanup unnecessary clock aliases")
> Cc: stable@vger.kernel.org #4.16+
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> V3:  Fix subject heading since we're no longer modifying the clk driver
> 
> V2:  Instead of modifying clk-3xxx.c, this patch modifie the device tree
>      to work like the original patch intended.

Thanks applying into omap-for-v4.18/fixes.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/arch/arm/boot/dts/am3517.dtsi b/arch/arm/boot/dts/am3517.dtsi
index ca294914bbb1..4b6062b631b1 100644
--- a/arch/arm/boot/dts/am3517.dtsi
+++ b/arch/arm/boot/dts/am3517.dtsi
@@ -39,6 +39,8 @@ 
 			ti,davinci-ctrl-ram-size = <0x2000>;
 			ti,davinci-rmii-en = /bits/ 8 <1>;
 			local-mac-address = [ 00 00 00 00 00 00 ];
+			clocks = <&emac_ick>;
+			clock-names = "ick";
 		};
 
 		davinci_mdio: ethernet@5c030000 {
@@ -49,6 +51,8 @@ 
 			bus_freq = <1000000>;
 			#address-cells = <1>;
 			#size-cells = <0>;
+			clocks = <&emac_fck>;
+			clock-names = "fck";
 		};
 
 		uart4: serial@4809e000 {