writeback: update stale account_page_redirty() comment
diff mbox

Message ID 20180625171526.173483-1-gthelen@google.com
State New
Headers show

Commit Message

Greg Thelen June 25, 2018, 5:15 p.m. UTC
commit 93f78d882865 ("writeback: move backing_dev_info->bdi_stat[] into
bdi_writeback") replaced BDI_DIRTIED with WB_DIRTIED in
account_page_redirty().  Update comment to track that change.
  BDI_DIRTIED => WB_DIRTIED
  BDI_WRITTEN => WB_WRITTEN

Signed-off-by: Greg Thelen <gthelen@google.com>
---
 mm/page-writeback.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jan Kara June 26, 2018, 12:06 p.m. UTC | #1
On Mon 25-06-18 10:15:26, Greg Thelen wrote:
> commit 93f78d882865 ("writeback: move backing_dev_info->bdi_stat[] into
> bdi_writeback") replaced BDI_DIRTIED with WB_DIRTIED in
> account_page_redirty().  Update comment to track that change.
>   BDI_DIRTIED => WB_DIRTIED
>   BDI_WRITTEN => WB_WRITTEN
> 
> Signed-off-by: Greg Thelen <gthelen@google.com>

Looks good. You can add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  mm/page-writeback.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index 337c6afb3345..6551d3b0dc30 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -2490,8 +2490,8 @@ EXPORT_SYMBOL(__set_page_dirty_nobuffers);
>  
>  /*
>   * Call this whenever redirtying a page, to de-account the dirty counters
> - * (NR_DIRTIED, BDI_DIRTIED, tsk->nr_dirtied), so that they match the written
> - * counters (NR_WRITTEN, BDI_WRITTEN) in long term. The mismatches will lead to
> + * (NR_DIRTIED, WB_DIRTIED, tsk->nr_dirtied), so that they match the written
> + * counters (NR_WRITTEN, WB_WRITTEN) in long term. The mismatches will lead to
>   * systematic errors in balanced_dirty_ratelimit and the dirty pages position
>   * control.
>   */
> -- 
> 2.18.0.rc2.346.g013aa6912e-goog
>
Tejun Heo July 2, 2018, 3:57 p.m. UTC | #2
On Mon, Jun 25, 2018 at 10:15:26AM -0700, Greg Thelen wrote:
> commit 93f78d882865 ("writeback: move backing_dev_info->bdi_stat[] into
> bdi_writeback") replaced BDI_DIRTIED with WB_DIRTIED in
> account_page_redirty().  Update comment to track that change.
>   BDI_DIRTIED => WB_DIRTIED
>   BDI_WRITTEN => WB_WRITTEN
> 
> Signed-off-by: Greg Thelen <gthelen@google.com>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

Patch
diff mbox

diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 337c6afb3345..6551d3b0dc30 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -2490,8 +2490,8 @@  EXPORT_SYMBOL(__set_page_dirty_nobuffers);
 
 /*
  * Call this whenever redirtying a page, to de-account the dirty counters
- * (NR_DIRTIED, BDI_DIRTIED, tsk->nr_dirtied), so that they match the written
- * counters (NR_WRITTEN, BDI_WRITTEN) in long term. The mismatches will lead to
+ * (NR_DIRTIED, WB_DIRTIED, tsk->nr_dirtied), so that they match the written
+ * counters (NR_WRITTEN, WB_WRITTEN) in long term. The mismatches will lead to
  * systematic errors in balanced_dirty_ratelimit and the dirty pages position
  * control.
  */