[2/2] ARM: mvebu_v7_defconfig: enable SFP support
diff mbox

Message ID b130ccb8a9812530d33a71afb1563545fa8808cf.1530169575.git.baruch@tkos.co.il
State New, archived
Headers show

Commit Message

Baruch Siach June 28, 2018, 7:06 a.m. UTC
This enables support for SFP cages on SolidRun Armada 38x and 8k
platforms.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 arch/arm/configs/mvebu_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Gregory CLEMENT June 28, 2018, 12:07 p.m. UTC | #1
Hi Baruch,
 
 On jeu., juin 28 2018, Baruch Siach <baruch@tkos.co.il> wrote:

> This enables support for SFP cages on SolidRun Armada 38x and 8k
> platforms.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Applied on mvebu/arm

Thanks,

Gregory

> ---
>  arch/arm/configs/mvebu_v7_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/mvebu_v7_defconfig b/arch/arm/configs/mvebu_v7_defconfig
> index 1ff371ae688d..55140219ab11 100644
> --- a/arch/arm/configs/mvebu_v7_defconfig
> +++ b/arch/arm/configs/mvebu_v7_defconfig
> @@ -66,6 +66,7 @@ CONFIG_NETDEVICES=y
>  CONFIG_MV643XX_ETH=y
>  CONFIG_MVNETA=y
>  CONFIG_MVPP2=y
> +CONFIG_SFP=y
>  CONFIG_MARVELL_PHY=y
>  CONFIG_MWIFIEX=y
>  CONFIG_MWIFIEX_SDIO=y
> -- 
> 2.18.0
>
Thomas Petazzoni June 28, 2018, 1:14 p.m. UTC | #2
Hello Baruch,

On Thu, 28 Jun 2018 10:06:15 +0300, Baruch Siach wrote:
> This enables support for SFP cages on SolidRun Armada 38x and 8k

You're running a 32-bit kernel on 8K platforms ?

Thomas
Baruch Siach June 28, 2018, 2:44 p.m. UTC | #3
Hi Thomas,

On Thu, Jun 28, 2018 at 03:14:07PM +0200, Thomas Petazzoni wrote:
> On Thu, 28 Jun 2018 10:06:15 +0300, Baruch Siach wrote:
> > This enables support for SFP cages on SolidRun Armada 38x and 8k
> 
> You're running a 32-bit kernel on 8K platforms ?

No, though that is probably possible.

But you are right. In practice this patch only affects 32-bit mvebu platforms. 
Support for 8k platforms would require a separate patch.

Gregory, you mentioned earlier that mvebu branches are not immutable yet. Can 
you drop reference to 8k platforms from the commit log?

Thanks,
baruch
Gregory CLEMENT June 28, 2018, 2:53 p.m. UTC | #4
Hi Baruch,
 
 On jeu., juin 28 2018, Baruch Siach <baruch@tkos.co.il> wrote:

> Hi Thomas,
>
> On Thu, Jun 28, 2018 at 03:14:07PM +0200, Thomas Petazzoni wrote:
>> On Thu, 28 Jun 2018 10:06:15 +0300, Baruch Siach wrote:
>> > This enables support for SFP cages on SolidRun Armada 38x and 8k
>> 
>> You're running a 32-bit kernel on 8K platforms ?
>
> No, though that is probably possible.
>
> But you are right. In practice this patch only affects 32-bit mvebu platforms. 
> Support for 8k platforms would require a separate patch.
>
> Gregory, you mentioned earlier that mvebu branches are not immutable yet. Can 
> you drop reference to 8k platforms from the commit log?

it's done, now

Gregory

>
> Thanks,
> baruch
>
> -- 
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

Patch
diff mbox

diff --git a/arch/arm/configs/mvebu_v7_defconfig b/arch/arm/configs/mvebu_v7_defconfig
index 1ff371ae688d..55140219ab11 100644
--- a/arch/arm/configs/mvebu_v7_defconfig
+++ b/arch/arm/configs/mvebu_v7_defconfig
@@ -66,6 +66,7 @@  CONFIG_NETDEVICES=y
 CONFIG_MV643XX_ETH=y
 CONFIG_MVNETA=y
 CONFIG_MVPP2=y
+CONFIG_SFP=y
 CONFIG_MARVELL_PHY=y
 CONFIG_MWIFIEX=y
 CONFIG_MWIFIEX_SDIO=y