[1/2] ARM: dts: armada388-clearfog: enable spi flash
diff mbox

Message ID 2bc87e3e365c460943730ded86c8fcb1ff55a533.1530170016.git.baruch@tkos.co.il
State New, archived
Headers show

Commit Message

Baruch Siach June 28, 2018, 7:13 a.m. UTC
The SolidRun Armada 388 SOM has the SPI flash populated by default
unless the customer explicitly asks otherwise. Enable support by
default.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Gregory CLEMENT June 28, 2018, 9:31 a.m. UTC | #1
Hi Baruch,
 
 On jeu., juin 28 2018, Baruch Siach <baruch@tkos.co.il> wrote:

> The SolidRun Armada 388 SOM has the SPI flash populated by default
> unless the customer explicitly asks otherwise. Enable support by
> default.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Applied on mvebu/dt

Thanks,

Gregory

> ---
>  arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi b/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi
> index 2d1cea131e71..c990d502d9a4 100644
> --- a/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi
> +++ b/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi
> @@ -99,7 +99,6 @@
>  		compatible = "w25q32", "jedec,spi-nor";
>  		reg = <0>; /* Chip select 0 */
>  		spi-max-frequency = <3000000>;
> -		status = "disabled";
>  	};
>  };
>  
> -- 
> 2.18.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Russell King - ARM Linux admin June 28, 2018, 9:51 a.m. UTC | #2
On Thu, Jun 28, 2018 at 10:13:35AM +0300, Baruch Siach wrote:
> The SolidRun Armada 388 SOM has the SPI flash populated by default
> unless the customer explicitly asks otherwise. Enable support by
> default.

Are you sure about that - at least some of my boards do not have the
SPI flash populated.

&spi1 {
        /* The microsom has an optional W25Q32 on board, connected to CS0 */
...
&spi1 {
        /*
         * Add SPI CS pins for clearfog:
         * CS0: W25Q32 (not populated on uSOM)
         * CS1: PIC microcontroller (Pro models)
         * CS2: mikrobus
         */

I wouldn't have written "not populated on uSOM" without having first
taken the uSOM off and physically checked.
Russell King - ARM Linux admin June 28, 2018, 9:52 a.m. UTC | #3
On Thu, Jun 28, 2018 at 11:31:26AM +0200, Gregory CLEMENT wrote:
> Hi Baruch,
>  
>  On jeu., juin 28 2018, Baruch Siach <baruch@tkos.co.il> wrote:
> 
> > The SolidRun Armada 388 SOM has the SPI flash populated by default
> > unless the customer explicitly asks otherwise. Enable support by
> > default.
> >
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> 
> Applied on mvebu/dt

It would be nice if you waited for acks or review before picking up
patches.  Only patch 2 has been acked and reviewed.
Gregory CLEMENT June 28, 2018, 9:56 a.m. UTC | #4
Hi Russell King,
 
 On jeu., juin 28 2018, Russell King - ARM Linux <linux@armlinux.org.uk> wrote:

> On Thu, Jun 28, 2018 at 11:31:26AM +0200, Gregory CLEMENT wrote:
>> Hi Baruch,
>>  
>>  On jeu., juin 28 2018, Baruch Siach <baruch@tkos.co.il> wrote:
>> 
>> > The SolidRun Armada 388 SOM has the SPI flash populated by default
>> > unless the customer explicitly asks otherwise. Enable support by
>> > default.
>> >
>> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>> 
>> Applied on mvebu/dt
>
> It would be nice if you waited for acks or review before picking up
> patches.  Only patch 2 has been acked and reviewed.

The mvebu branches can still be modified, they become immutably only
when we do PR, and usually it is around rc5 or rc6. So it's not too late
to make some remarks on them.

Gregory

>
> -- 
> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
> According to speedtest.net: 8.21Mbps down 510kbps up
Baruch Siach June 28, 2018, 10:07 a.m. UTC | #5
Hi Russell,

Thanks for reviewing.

On Thu, Jun 28, 2018 at 10:51:14AM +0100, Russell King - ARM Linux wrote:
> On Thu, Jun 28, 2018 at 10:13:35AM +0300, Baruch Siach wrote:
> > The SolidRun Armada 388 SOM has the SPI flash populated by default
> > unless the customer explicitly asks otherwise. Enable support by
> > default.
> 
> Are you sure about that - at least some of my boards do not have the
> SPI flash populated.
> 
> &spi1 {
>         /* The microsom has an optional W25Q32 on board, connected to CS0 */
> ...
> &spi1 {
>         /*
>          * Add SPI CS pins for clearfog:
>          * CS0: W25Q32 (not populated on uSOM)

I should update this line as well, I guess.

>          * CS1: PIC microcontroller (Pro models)
>          * CS2: mikrobus
>          */
> 
> I wouldn't have written "not populated on uSOM" without having first
> taken the uSOM off and physically checked.

Are these production SOMs or development/engineering samples?

Ilya Viten from the SolidRun commercial department told me that all production 
SOMs that were shipped to customers have the SPI flash populated.

This is just the default value for the common case.

baruch
Russell King - ARM Linux admin June 28, 2018, 10:33 a.m. UTC | #6
On Thu, Jun 28, 2018 at 01:07:59PM +0300, Baruch Siach wrote:
> Hi Russell,
> 
> Thanks for reviewing.
> 
> On Thu, Jun 28, 2018 at 10:51:14AM +0100, Russell King - ARM Linux wrote:
> > On Thu, Jun 28, 2018 at 10:13:35AM +0300, Baruch Siach wrote:
> > > The SolidRun Armada 388 SOM has the SPI flash populated by default
> > > unless the customer explicitly asks otherwise. Enable support by
> > > default.
> > 
> > Are you sure about that - at least some of my boards do not have the
> > SPI flash populated.
> > 
> > &spi1 {
> >         /* The microsom has an optional W25Q32 on board, connected to CS0 */
> > ...
> > &spi1 {
> >         /*
> >          * Add SPI CS pins for clearfog:
> >          * CS0: W25Q32 (not populated on uSOM)
> 
> I should update this line as well, I guess.
> 
> >          * CS1: PIC microcontroller (Pro models)
> >          * CS2: mikrobus
> >          */
> > 
> > I wouldn't have written "not populated on uSOM" without having first
> > taken the uSOM off and physically checked.
> 
> Are these production SOMs or development/engineering samples?

I don't remember.

> Ilya Viten from the SolidRun commercial department told me that all production 
> SOMs that were shipped to customers have the SPI flash populated.

Yes, Jon confirms that.

> This is just the default value for the common case.

Has it been tested with boards that don't have the SPI flash populated?
That needs to happen to make sure that this doesn't cause a regression.
Baruch Siach June 28, 2018, 10:47 a.m. UTC | #7
Hi Russell,

On Thu, Jun 28, 2018 at 11:33:20AM +0100, Russell King - ARM Linux wrote:
> On Thu, Jun 28, 2018 at 01:07:59PM +0300, Baruch Siach wrote:
> > Thanks for reviewing.
> > 
> > On Thu, Jun 28, 2018 at 10:51:14AM +0100, Russell King - ARM Linux wrote:
> > > On Thu, Jun 28, 2018 at 10:13:35AM +0300, Baruch Siach wrote:
> > > > The SolidRun Armada 388 SOM has the SPI flash populated by default
> > > > unless the customer explicitly asks otherwise. Enable support by
> > > > default.
> > > 
> > > Are you sure about that - at least some of my boards do not have the
> > > SPI flash populated.
> > > 
> > > &spi1 {
> > >         /* The microsom has an optional W25Q32 on board, connected to CS0 */
> > > ...
> > > &spi1 {
> > >         /*
> > >          * Add SPI CS pins for clearfog:
> > >          * CS0: W25Q32 (not populated on uSOM)
> > 
> > I should update this line as well, I guess.
> > 
> > >          * CS1: PIC microcontroller (Pro models)
> > >          * CS2: mikrobus
> > >          */
> > > 
> > > I wouldn't have written "not populated on uSOM" without having first
> > > taken the uSOM off and physically checked.
> > 
> > Are these production SOMs or development/engineering samples?
> 
> I don't remember.
> 
> > Ilya Viten from the SolidRun commercial department told me that all production 
> > SOMs that were shipped to customers have the SPI flash populated.
> 
> Yes, Jon confirms that.
> 
> > This is just the default value for the common case.
> 
> Has it been tested with boards that don't have the SPI flash populated?
> That needs to happen to make sure that this doesn't cause a regression.

I don't have such a SOM handy. I can try to "produce" one next week.

I tested a modified DT with the 'reg' property set to 1 to simulate an 
unpopulated SPI flash. The driver probe seems to fail gracefully:

  m25p80 spi1.1: unrecognized JEDEC id bytes: ff, ff, ff

Is this test sufficient to ensure the safety of this patch?

baruch
Russell King - ARM Linux admin June 28, 2018, 11:13 a.m. UTC | #8
On Thu, Jun 28, 2018 at 01:47:30PM +0300, Baruch Siach wrote:
> Hi Russell,
> 
> On Thu, Jun 28, 2018 at 11:33:20AM +0100, Russell King - ARM Linux wrote:
> > On Thu, Jun 28, 2018 at 01:07:59PM +0300, Baruch Siach wrote:
> > > Thanks for reviewing.
> > > 
> > > On Thu, Jun 28, 2018 at 10:51:14AM +0100, Russell King - ARM Linux wrote:
> > > > On Thu, Jun 28, 2018 at 10:13:35AM +0300, Baruch Siach wrote:
> > > > > The SolidRun Armada 388 SOM has the SPI flash populated by default
> > > > > unless the customer explicitly asks otherwise. Enable support by
> > > > > default.
> > > > 
> > > > Are you sure about that - at least some of my boards do not have the
> > > > SPI flash populated.
> > > > 
> > > > &spi1 {
> > > >         /* The microsom has an optional W25Q32 on board, connected to CS0 */
> > > > ...
> > > > &spi1 {
> > > >         /*
> > > >          * Add SPI CS pins for clearfog:
> > > >          * CS0: W25Q32 (not populated on uSOM)
> > > 
> > > I should update this line as well, I guess.
> > > 
> > > >          * CS1: PIC microcontroller (Pro models)
> > > >          * CS2: mikrobus
> > > >          */
> > > > 
> > > > I wouldn't have written "not populated on uSOM" without having first
> > > > taken the uSOM off and physically checked.
> > > 
> > > Are these production SOMs or development/engineering samples?
> > 
> > I don't remember.
> > 
> > > Ilya Viten from the SolidRun commercial department told me that all production 
> > > SOMs that were shipped to customers have the SPI flash populated.
> > 
> > Yes, Jon confirms that.
> > 
> > > This is just the default value for the common case.
> > 
> > Has it been tested with boards that don't have the SPI flash populated?
> > That needs to happen to make sure that this doesn't cause a regression.
> 
> I don't have such a SOM handy. I can try to "produce" one next week.
> 
> I tested a modified DT with the 'reg' property set to 1 to simulate an 
> unpopulated SPI flash. The driver probe seems to fail gracefully:
> 
>   m25p80 spi1.1: unrecognized JEDEC id bytes: ff, ff, ff
> 
> Is this test sufficient to ensure the safety of this patch?

Yes, that's fine, thanks for checking.

Acked-by: Russell King <rmk+kernel@armlinux.org.uk>

Gregory, please add my acked-by to your hasty commit, thanks.
Gregory CLEMENT June 28, 2018, 11:38 a.m. UTC | #9
Hi Russell King,
 
 On jeu., juin 28 2018, Russell King - ARM Linux <linux@armlinux.org.uk> wrote:

> On Thu, Jun 28, 2018 at 01:47:30PM +0300, Baruch Siach wrote:
>> Hi Russell,
>> 
>> On Thu, Jun 28, 2018 at 11:33:20AM +0100, Russell King - ARM Linux wrote:
>> > On Thu, Jun 28, 2018 at 01:07:59PM +0300, Baruch Siach wrote:
>> > > Thanks for reviewing.
>> > > 
>> > > On Thu, Jun 28, 2018 at 10:51:14AM +0100, Russell King - ARM Linux wrote:
>> > > > On Thu, Jun 28, 2018 at 10:13:35AM +0300, Baruch Siach wrote:
>> > > > > The SolidRun Armada 388 SOM has the SPI flash populated by default
>> > > > > unless the customer explicitly asks otherwise. Enable support by
>> > > > > default.
>> > > > 
>> > > > Are you sure about that - at least some of my boards do not have the
>> > > > SPI flash populated.
>> > > > 
>> > > > &spi1 {
>> > > >         /* The microsom has an optional W25Q32 on board, connected to CS0 */
>> > > > ...
>> > > > &spi1 {
>> > > >         /*
>> > > >          * Add SPI CS pins for clearfog:
>> > > >          * CS0: W25Q32 (not populated on uSOM)
>> > > 
>> > > I should update this line as well, I guess.
>> > > 
>> > > >          * CS1: PIC microcontroller (Pro models)
>> > > >          * CS2: mikrobus
>> > > >          */
>> > > > 
>> > > > I wouldn't have written "not populated on uSOM" without having first
>> > > > taken the uSOM off and physically checked.
>> > > 
>> > > Are these production SOMs or development/engineering samples?
>> > 
>> > I don't remember.
>> > 
>> > > Ilya Viten from the SolidRun commercial department told me that all production 
>> > > SOMs that were shipped to customers have the SPI flash populated.
>> > 
>> > Yes, Jon confirms that.
>> > 
>> > > This is just the default value for the common case.
>> > 
>> > Has it been tested with boards that don't have the SPI flash populated?
>> > That needs to happen to make sure that this doesn't cause a regression.
>> 
>> I don't have such a SOM handy. I can try to "produce" one next week.
>> 
>> I tested a modified DT with the 'reg' property set to 1 to simulate an 
>> unpopulated SPI flash. The driver probe seems to fail gracefully:
>> 
>>   m25p80 spi1.1: unrecognized JEDEC id bytes: ff, ff, ff
>> 
>> Is this test sufficient to ensure the safety of this patch?
>
> Yes, that's fine, thanks for checking.
>
> Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
>
> Gregory, please add my acked-by to your hasty commit, thanks.

Done!

Thanks,

Gregory

>
> -- 
> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
> According to speedtest.net: 8.21Mbps down 510kbps up

Patch
diff mbox

diff --git a/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi b/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi
index 2d1cea131e71..c990d502d9a4 100644
--- a/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi
+++ b/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi
@@ -99,7 +99,6 @@ 
 		compatible = "w25q32", "jedec,spi-nor";
 		reg = <0>; /* Chip select 0 */
 		spi-max-frequency = <3000000>;
-		status = "disabled";
 	};
 };