From patchwork Thu Jun 28 12:39:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Borntraeger X-Patchwork-Id: 10493759 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 63CD56022E for ; Thu, 28 Jun 2018 12:39:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5092129A31 for ; Thu, 28 Jun 2018 12:39:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4415B29A2F; Thu, 28 Jun 2018 12:39:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 303F229A2F for ; Thu, 28 Jun 2018 12:39:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25A716B0005; Thu, 28 Jun 2018 08:39:28 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 2094A6B0006; Thu, 28 Jun 2018 08:39:28 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D1836B0007; Thu, 28 Jun 2018 08:39:28 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wr0-f199.google.com (mail-wr0-f199.google.com [209.85.128.199]) by kanga.kvack.org (Postfix) with ESMTP id AA8D96B0005 for ; Thu, 28 Jun 2018 08:39:27 -0400 (EDT) Received: by mail-wr0-f199.google.com with SMTP id u1-v6so30076wrs.18 for ; Thu, 28 Jun 2018 05:39:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:content-transfer-encoding:mime-version; bh=hZR25obLRGvSyz8VKTy0Xd7XpQTLBaC+reFBH9uUmiM=; b=SSRfYmw4TXSDzg00SUrO/HZsMAximsUW0tMH+YugrLg9QuC/8WZtm3G+7/gg2iqv9X DUe9474JoeL9ZUbOOob6ABFNIyjx9n8WO5GJ1W5Edsjdj+bS20tsKG/5iYzlwGnUFjfV FS8ben3SZyEz49VCuVo7UBxXBAa11mH+yCIGceYa0CjyTiUfV57KVjZSkM05wCyCbKBs ZOcTc022VPTnMppr7iK8hn44FXcRNLUhQgMhsLWaY/Ib0PGuou+6eE6iUqKxg0y2uq/B K3cqAU5ei+OLCAqhSXho7bu5CLZ6bb+1DT+u1WYj92PoRnzcqJgK8kvicM+RLAzGLiY2 qDAw== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of borntraeger@de.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=borntraeger@de.ibm.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com X-Gm-Message-State: APt69E3ksyEsR5D2Jyl5tjO0qAb5XwPclgux8lf/D6v/Sgj5Yj26iZBE oh6nW4hZJp9HvmBzVAgJXPxskaSr2v7Jt6ymrCQtj61/sGT2z9PxiVR7QDQxT93kiNJ0ca5oQfo aS2UCkLobDa9lkatRrBY9RwASVVJ3Zc67MxIGLBV4if4RiKhsk36b66wf9Cs4RiFIBQ== X-Received: by 2002:adf:e7d1:: with SMTP id e17-v6mr3371350wrn.136.1530189567266; Thu, 28 Jun 2018 05:39:27 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfEm+2Ee9oJk32+Zi9v/4fhYCqKA6ZUvABHjMM9kocc1WrkNfJdeP8YsZLDOB+y+8csA72e X-Received: by 2002:adf:e7d1:: with SMTP id e17-v6mr3371306wrn.136.1530189566428; Thu, 28 Jun 2018 05:39:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530189566; cv=none; d=google.com; s=arc-20160816; b=JcFF7krdKsHTSHEA5R9ZBmrPRPn+/jYhGnY/xMj6deYF45P2u3eQbaQUW9mRst4ekC BCEWA70Zm9QPWlJBAxiA2Sgb7xfENnDBuSxeE10B6osMiluEY0u5O7UehRsj4wiU6fKH j3lFzqiipz2jcCMUNP/CoUzbGelfjIzsviBAUz2yWaQOg+AotdmKTXXbOmptrl8rF234 eVva9GDHMTzLk6DD11U2e+rrkMEdZrHmUFdZgRMeY3CDZqhDTwwKWWFTm9IXuDlYtl0n sH32jQAvx7gNUPYJKYesMnAGWM1OsaoNGR9e/7fB+l5YNTq1nn5s9i/4KRH7iN5Kmj0m 2AjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:message-id:date:subject:cc :to:from:arc-authentication-results; bh=hZR25obLRGvSyz8VKTy0Xd7XpQTLBaC+reFBH9uUmiM=; b=VfsVLZyVCm1YMPxQAZjKJSoeFoG3q32Xb6GSXy7RckO4WPeCqpjlX1V4Kvvw9qKMP7 BG68r4L8effCAfFDdIveB0tjWquDlP0/zQFSzhjrLWUDk9bZwjAcK8uoXSI492gjSAUs VeLvtT79iF4xO5D5pNtwje1GqB4wzt5f7maoKslsQzUWS28nAl+m0kngnXEYTfqtylt9 yTWx53cohv6GlRbM9hRpWMQ50qeIrbR7d8KekJpXmIV7X/rf/hxOSRcE9ca7ddfyriLS xGVkpEPnigiDNGVf2sIB02oCfJmr+/qZLkfDI3BhUMl0pcjhBIbnsWywL8UWq3svzor9 GNpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of borntraeger@de.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=borntraeger@de.ibm.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com. [148.163.156.1]) by mx.google.com with ESMTPS id 34-v6si9944wri.145.2018.06.28.05.39.25 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jun 2018 05:39:26 -0700 (PDT) Received-SPF: pass (google.com: domain of borntraeger@de.ibm.com designates 148.163.156.1 as permitted sender) client-ip=148.163.156.1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of borntraeger@de.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=borntraeger@de.ibm.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w5SCdFni123460 for ; Thu, 28 Jun 2018 08:39:24 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2jvwppxs74-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 28 Jun 2018 08:39:23 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 28 Jun 2018 13:39:21 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 28 Jun 2018 13:39:18 +0100 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w5SCdHVx34406506 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 28 Jun 2018 12:39:17 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E4D7EA4059; Thu, 28 Jun 2018 13:39:06 +0100 (BST) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D3221A4057; Thu, 28 Jun 2018 13:39:06 +0100 (BST) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Thu, 28 Jun 2018 13:39:06 +0100 (BST) Received: by tuxmaker.boeblingen.de.ibm.com (Postfix, from userid 25651) id F294620F660; Thu, 28 Jun 2018 14:39:16 +0200 (CEST) From: Christian Borntraeger To: linux-mm@kvack.org, linux-s390@vger.kernel.org Cc: kvm@vger.kernel.org, Janosch Frank , David Hildenbrand , Cornelia Huck , linux-kernel@vger.kernel.org, Christian Borntraeger , Martin Schwidefsky , Andrea Arcangeli Subject: [PATCH/RFC] mm: do not drop unused pages when userfaultd is running Date: Thu, 28 Jun 2018 14:39:16 +0200 X-Mailer: git-send-email 2.17.0 X-TM-AS-GCONF: 00 x-cbid: 18062812-0008-0000-0000-0000024CD855 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18062812-0009-0000-0000-000021B35228 Message-Id: <20180628123916.96106-1-borntraeger@de.ibm.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-06-28_06:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1806280145 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP KVM guests on s390 can notify the host of unused pages. This can result in pte_unused callbacks to be true for KVM guest memory. If a page is unused (checked with pte_unused) we might drop this page instead of paging it. This can have side-effects on userfaultd, when the page in question was already migrated: The next access of that page will trigger a fault and a user fault instead of faulting in a new and empty zero page. As QEMU does not expect a userfault on an already migrated page this migration will fail. The most straightforward solution is to ignore the pte_unused hint if a userfault context is active for this VMA. Cc: Martin Schwidefsky Cc: Andrea Arcangeli Cc: stable@vger.kernel.org Signed-off-by: Christian Borntraeger --- mm/rmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/rmap.c b/mm/rmap.c index 6db729dc4c50..3f3a72aa99f2 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -1481,7 +1481,7 @@ static bool try_to_unmap_one(struct page *page, struct vm_area_struct *vma, set_pte_at(mm, address, pvmw.pte, pteval); } - } else if (pte_unused(pteval)) { + } else if (pte_unused(pteval) && !vma->vm_userfaultfd_ctx.ctx) { /* * The guest indicated that the page content is of no * interest anymore. Simply discard the pte, vmscan