diff mbox

[v2,2/2] iio: light: Add device tree binding for vishay vcnl4035

Message ID 20180629153802.1639514-2-pn@denx.de (mailing list archive)
State New, archived
Headers show

Commit Message

Parthiban Nallathambi June 29, 2018, 3:38 p.m. UTC 
Adding device tree binding for vcnl4035 and vendor
prefix for Vishay Intertechnology

Signed-off-by: Parthiban Nallathambi <pn@denx.de>
---
 .../devicetree/bindings/iio/light/vcnl4035.txt        | 19 +++++++++++++++++++
 Documentation/devicetree/bindings/vendor-prefixes.txt |  1 +
 2 files changed, 20 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/light/vcnl4035.txt

Comments

Rob Herring July 6, 2018, 8:34 p.m. UTC | #1 
On Fri, Jun 29, 2018 at 05:38:02PM +0200, Parthiban Nallathambi wrote:
> Adding device tree binding for vcnl4035 and vendor
> prefix for Vishay Intertechnology
> 
> Signed-off-by: Parthiban Nallathambi <pn@denx.de>
> ---
>  .../devicetree/bindings/iio/light/vcnl4035.txt        | 19 +++++++++++++++++++
>  Documentation/devicetree/bindings/vendor-prefixes.txt |  1 +
>  2 files changed, 20 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/light/vcnl4035.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/vcnl4035.txt b/Documentation/devicetree/bindings/iio/light/vcnl4035.txt
> new file mode 100644
> index 000000000000..7ffdc0246300
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/vcnl4035.txt
> @@ -0,0 +1,19 @@
> +VISHAY VCNL4035 -  Ambient Light and proximity sensor
> +
> +Link to datasheet: https://www.vishay.com/docs/84251/vcnl4035x01.pdf
> +
> +Required properties:
> +
> +	-compatible: should be "vishay,vcnl4035"
> +	-reg: I2C address of the sensor, should be 0x60
> +	- interrupt-parent: should be the phandle for the interrupt controller

Don't need to document this as it could be in a parent node.

> +	- interrupts: interrupt mapping for GPIO IRQ (level active low)
> +
> +Example:
> +
> +vcnl4035@60 {

light-sensor@60

> +	compatible = "vishay,vcnl4035";
> +	reg = <0x60>;
> +	interrupt-parent = <&gpio4>;
> +	interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> +};
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 7cad066191ee..3cc46d5735a9 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -395,6 +395,7 @@ v3	V3 Semiconductor
>  variscite	Variscite Ltd.
>  via	VIA Technologies, Inc.
>  virtio	Virtual I/O Device Specification, developed by the OASIS consortium
> +vishay	Vishay Intertechnology, Inc
>  vivante	Vivante Corporation
>  vocore VoCore Studio
>  voipac	Voipac Technologies s.r.o.
> -- 
> 2.14.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Parthiban Nallathambi July 7, 2018, 5:06 p.m. UTC | #2 
Hi Rob,

On 07/06/2018 10:34 PM, Rob Herring wrote:
> On Fri, Jun 29, 2018 at 05:38:02PM +0200, Parthiban Nallathambi wrote:
>> Adding device tree binding for vcnl4035 and vendor
>> prefix for Vishay Intertechnology
>>
>> Signed-off-by: Parthiban Nallathambi <pn@denx.de>
>> ---
>>  .../devicetree/bindings/iio/light/vcnl4035.txt        | 19 +++++++++++++++++++
>>  Documentation/devicetree/bindings/vendor-prefixes.txt |  1 +
>>  2 files changed, 20 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/iio/light/vcnl4035.txt
>>
>> diff --git a/Documentation/devicetree/bindings/iio/light/vcnl4035.txt b/Documentation/devicetree/bindings/iio/light/vcnl4035.txt
>> new file mode 100644
>> index 000000000000..7ffdc0246300
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/light/vcnl4035.txt
>> @@ -0,0 +1,19 @@
>> +VISHAY VCNL4035 -  Ambient Light and proximity sensor
>> +
>> +Link to datasheet: https://www.vishay.com/docs/84251/vcnl4035x01.pdf
>> +
>> +Required properties:
>> +
>> +	-compatible: should be "vishay,vcnl4035"
>> +	-reg: I2C address of the sensor, should be 0x60
>> +	- interrupt-parent: should be the phandle for the interrupt controller
> 
> Don't need to document this as it could be in a parent node.

Will remove it in v3, thanks.

> 
>> +	- interrupts: interrupt mapping for GPIO IRQ (level active low)
>> +
>> +Example:
>> +
>> +vcnl4035@60 {
> 
> light-sensor@60

Sure, thanks.

> 
>> +	compatible = "vishay,vcnl4035";
>> +	reg = <0x60>;
>> +	interrupt-parent = <&gpio4>;
>> +	interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
>> +};
>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
>> index 7cad066191ee..3cc46d5735a9 100644
>> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
>> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
>> @@ -395,6 +395,7 @@ v3	V3 Semiconductor
>>  variscite	Variscite Ltd.
>>  via	VIA Technologies, Inc.
>>  virtio	Virtual I/O Device Specification, developed by the OASIS consortium
>> +vishay	Vishay Intertechnology, Inc
>>  vivante	Vivante Corporation
>>  vocore VoCore Studio
>>  voipac	Voipac Technologies s.r.o.
>> -- 
>> 2.14.4
>>
>
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/iio/light/vcnl4035.txt b/Documentation/devicetree/bindings/iio/light/vcnl4035.txt
new file mode 100644
index 000000000000..7ffdc0246300
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/light/vcnl4035.txt
@@ -0,0 +1,19 @@ 
+VISHAY VCNL4035 -  Ambient Light and proximity sensor
+
+Link to datasheet: https://www.vishay.com/docs/84251/vcnl4035x01.pdf
+
+Required properties:
+
+	-compatible: should be "vishay,vcnl4035"
+	-reg: I2C address of the sensor, should be 0x60
+	- interrupt-parent: should be the phandle for the interrupt controller
+	- interrupts: interrupt mapping for GPIO IRQ (level active low)
+
+Example:
+
+vcnl4035@60 {
+	compatible = "vishay,vcnl4035";
+	reg = <0x60>;
+	interrupt-parent = <&gpio4>;
+	interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
+};
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 7cad066191ee..3cc46d5735a9 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -395,6 +395,7 @@  v3	V3 Semiconductor
 variscite	Variscite Ltd.
 via	VIA Technologies, Inc.
 virtio	Virtual I/O Device Specification, developed by the OASIS consortium
+vishay	Vishay Intertechnology, Inc
 vivante	Vivante Corporation
 vocore VoCore Studio
 voipac	Voipac Technologies s.r.o.