From patchwork Wed Jul 4 15:57:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Hellstrom X-Patchwork-Id: 10507299 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AAA57603D7 for ; Wed, 4 Jul 2018 15:58:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 96AF928BAE for ; Wed, 4 Jul 2018 15:58:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8B21828BD5; Wed, 4 Jul 2018 15:58:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2052128BAE for ; Wed, 4 Jul 2018 15:58:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 504C06EC26; Wed, 4 Jul 2018 15:58:44 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from NAM05-DM3-obe.outbound.protection.outlook.com (mail-dm3nam05on060b.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe51::60b]) by gabe.freedesktop.org (Postfix) with ESMTPS id E7BEB6EC1C for ; Wed, 4 Jul 2018 15:58:41 +0000 (UTC) Received: from fedoratest.localdomain (155.4.205.56) by DM6PR05MB4586.namprd05.prod.outlook.com (2603:10b6:5:9f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.13; Wed, 4 Jul 2018 15:58:39 +0000 From: Thomas Hellstrom To: dri-devel@lists.freedesktop.org Subject: [PATCH -next 5/9] drm/vmwgfx: Add support for SVGA3dCmdDefineGBSurface_v3 Date: Wed, 4 Jul 2018 17:57:46 +0200 Message-Id: <20180704155750.2749-6-thellstrom@vmware.com> X-Mailer: git-send-email 2.18.0.rc1 In-Reply-To: <20180704155750.2749-1-thellstrom@vmware.com> References: <20180704155750.2749-1-thellstrom@vmware.com> MIME-Version: 1.0 X-Originating-IP: [155.4.205.56] X-ClientProxiedBy: PR2P264CA0007.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::19) To DM6PR05MB4586.namprd05.prod.outlook.com (2603:10b6:5:9f::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c315725c-c1ef-4a59-35d8-08d5e1c702ce X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:DM6PR05MB4586; X-Microsoft-Exchange-Diagnostics: 1; DM6PR05MB4586; 3:BU5ckpV/AR5b10IMYvQrT5oPIfJ7a7l7cpZPrn6Jx06QRf/6W43LaY6imwdTUklA6QoO42hhSuHti9udJZ1/wJYjkKNHSGJJzNDHnxrWqyjNHehmQcrEP71pvC+K6rvxi68wIwUd8yJvnPyVPj+2h5OLqc81xpwzVMQm4+eDKn5PGs7AzikiI7nz4lCBAvrlLzi/CkLVtbaEYwYyw68ZrJibprJyteJeotJS80LgaHJYEt6cWCm+RvS+YtGvbDU+; 25:HP38gAcSFRBtmcwL9AxdDrgz4ORdwtbSqufoRBZkbHLXilyYUP6vNZ5Q7nGFgq2EMNfUUCpszSPd9H7UnUZuiCPKCrllMq6nGQrRFOiQ8ksdZ+NUmjbbH0SVhOAvJ+lvxCsqZruYLuFZKVEgkmGIQGP8ZHHPnzuoSqueVH3mMZcvOlZRuLFQJbkZTQOuQySspFMaNjfsiSqkdNCd6cfmgBAEjBoyxedr/aaWgbWJnlwHXdm8pWuS1cEMrD4WAPAtRsUFeTh09W09nz82DkFsiNP0ppdqp54y7Sr0+Vz057oEJQjYKDIhDPuPkmyst7pPRh2ofbxgiHYC7SEeSta4yg==; 31:+BJuXfJindF402ql1JEpLKuNZl+ZtzzMjRxz7kJF5uhhaRApCOmpU8vEl85Ut1r0p4e7PvXAjcqWybZ8f10yL2/FCAsMPSP30DyIevEDs9k5b9KF5AxLmTEL6NjF8UaQuhjs9UEYHvb6XaN6X1taeROhqJDMVzxF1Nc2obAbTefV7KD2PHhcGX+mdJjPlXPkw/vUW8xm+GYpni9TJ+4PfVX65yjMvQWlIe+IgzzXKzI= X-MS-TrafficTypeDiagnostic: DM6PR05MB4586: X-LD-Processed: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DM6PR05MB4586; 20:N3uzSNPXj+ZtJjsqaB78nQTn+pizsJxDjHdK6GzVxySTTccEMgaAv3pumd2I19MEDyg3OJNftg24cipBk8lhNE5lbXsWlUnNwLfbhilsGPCTFQI3vs1nd1B8xBttXi1WbkxSor8NiMWepTDy+RelHn/Zkd+4sthS4Bca/AnKerjFunZnsTaF1AHROXt1CHHqfabNBkdorPYPramt53Xot7BIZiSh75ggUdCTiFpLm//4aHRsC+Ow/qTTYrGXnlSiZKJnydPVwHHL55Y143cmQVLr6d6jU2WcKvRkeJjpfa3FV8WjVbXqhQ5olJIxY6jquSqgE49IOVqv9GHQa44MKdcg1gCWqU56kC+Ap7xBfahwIpzo124TxHlK4D3WW1leLQzX2hgkOwmuUorqlwaXGs+GojHb8MB3zM9oZXQGEd1de/p3JvlrlbtjvSae/iWoSA+Er2aP7yN/Sq53qBQpkgHJvmjHDLlTkq83/3UEQj/2uW3LG4pQkiwdEC56O9rZ; 4:BJoWOnpWYspMg3QCfiP8DyTZEzTj9hbcAZm00VsK6hXit1Cp35GJveZrEW0i0u08eW6BeCzw13UIrYbLZJwnR6jPSLm3+T6c43duRXwZ/0OedI4Q1htQH9VAx5FCdwjjSuDTU5RDbx3UmFqZnMbB/LzDJwGhJhrMDQJPG8Dd5xZ/mdGv3Y55txHF5nSafXvqIxRfv3T0nsM/hFbxCe64FZTXzokykcgDyzU/SUTyyG3JbZISAeqClSYpyxKKOlmJVnye+UMjW6bQamcJaROxyrnJxDjPmjfUl6Gx3VE4l5MIpCp9G67EK7UaOEHy4tck X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(61668805478150); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(149027)(150027)(6041310)(20161123562045)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:DM6PR05MB4586; BCL:0; PCL:0; RULEID:; SRVR:DM6PR05MB4586; X-Forefront-PRVS: 0723A02764 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(136003)(346002)(366004)(376002)(396003)(199004)(189003)(1076002)(48376002)(8676002)(478600001)(16586007)(2906002)(446003)(486006)(11346002)(81156014)(476003)(956004)(316002)(6486002)(2616005)(305945005)(81166006)(51416003)(7736002)(86362001)(6512007)(52116002)(68736007)(107886003)(53936002)(76176011)(2351001)(97736004)(6506007)(2361001)(105586002)(4326008)(25786009)(66066001)(47776003)(36756003)(186003)(50466002)(6916009)(26005)(6666003)(106356001)(8936002)(386003)(50226002)(16526019)(5660300001)(15760500003)(54906003)(3846002)(6116002)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR05MB4586; H:fedoratest.localdomain; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: vmware.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM6PR05MB4586; 23:3WuQZecTlsSypp4ZwmqYbBbaJBhV8td8W7gh5fnjC?= =?us-ascii?Q?5TfEq7UpMFEbwPzxLtwFhLAURc76ZsmtJd7lfnK0bmsJs//SvdogPsE7v8vT?= =?us-ascii?Q?1SrnEJV6smQ442KolQObCilPRL49OdWz1O0AZ0wF7wcHy7WBtnvQ06NgvFdS?= =?us-ascii?Q?hxPrzPIga8PHBE7Bfm6y4ejeCeJbno5Exep0z3bohjW+cZBE0JclF1De3Nnq?= =?us-ascii?Q?/plYUClJ1WDmfY3nS+bL3iCgCwkOR7dE/5vdhNWKiJSUh5wftv7vx/yAYkQM?= =?us-ascii?Q?9R/a5Rci7YA1xgwWhKxUSSpy1Q+AGahBQ/aXqNz/OCc7B/bV0oO4gmpXzcFO?= =?us-ascii?Q?jSoK4X4DRraju7cW/WB0EZT4CtxbqJy2SvfGIbevu2r95pAN3npBMvhJDOEO?= =?us-ascii?Q?bFk1AVtImgUhoVThifQXT8Vf0c5DWl4IujfBwjEYk+lwJpbpvCE1Amo6RLA0?= =?us-ascii?Q?dgjY9TNlcf0BYQrRQWG9POm6wuzPVF3KUZM2iLhOc2fQ1XRjnjrGjrRRViSk?= =?us-ascii?Q?x6wMvc1YXnUdy1zpECbjIUCZZujnLNNoQDSccv7OuiNLaq6BdwNbbpJdJg5K?= =?us-ascii?Q?bUOPuVjEKq0QPpViIAmG/SpOYlbZvRvKNgXM1KXki6EsfgA35zQcApJBef+9?= =?us-ascii?Q?Av3lShyYxiHjdCcJPx1GWysCGFuBuOgl17rS6tJoz/gtz/sWQXemHAsGmaHj?= =?us-ascii?Q?rQGFvGxfskEfMarWCK6FWKnTyflyB5f6npTbnBXz6Bfx3HfvPs0s4C1dpofT?= =?us-ascii?Q?JTXNDpg6NXGAORKkk5aBVJeAfVLBfqEm4v0AasNgkCPn1O0fea8sXNTEP7W4?= =?us-ascii?Q?LvyLVrNDpNjWNaKTCZyPE03KrpDAA5PNcft3ALCUM5DxpBNAav5h4HpFVvqt?= =?us-ascii?Q?PIK81QocModjpuun2f78YOhTGjVM40yPfj2vRKJ7Pes3amdn7zXJGnGQAYr5?= =?us-ascii?Q?0iIq8Fr7Tm+Vk0Wl5CYMXLntkoDNowFK1mn5Q09qu/0CfMAofZyYr1XbUfT/?= =?us-ascii?Q?20J3d485W4uLnzE4LRjgzusxXEZlSKJwstHp8VyUAa6hY7K01SrZtb7MrmjO?= =?us-ascii?Q?uaKmmWxDD2FSk33NSTIHRv46PG+Ai0pI0DHL0ym0OssC+Klb/cyxkAg/0DVI?= =?us-ascii?Q?BhzzMZeHue2KUeqEknGucTkwWSlNffvUA96TE9Z1xmg6vgbWsfUeebbI5yDJ?= =?us-ascii?Q?/Ee9tYEkOXN3B1khXbAIOKnBZ6QzgWU5/xVzEnJrMwkM2DY3IXXPoVG5fDbp?= =?us-ascii?Q?e1xqVM/DLkNA2VKGstvZDLi4acKBj3mXqbImsMto2UoGAlswSGKapAB9AIu+?= =?us-ascii?Q?cWyRfab9St+/2Y43NDQZy8=3D?= X-Microsoft-Antispam-Message-Info: cWgs9JDgIZ3csca6ts4NMBY9+jaUQuRaNfbl5nmhPmIwFnNM6g1Lwinm7dX9KBvkMwDDGWhwMaKAUCjDEPon4iiNllW1Arb8ol01Z2EQJjE7BfZzbrOzS9aIW59aO896Y6ifqAAp2gcLUjtsLteE/R4Tdy5o7xo9TdftRP/TWuBiCPorbIpGe008wa+wg4KCPI5NUg7IN/wXoTJMyj3ZtLUK5ZX4njQSUW0bCb/rCfaof5SudwS+tzW8NQD4Xv0ENtXQ32WJt/f5egIsxska6SYjH8dtSm67txZgp98Jy/b8Wh6553eYGjHaLgVM9ZUTSgQssgES9tXl52v4psu2bnuoukwSG8IuquUSpMgvP1s= X-Microsoft-Exchange-Diagnostics: 1; DM6PR05MB4586; 6:EgKbSF4H7fWUS2PnfWTjMcSLVsHGYbIJfVpw8fSsPgKRbN1TPASD16NIEoJyJrFqgKI4HDWgfIdXx1fU3dOR+hyDU3mQVemmWVDLDYDHIhNYoXVeloFnfiFKmoHsrwBzWUGNBSzVr6LfW4BINKj/oOtsdln+GsvYnk+JAe32wX4+NXAaG1aFIeQTXnwONPMjTM9GWr68RXSVvSloew1wSVMeLw1vsd89rczoHIFLk1823NiN/QvQHMXkg0VOklRXCk866Hi+8lTyiUj7BEfXexb9EKCUleD737BnS8QDZs3F6fdhFSkXFVIWnAFix/FSYhlM1KF8CdJZ5Gub0PMYcpuMdJjgOmljsj5y4dKzk7o5SBqQZOw+UdQJfEk3LPFc059H3u+mmICHmsxs9kwKuWnG7ZTpEcXGWfNzRRg7jMcwYo5S40zyoRP3GIJb4aFGQ+uMR/p0QidbgRPin+18Pw==; 5:VWQVTKlgoW9OsOu/PAqXn3R9Gfb1DHmdKMImjoc5V/bOLE2EEJTLH30nJPAgwHwyjyIxR9d2TPw46TmUGrhNxXTSZBSTiAMEXUid/hVkXtAaMSCrGPOg6eCkMS3GVWkkxOeSy1aFP9TNfgaLyf1ZOI0D0CGqBG8yJqdU+15OCvg=; 24:pyCacaqgJzJjuWz9hbfKcEdvMKnkPA0Rej+sQOWeqGrt0JRpMX4CRBDX6ZABWAYtvE8nas+kx5B6P022DulCzSLmXbg48EyztxREZXnJSoA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM6PR05MB4586; 7:O2W9SvS7/WuyOCSDMFTBPNhhex7LP2vPir65ZDy/etQpREz6m1M7CNnjoXUAim6X2hnXkI7ll77QRlgMZTibSMZedtzRQ+MNBh+vmwvaDUyHrn6/uSPFU/ddyFQY4UqtDD1Q+YKti4PF5RJFDCgce5IuDf6pNspwOSUyRplcHR5A8sD8dKMBQd4rf70L/ecTJ0fweMSp4vNlnbj6weZ4Tdkf3n1SMbxlhbIcnVX0kzXYWJaqSI9h8yVB/0QehsPK; 20:cTNgLdobefYHFZv65EffHSpyWuzmHLbwkA9ua4IRA9h2J4+mOATU3T/3Q5A/4KwdCXaFfBasxKRYBqYvCjFocvcws43lh4Srvww0nS2BATZtmVed+9Uo0ZeAivma3pdrVudbZbkWvAXVQF9rS72kACKpT5hVbU09r0/6ij5Noz8= X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2018 15:58:39.5797 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c315725c-c1ef-4a59-35d8-08d5e1c702ce X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR05MB4586 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Hellstrom , Deepak Rawat , linux-graphics-maintainer@vmware.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Deepak Rawat SVGA device added new command SVGA3dCmdDefineGBSurface_v3 which allows 64-bit SVGA3dSurfaceAllFlags. This commit adds support for SVGA3dCmdDefineGBSurface_v3 command in vmwgfx. Signed-off-by: Deepak Rawat Reviewed-by: Sinclair Yeh Reviewed-by: Brian Paul Reviewed-by: Thomas Hellstrom Reviewed-by: Charmaine Lee Signed-off-by: Thomas Hellstrom --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 2 ++ drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 3 +++ drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 32 +++++++++++++++++++++++-- 3 files changed, 35 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h index 7bb08bac728e..06cce72b7b9e 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h @@ -180,6 +180,8 @@ struct vmw_surface { SVGA3dTextureFilter autogen_filter; uint32_t multisample_count; struct list_head view_list; + SVGA3dMSPattern multisample_pattern; + SVGA3dMSQualityLevel quality_level; }; struct vmw_marker_queue { diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c index 15f2cb2a151b..6630abf3a95c 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c @@ -1157,6 +1157,9 @@ vmw_stdu_primary_plane_prepare_fb(struct drm_plane *plane, content_srf.flags = 0; content_srf.mip_levels[0] = 1; content_srf.multisample_count = 0; + content_srf.multisample_pattern = + SVGA3D_MS_PATTERN_NONE; + content_srf.quality_level = SVGA3D_MS_QUALITY_NONE; } else { content_srf = *new_vfbs->surface; } diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c index e90f8d39de53..2abf9a895605 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c @@ -785,6 +785,8 @@ int vmw_surface_define_ioctl(struct drm_device *dev, void *data, srf->base_size = *srf->sizes; srf->autogen_filter = SVGA3D_TEX_FILTER_NONE; srf->multisample_count = 0; + srf->multisample_pattern = SVGA3D_MS_PATTERN_NONE; + srf->quality_level = SVGA3D_MS_QUALITY_NONE; cur_bo_offset = 0; cur_offset = srf->offsets; @@ -1031,6 +1033,10 @@ static int vmw_gb_surface_create(struct vmw_resource *res) SVGA3dCmdHeader header; SVGA3dCmdDefineGBSurface_v2 body; } *cmd2; + struct { + SVGA3dCmdHeader header; + SVGA3dCmdDefineGBSurface_v3 body; + } *cmd3; if (likely(res->id != -1)) return 0; @@ -1047,7 +1053,11 @@ static int vmw_gb_surface_create(struct vmw_resource *res) goto out_no_fifo; } - if (srf->array_size > 0) { + if (dev_priv->has_sm4_1 && srf->array_size > 0) { + cmd_id = SVGA_3D_CMD_DEFINE_GB_SURFACE_V3; + cmd_len = sizeof(cmd3->body); + submit_len = sizeof(*cmd3); + } else if (srf->array_size > 0) { /* has_dx checked on creation time. */ cmd_id = SVGA_3D_CMD_DEFINE_GB_SURFACE_V2; cmd_len = sizeof(cmd2->body); @@ -1060,6 +1070,7 @@ static int vmw_gb_surface_create(struct vmw_resource *res) cmd = vmw_fifo_reserve(dev_priv, submit_len); cmd2 = (typeof(cmd2))cmd; + cmd3 = (typeof(cmd3))cmd; if (unlikely(!cmd)) { DRM_ERROR("Failed reserving FIFO space for surface " "creation.\n"); @@ -1067,7 +1078,22 @@ static int vmw_gb_surface_create(struct vmw_resource *res) goto out_no_fifo; } - if (srf->array_size > 0) { + if (dev_priv->has_sm4_1 && srf->array_size > 0) { + cmd3->header.id = cmd_id; + cmd3->header.size = cmd_len; + cmd3->body.sid = srf->res.id; + cmd3->body.surfaceFlags = (SVGA3dSurfaceAllFlags)srf->flags; + cmd3->body.format = srf->format; + cmd3->body.numMipLevels = srf->mip_levels[0]; + cmd3->body.multisampleCount = srf->multisample_count; + cmd3->body.multisamplePattern = srf->multisample_pattern; + cmd3->body.qualityLevel = srf->quality_level; + cmd3->body.autogenFilter = srf->autogen_filter; + cmd3->body.size.width = srf->base_size.width; + cmd3->body.size.height = srf->base_size.height; + cmd3->body.size.depth = srf->base_size.depth; + cmd3->body.arraySize = srf->array_size; + } else if (srf->array_size > 0) { cmd2->header.id = cmd_id; cmd2->header.size = cmd_len; cmd2->body.sid = srf->res.id; @@ -1561,6 +1587,8 @@ int vmw_surface_gb_priv_define(struct drm_device *dev, srf->autogen_filter = SVGA3D_TEX_FILTER_NONE; srf->array_size = array_size; srf->multisample_count = multisample_count; + srf->multisample_pattern = SVGA3D_MS_PATTERN_NONE; + srf->quality_level = SVGA3D_MS_QUALITY_NONE; if (array_size) num_layers = array_size;