diff mbox

ARM: dts: sun8i: sun8i-a83t-bananapi-m3: enhance vcc-pd to 3.3v

Message ID 1531165914-29760-1-git-send-email-clabbe@baylibre.com (mailing list archive)
State New, archived
Headers show

Commit Message

Corentin LABBE July 9, 2018, 7:51 p.m. UTC
Since commit d7c5f6863550 ("ARM: dts: sun8i: a83t: bananapi-m3: Add AXP813 regulator nodes")
my BPIM3 no longer works at gigabit speed.

With the default setting, dldo3 is regulated at 2.9v which seems
sufficient for the PHy but d7c5f6863550 drop it to 2.5 which is insufficient.
Note that this behaviour is random for all BPIM3 (some works with 2.5, some not)

Finnaly, someone from bananapi confirmed that this regulator must be set to 3.3

Fixes: d7c5f6863550 ("ARM: dts: sun8i: a83t: bananapi-m3: Add AXP813 regulator nodes")
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Maxime Ripard July 11, 2018, 8:24 a.m. UTC | #1
On Mon, Jul 09, 2018 at 07:51:54PM +0000, Corentin Labbe wrote:
> Since commit d7c5f6863550 ("ARM: dts: sun8i: a83t: bananapi-m3: Add AXP813 regulator nodes")
> my BPIM3 no longer works at gigabit speed.
> 
> With the default setting, dldo3 is regulated at 2.9v which seems
> sufficient for the PHy but d7c5f6863550 drop it to 2.5 which is insufficient.
> Note that this behaviour is random for all BPIM3 (some works with 2.5, some not)
> 
> Finnaly, someone from bananapi confirmed that this regulator must be set to 3.3
> 
> Fixes: d7c5f6863550 ("ARM: dts: sun8i: a83t: bananapi-m3: Add AXP813 regulator nodes")
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>

Applied, thanks!
Maxime
diff mbox

Patch

diff --git a/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts b/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts
index c7ce4158d6c8..f250b20af493 100644
--- a/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts
+++ b/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts
@@ -309,8 +309,8 @@ 
 
 &reg_dldo3 {
 	regulator-always-on;
-	regulator-min-microvolt = <2500000>;
-	regulator-max-microvolt = <2500000>;
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
 	regulator-name = "vcc-pd";
 };