| Message ID | 20180710004602.21599-2-labbott@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jul 09, 2018 at 05:45:56PM -0700, Laura Abbott wrote: > Commit 0c3b7e42616f ("tools build: Add support for host programs format") > introduced host_c_flags which referenced CHOSTFLAGS. The actual name of the > variable is HOSTCFLAGS. Fix this up. > > Fixes: 0c3b7e42616f ("tools build: Add support for host programs format") > Signed-off-by: Laura Abbott <labbott@redhat.com> > --- > v2: Also fixed another instance in perf pmu-events. Acked-by: Jiri Olsa <jolsa@kernel.org> cc-ing more folks, that were in initial patch for heads up thanks, jirka > --- > tools/build/Build.include | 2 +- > tools/perf/pmu-events/Build | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/build/Build.include b/tools/build/Build.include > index a4bbb984941d..b5c679cd441c 100644 > --- a/tools/build/Build.include > +++ b/tools/build/Build.include > @@ -98,4 +98,4 @@ cxx_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(CXXFLAGS) -D"BUILD_STR(s)=\#s" $(CXX > ### > ## HOSTCC C flags > > -host_c_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(CHOSTFLAGS) -D"BUILD_STR(s)=\#s" $(CHOSTFLAGS_$(basetarget).o) $(CHOSTFLAGS_$(obj)) > +host_c_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(HOSTCFLAGS) -D"BUILD_STR(s)=\#s" $(HOSTCFLAGS_$(basetarget).o) $(HOSTCFLAGS_$(obj)) > diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build > index 17783913d330..215ba30b8534 100644 > --- a/tools/perf/pmu-events/Build > +++ b/tools/perf/pmu-events/Build > @@ -1,7 +1,7 @@ > hostprogs := jevents > > jevents-y += json.o jsmn.o jevents.o > -CHOSTFLAGS_jevents.o = -I$(srctree)/tools/include > +HOSTCFLAGS_jevents.o = -I$(srctree)/tools/include > pmu-events-y += pmu-events.o > JDIR = pmu-events/arch/$(SRCARCH) > JSON = $(shell [ -d $(JDIR) ] && \ > -- > 2.17.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2018-07-10 16:38 GMT+09:00 Jiri Olsa <jolsa@redhat.com>: > On Mon, Jul 09, 2018 at 05:45:56PM -0700, Laura Abbott wrote: >> Commit 0c3b7e42616f ("tools build: Add support for host programs format") >> introduced host_c_flags which referenced CHOSTFLAGS. The actual name of the >> variable is HOSTCFLAGS. Fix this up. >> >> Fixes: 0c3b7e42616f ("tools build: Add support for host programs format") >> Signed-off-by: Laura Abbott <labbott@redhat.com> >> --- >> v2: Also fixed another instance in perf pmu-events. > > Acked-by: Jiri Olsa <jolsa@kernel.org> > > cc-ing more folks, that were in initial patch for heads up > > thanks, > jirka > Applied to linux-kbuild/fixes. Thanks! > >> --- >> tools/build/Build.include | 2 +- >> tools/perf/pmu-events/Build | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/tools/build/Build.include b/tools/build/Build.include >> index a4bbb984941d..b5c679cd441c 100644 >> --- a/tools/build/Build.include >> +++ b/tools/build/Build.include >> @@ -98,4 +98,4 @@ cxx_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(CXXFLAGS) -D"BUILD_STR(s)=\#s" $(CXX >> ### >> ## HOSTCC C flags >> >> -host_c_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(CHOSTFLAGS) -D"BUILD_STR(s)=\#s" $(CHOSTFLAGS_$(basetarget).o) $(CHOSTFLAGS_$(obj)) >> +host_c_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(HOSTCFLAGS) -D"BUILD_STR(s)=\#s" $(HOSTCFLAGS_$(basetarget).o) $(HOSTCFLAGS_$(obj)) >> diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build >> index 17783913d330..215ba30b8534 100644 >> --- a/tools/perf/pmu-events/Build >> +++ b/tools/perf/pmu-events/Build >> @@ -1,7 +1,7 @@ >> hostprogs := jevents >> >> jevents-y += json.o jsmn.o jevents.o >> -CHOSTFLAGS_jevents.o = -I$(srctree)/tools/include >> +HOSTCFLAGS_jevents.o = -I$(srctree)/tools/include >> pmu-events-y += pmu-events.o >> JDIR = pmu-events/arch/$(SRCARCH) >> JSON = $(shell [ -d $(JDIR) ] && \ >> -- >> 2.17.1 >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tools/build/Build.include b/tools/build/Build.include index a4bbb984941d..b5c679cd441c 100644 --- a/tools/build/Build.include +++ b/tools/build/Build.include @@ -98,4 +98,4 @@ cxx_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(CXXFLAGS) -D"BUILD_STR(s)=\#s" $(CXX ### ## HOSTCC C flags -host_c_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(CHOSTFLAGS) -D"BUILD_STR(s)=\#s" $(CHOSTFLAGS_$(basetarget).o) $(CHOSTFLAGS_$(obj)) +host_c_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(HOSTCFLAGS) -D"BUILD_STR(s)=\#s" $(HOSTCFLAGS_$(basetarget).o) $(HOSTCFLAGS_$(obj)) diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build index 17783913d330..215ba30b8534 100644 --- a/tools/perf/pmu-events/Build +++ b/tools/perf/pmu-events/Build @@ -1,7 +1,7 @@ hostprogs := jevents jevents-y += json.o jsmn.o jevents.o -CHOSTFLAGS_jevents.o = -I$(srctree)/tools/include +HOSTCFLAGS_jevents.o = -I$(srctree)/tools/include pmu-events-y += pmu-events.o JDIR = pmu-events/arch/$(SRCARCH) JSON = $(shell [ -d $(JDIR) ] && \
Commit 0c3b7e42616f ("tools build: Add support for host programs format") introduced host_c_flags which referenced CHOSTFLAGS. The actual name of the variable is HOSTCFLAGS. Fix this up. Fixes: 0c3b7e42616f ("tools build: Add support for host programs format") Signed-off-by: Laura Abbott <labbott@redhat.com> --- v2: Also fixed another instance in perf pmu-events. --- tools/build/Build.include | 2 +- tools/perf/pmu-events/Build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)