Patchwork [2/2] crypto: ECDH - fix typo of P-192 b value

login
register
mail settings
Submitter Stephan Mueller
Date July 11, 2018, 6:36 p.m.
Message ID <31905154.JqEMqoRUPu@positron.chronox.de>
Download mbox | patch
Permalink /patch/10520281/
State Accepted
Delegated to: Herbert Xu
Headers show

Comments

Stephan Mueller - July 11, 2018, 6:36 p.m.
Fix the b value to be compliant with FIPS 186-4 D.1.2.1. This fix is
required to make sure the SP800-56A public key test passes for P-192.

Signed-off-by: Stephan Mueller <smueller@chronox.de>
---
 crypto/ecc_curve_defs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Herbert Xu - July 20, 2018, 5:55 a.m.
On Wed, Jul 11, 2018 at 08:36:23PM +0200, Stephan Müller wrote:
> Fix the b value to be compliant with FIPS 186-4 D.1.2.1. This fix is
> required to make sure the SP800-56A public key test passes for P-192.
> 
> Signed-off-by: Stephan Mueller <smueller@chronox.de>

Patch applied.  Thanks.

Patch

diff --git a/crypto/ecc_curve_defs.h b/crypto/ecc_curve_defs.h
index 94e883a9403f..336ab1805639 100644
--- a/crypto/ecc_curve_defs.h
+++ b/crypto/ecc_curve_defs.h
@@ -27,7 +27,7 @@  static u64 nist_p192_p[] = { 0xFFFFFFFFFFFFFFFFull, 0xFFFFFFFFFFFFFFFEull,
 static u64 nist_p192_n[] = { 0x146BC9B1B4D22831ull, 0xFFFFFFFF99DEF836ull,
 				0xFFFFFFFFFFFFFFFFull };
 static u64 nist_p192_a[] = { 0xFFFFFFFFFFFFFFFCull, 0xFFFFFFFFFFFFFFFEull,
-				0xFFFFFFFFFFFFFFFEull };
+				0xFFFFFFFFFFFFFFFFull };
 static u64 nist_p192_b[] = { 0xFEB8DEECC146B9B1ull, 0x0FA7E9AB72243049ull,
 				0x64210519E59C80E7ull };
 static struct ecc_curve nist_p192 = {