NFS: silence a harmless uninitialized variable warning
diff mbox

Message ID 20180712122929.dshlwi3obipq6vfm@kili.mountain
State New
Headers show

Commit Message

Dan Carpenter July 12, 2018, 12:29 p.m. UTC
kstrtoul() can return -ERANGE so Smatch complains that "num" can be
uninitialized.  We check that it's within bounds so it's not a huge

Signed-off-by: Dan Carpenter <>

To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to
More majordomo info at

diff mbox

diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index b5f27d6999e5..d81a33461bee 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -2901,7 +2901,7 @@  static int param_set_portnr(const char *val, const struct kernel_param *kp)
 	if (!val)
 		return -EINVAL;
 	ret = kstrtoul(val, 0, &num);
-	if (ret == -EINVAL || num > NFS_CALLBACK_MAXPORTNR)
+	if (ret || num > NFS_CALLBACK_MAXPORTNR)
 		return -EINVAL;
 	*((unsigned int *)kp->arg) = num;
 	return 0;