sunrpc: kstrtoul() can also return -ERANGE
diff mbox

Message ID 20180712123008.3aejokccq2smpctq@kili.mountain
State New
Headers show

Commit Message

Dan Carpenter July 12, 2018, 12:30 p.m. UTC
Smatch complains that "num" can be uninitialized when kstrtoul() returns
-ERANGE.  It's true enough, but basically harmless in this case.

Signed-off-by: Dan Carpenter <>

To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to
More majordomo info at

diff mbox

diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c
index d2623b9f23d6..7bb3f2062045 100644
--- a/net/sunrpc/auth.c
+++ b/net/sunrpc/auth.c
@@ -50,7 +50,7 @@  static int param_set_hashtbl_sz(const char *val, const struct kernel_param *kp)
 	if (!val)
 		goto out_inval;
 	ret = kstrtoul(val, 0, &num);
-	if (ret == -EINVAL)
+	if (ret)
 		goto out_inval;
 	nbits = fls(num - 1);
 	if (nbits > MAX_HASHTABLE_BITS || nbits < 2)