| Message ID | 1531499278-32132-2-git-send-email-thor.thayer@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jul 13, 2018 at 11:27:56AM -0500, thor.thayer@linux.intel.com wrote: > From: Thor Thayer <thor.thayer@linux.intel.com> > > Add a clock to the SMMU node bindings. > > Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com> > --- > Documentation/devicetree/bindings/iommu/arm,smmu.txt | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.txt b/Documentation/devicetree/bindings/iommu/arm,smmu.txt > index 8a6ffce12af5..356fd9f41e1b 100644 > --- a/Documentation/devicetree/bindings/iommu/arm,smmu.txt > +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.txt > @@ -71,6 +71,8 @@ conditions. > or using stream matching with #iommu-cells = <2>, and > may be ignored if present in such cases. > > +- clock: clock provider specifier > + The TRM says there is a TCU clock and clock per TBU. Rob
Hi Rob, On 07/20/2018 11:15 AM, Rob Herring wrote: > On Fri, Jul 13, 2018 at 11:27:56AM -0500, thor.thayer@linux.intel.com wrote: >> From: Thor Thayer <thor.thayer@linux.intel.com> >> >> Add a clock to the SMMU node bindings. >> >> Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com> >> --- >> Documentation/devicetree/bindings/iommu/arm,smmu.txt | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.txt b/Documentation/devicetree/bindings/iommu/arm,smmu.txt >> index 8a6ffce12af5..356fd9f41e1b 100644 >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.txt >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.txt >> @@ -71,6 +71,8 @@ conditions. >> or using stream matching with #iommu-cells = <2>, and >> may be ignored if present in such cases. >> >> +- clock: clock provider specifier >> + > > The TRM says there is a TCU clock and clock per TBU. > > Rob > Yes, good point. I'm abandoning this review and will use the bulk clock suggested in [1]. In our case, the TCU clock is always on and we have 1 clock for the TBU masters. Thanks for reviewing! Thor [1] https://patchwork.kernel.org/patch/10534089/
diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.txt b/Documentation/devicetree/bindings/iommu/arm,smmu.txt index 8a6ffce12af5..356fd9f41e1b 100644 --- a/Documentation/devicetree/bindings/iommu/arm,smmu.txt +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.txt @@ -71,6 +71,8 @@ conditions. or using stream matching with #iommu-cells = <2>, and may be ignored if present in such cases. +- clock: clock provider specifier + ** Deprecated properties: - mmu-masters (deprecated in favour of the generic "iommus" binding) : @@ -137,3 +139,17 @@ conditions. iommu-map = <0 &smmu3 0 0x400>; ... }; + + /* ARM MMU-500 with clock node */ + smmu4: iommu { + compatible = "arm,mmu-500", "arm,smmu-v2"; + clocks = <&clkmgr STRATIX10_L4_MAIN_CLK>; + ... + #iommu-cells = <1>; + }; + + /* device with stream ID 1 */ + master4 { + iommus = <&smmu4 1>; + }; +