diff mbox

[v4,1/5] clk: actions: Add REGMAP as dependency

Message ID 20180715123145.16975-2-sravanhome@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

saravanan sekar July 15, 2018, 12:31 p.m. UTC
Add REGMAP as dependency to avoid undefined reference to regmap symbol

Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
---
 drivers/clk/actions/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Andreas Färber July 15, 2018, 12:35 p.m. UTC | #1
Hi,

Am 15.07.2018 um 14:31 schrieb Saravanan Sekar:
> Add REGMAP as dependency to avoid undefined reference to regmap symbol

Is this a bugfix for S900? Then please add a Fixes: line. If not, why is
it a separate patch and not in 3/5?

Also, the subject is fine as is, but please add a full stop at the end
of the sentence in the commit message.

Regards,
Andreas
Manivannan Sadhasivam July 15, 2018, 2:15 p.m. UTC | #2
Hi,

On Sun, Jul 15, 2018 at 02:35:53PM +0200, Andreas Färber wrote:
> Hi,
> 
> Am 15.07.2018 um 14:31 schrieb Saravanan Sekar:
> > Add REGMAP as dependency to avoid undefined reference to regmap symbol
> 
> Is this a bugfix for S900? Then please add a Fixes: line. If not, why is
> it a separate patch and not in 3/5?
> 

Yes, this is a bug fix for S900 clk and should have Fixes tag.

Thanks,
Mani

> Also, the subject is fine as is, but please add a full stop at the end
> of the sentence in the commit message.
> 
> Regards,
> Andreas
> 
> 
> -- 
> SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)
diff mbox

Patch

diff --git a/drivers/clk/actions/Kconfig b/drivers/clk/actions/Kconfig
index 8854adb37847..39491154abbf 100644
--- a/drivers/clk/actions/Kconfig
+++ b/drivers/clk/actions/Kconfig
@@ -1,6 +1,7 @@ 
 config CLK_ACTIONS
 	bool "Clock driver for Actions Semi SoCs"
 	depends on ARCH_ACTIONS || COMPILE_TEST
+	select REGMAP_MMIO
 	default ARCH_ACTIONS
 
 if CLK_ACTIONS