From patchwork Tue Jul 17 13:49:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ram Pai X-Patchwork-Id: 10529465 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 30609600F4 for ; Tue, 17 Jul 2018 13:50:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 16F9729087 for ; Tue, 17 Jul 2018 13:50:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0B52429221; Tue, 17 Jul 2018 13:50:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B1C6229087 for ; Tue, 17 Jul 2018 13:50:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731680AbeGQOXF (ORCPT ); Tue, 17 Jul 2018 10:23:05 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:40181 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731569AbeGQOXF (ORCPT ); Tue, 17 Jul 2018 10:23:05 -0400 Received: by mail-qt0-f196.google.com with SMTP id h4-v6so884202qtj.7; Tue, 17 Jul 2018 06:50:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=bkiErPspo3EK2aWCWuIgKpEXyXDS844E5uOtyP7WDm4=; b=HfS2XKxNPxPsuMN7olnl9D7N7E1FcAtlUUQXtvdgbIGWP4B/Q5ZUqEJqQKGVZR52X7 0i8PcPHL9ujQnrIiKnyZSJAEcDI9mA/xH6afZ+YxvkEagkSScbbJLEW+gSILdV92IBWT fPuqkzbEvJQmgodSYwADc5dfbXCwGjdVum8vaTOZiMjBMUvgWn6qenGN3aId69wXocZd M1zOMNYLLzBFpyXmimi/gsGYJ511sZk/7w0sL+hWJ9ZUdEf7siLZ++oNTMUEqPFypzjN eXAN3vuEBYQyrUtkCNt1tvNFiS0pJd5OIgfkqGDhf4lTsymWtARRyDcq/DA6rO3ne+Ob m19A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=bkiErPspo3EK2aWCWuIgKpEXyXDS844E5uOtyP7WDm4=; b=IQJqhBl7zNA/yRCzD1XXa/ZIhCOM430QvnzCDqb1IQtH9QxVQKXg7haYt2M+xKHomx eecm8Zd1wNb3QyAJDz2t/ZJSxK8vibXi8HA2b42RPAm3piG3xeyDH3YcKdBL2W684QA2 dMbAXhi0aIXTKYUaUmIlGlCB4UXCSoEHNnx17Vz8hDKt8oEUEZzzE15mNyBdXeCYqflN Zb1QIOdHD4LbF1/RoFX0RNa4hmHoE0tCzBCnmQhj8U/Qs4ul+9dXZO2OhC5j+Z3y7rUT i7WN8jaDvlegiSr2J1YF8+4vbRBU/V8Zp/DxEjtOuAGM2rWR93+BmeV5SIt0WKNeeZhl DHUQ== X-Gm-Message-State: AOUpUlGcZ9Kk2Vp+ecyoq4VN8lU2c11DF37wjrVebnXFlSPe0hrLOSDj mBPtzWu0k1UGIj7pWXn1QVk= X-Google-Smtp-Source: AAOMgpdCFH5vXkl8g1AUeU0wUYoJ/lWPLGWFF+ldXbI4f48fy7Pe5DeGdg3ObUODJwW9st2DlFVT5w== X-Received: by 2002:a0c:ac85:: with SMTP id m5-v6mr1769565qvc.197.1531835419515; Tue, 17 Jul 2018 06:50:19 -0700 (PDT) Received: from localhost.localdomain (50-39-100-161.bvtn.or.frontiernet.net. [50.39.100.161]) by smtp.gmail.com with ESMTPSA id s83-v6sm640937qki.20.2018.07.17.06.50.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Jul 2018 06:50:19 -0700 (PDT) From: Ram Pai To: shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, mingo@redhat.com, dave.hansen@intel.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com, linuxram@us.ibm.com, fweimer@redhat.com, msuchanek@suse.de, aneesh.kumar@linux.vnet.ibm.com Subject: [PATCH v14 08/22] selftests/vm: fix the wrong assert in pkey_disable_set() Date: Tue, 17 Jul 2018 06:49:11 -0700 Message-Id: <1531835365-32387-9-git-send-email-linuxram@us.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1531835365-32387-1-git-send-email-linuxram@us.ibm.com> References: <1531835365-32387-1-git-send-email-linuxram@us.ibm.com> Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If the flag is 0, no bits will be set. Hence we cant expect the resulting bitmap to have a higher value than what it was earlier. cc: Dave Hansen cc: Florian Weimer Signed-off-by: Ram Pai --- tools/testing/selftests/vm/protection_keys.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/testing/selftests/vm/protection_keys.c b/tools/testing/selftests/vm/protection_keys.c index fb7dd32..2dd94c3 100644 --- a/tools/testing/selftests/vm/protection_keys.c +++ b/tools/testing/selftests/vm/protection_keys.c @@ -415,7 +415,7 @@ void pkey_disable_set(int pkey, int flags) dprintf1("%s(%d) pkey_reg: 0x"PKEY_REG_FMT"\n", __func__, pkey, read_pkey_reg()); if (flags) - pkey_assert(read_pkey_reg() > orig_pkey_reg); + pkey_assert(read_pkey_reg() >= orig_pkey_reg); dprintf1("END<---%s(%d, 0x%x)\n", __func__, pkey, flags); }