| Message ID | 20180719234217.7855-1-rodrigo.vivi@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jul 19, 2018 at 04:42:17PM -0700, Rodrigo Vivi wrote: > Just a small clean-up with no functional change, only > removing a variable that is never actually used. > > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Nice one :) Reviewed-by: <nathan.d.ciobanu@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_dp_mst.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c > index 7e3e01607643..18c65f8e4fe8 100644 > --- a/drivers/gpu/drm/i915/intel_dp_mst.c > +++ b/drivers/gpu/drm/i915/intel_dp_mst.c > @@ -263,7 +263,6 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder, > struct intel_dp *intel_dp = &intel_dig_port->dp; > struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); > enum port port = intel_dig_port->base.port; > - int ret; > > DRM_DEBUG_KMS("active links %d\n", intel_dp->active_mst_links); > > @@ -274,9 +273,9 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder, > 1)) > DRM_ERROR("Timed out waiting for ACT sent\n"); > > - ret = drm_dp_check_act_status(&intel_dp->mst_mgr); > + drm_dp_check_act_status(&intel_dp->mst_mgr); > > - ret = drm_dp_update_payload_part2(&intel_dp->mst_mgr); > + drm_dp_update_payload_part2(&intel_dp->mst_mgr); > if (pipe_config->has_audio) > intel_audio_codec_enable(encoder, pipe_config, conn_state); > } > -- > 2.17.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Thu, Jul 19, 2018 at 05:16:03PM -0700, Nathan Ciobanu wrote: > On Thu, Jul 19, 2018 at 04:42:17PM -0700, Rodrigo Vivi wrote: > > Just a small clean-up with no functional change, only > > removing a variable that is never actually used. > > > > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > Nice one :) > Reviewed-by: <nathan.d.ciobanu@linux.intel.com> Reviewed-by: Nathan Ciobanu <nathan.d.ciobanu@linux.intel.com> > > --- > > drivers/gpu/drm/i915/intel_dp_mst.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c > > index 7e3e01607643..18c65f8e4fe8 100644 > > --- a/drivers/gpu/drm/i915/intel_dp_mst.c > > +++ b/drivers/gpu/drm/i915/intel_dp_mst.c > > @@ -263,7 +263,6 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder, > > struct intel_dp *intel_dp = &intel_dig_port->dp; > > struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); > > enum port port = intel_dig_port->base.port; > > - int ret; > > > > DRM_DEBUG_KMS("active links %d\n", intel_dp->active_mst_links); > > > > @@ -274,9 +273,9 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder, > > 1)) > > DRM_ERROR("Timed out waiting for ACT sent\n"); > > > > - ret = drm_dp_check_act_status(&intel_dp->mst_mgr); > > + drm_dp_check_act_status(&intel_dp->mst_mgr); > > > > - ret = drm_dp_update_payload_part2(&intel_dp->mst_mgr); > > + drm_dp_update_payload_part2(&intel_dp->mst_mgr); > > if (pipe_config->has_audio) > > intel_audio_codec_enable(encoder, pipe_config, conn_state); > > } > > -- > > 2.17.1 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Thu, Jul 19, 2018 at 05:56:33PM -0700, Nathan Ciobanu wrote: > On Thu, Jul 19, 2018 at 05:16:03PM -0700, Nathan Ciobanu wrote: > > On Thu, Jul 19, 2018 at 04:42:17PM -0700, Rodrigo Vivi wrote: > > > Just a small clean-up with no functional change, only > > > removing a variable that is never actually used. > > > > > > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> > > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > Nice one :) > > Reviewed-by: <nathan.d.ciobanu@linux.intel.com> > Reviewed-by: Nathan Ciobanu <nathan.d.ciobanu@linux.intel.com> Thanks, pushed. > > > --- > > > drivers/gpu/drm/i915/intel_dp_mst.c | 5 ++--- > > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c > > > index 7e3e01607643..18c65f8e4fe8 100644 > > > --- a/drivers/gpu/drm/i915/intel_dp_mst.c > > > +++ b/drivers/gpu/drm/i915/intel_dp_mst.c > > > @@ -263,7 +263,6 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder, > > > struct intel_dp *intel_dp = &intel_dig_port->dp; > > > struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); > > > enum port port = intel_dig_port->base.port; > > > - int ret; > > > > > > DRM_DEBUG_KMS("active links %d\n", intel_dp->active_mst_links); > > > > > > @@ -274,9 +273,9 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder, > > > 1)) > > > DRM_ERROR("Timed out waiting for ACT sent\n"); > > > > > > - ret = drm_dp_check_act_status(&intel_dp->mst_mgr); > > > + drm_dp_check_act_status(&intel_dp->mst_mgr); > > > > > > - ret = drm_dp_update_payload_part2(&intel_dp->mst_mgr); > > > + drm_dp_update_payload_part2(&intel_dp->mst_mgr); > > > if (pipe_config->has_audio) > > > intel_audio_codec_enable(encoder, pipe_config, conn_state); > > > } > > > -- > > > 2.17.1 > > > > > > _______________________________________________ > > > Intel-gfx mailing list > > > Intel-gfx@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c index 7e3e01607643..18c65f8e4fe8 100644 --- a/drivers/gpu/drm/i915/intel_dp_mst.c +++ b/drivers/gpu/drm/i915/intel_dp_mst.c @@ -263,7 +263,6 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder, struct intel_dp *intel_dp = &intel_dig_port->dp; struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); enum port port = intel_dig_port->base.port; - int ret; DRM_DEBUG_KMS("active links %d\n", intel_dp->active_mst_links); @@ -274,9 +273,9 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder, 1)) DRM_ERROR("Timed out waiting for ACT sent\n"); - ret = drm_dp_check_act_status(&intel_dp->mst_mgr); + drm_dp_check_act_status(&intel_dp->mst_mgr); - ret = drm_dp_update_payload_part2(&intel_dp->mst_mgr); + drm_dp_update_payload_part2(&intel_dp->mst_mgr); if (pipe_config->has_audio) intel_audio_codec_enable(encoder, pipe_config, conn_state); }
Just a small clean-up with no functional change, only removing a variable that is never actually used. Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> --- drivers/gpu/drm/i915/intel_dp_mst.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)