| Message ID | 1532051300-11884-1-git-send-email-bardliao@realtek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jul 24, 2018 at 01:49:48AM +0000, Bard Liao wrote: > Please ignore these patches. There is no significant advantage of > adding "Volume" to the control name. To prevent breaking the > configuration files on user space, we should find out all projects > which are using these controls and modify them. It will take time. > So I think it is better to leave it as it is. The RT5631 doesn't appear to have any users except Arndale, certainly no x86 users?
On Wed, Jul 25, 2018 at 02:01:21AM +0000, Bard Liao wrote: > > The RT5631 doesn't appear to have any users except Arndale, certainly no > > x86 users? > As far as I know, there is no x86 users using RT5631. OK, I think it's probably safe to apply that one then as I'm not seeing any in tree users except that Arndale expansion.
diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c index 985852f..fe970ed 100644 --- a/sound/soc/codecs/rt5651.c +++ b/sound/soc/codecs/rt5651.c @@ -332,11 +332,11 @@ static const struct snd_kcontrol_new rt5651_snd_controls[] = { RT5651_L_VOL_SFT, RT5651_R_VOL_SFT, 175, 0, dac_vol_tlv), /* IN1/IN2/IN3 Control */ - SOC_SINGLE_TLV("IN1 Boost", RT5651_IN1_IN2, + SOC_SINGLE_TLV("IN1 Boost Volume", RT5651_IN1_IN2, RT5651_BST_SFT1, 8, 0, bst_tlv), - SOC_SINGLE_TLV("IN2 Boost", RT5651_IN1_IN2, + SOC_SINGLE_TLV("IN2 Boost Volume", RT5651_IN1_IN2, RT5651_BST_SFT2, 8, 0, bst_tlv), - SOC_SINGLE_TLV("IN3 Boost", RT5651_IN3, + SOC_SINGLE_TLV("IN3 Boost Volume", RT5651_IN3, RT5651_BST_SFT1, 8, 0, bst_tlv), /* INL/INR Volume Control */ SOC_DOUBLE_TLV("IN Capture Volume", RT5651_INL1_INR1_VOL,
add Volume to the name of volume control Signed-off-by: Bard Liao <bardliao@realtek.com> --- sound/soc/codecs/rt5651.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)