| Message ID | 20180721111449.10103-1-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Wolfram, Thanks for your patch. On 2018-07-21 13:14:49 +0200, Wolfram Sang wrote: > This patch adds SDHI support for the R8A77990 SoC (R-Car E3). No driver changes > needed for anything except HS400 which we will enable separately later. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > > Note: we shouldn't enable HS400 in the DTS files yet, since we don't have the 8 > tap support. But I think we can enable basic support. > > Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt > index 839f469f4525..c434200d19d5 100644 > --- a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt > +++ b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt > @@ -28,6 +28,7 @@ Required properties: > "renesas,sdhi-r8a7796" - SDHI IP on R8A7796 SoC > "renesas,sdhi-r8a77965" - SDHI IP on R8A77965 SoC > "renesas,sdhi-r8a77980" - SDHI IP on R8A77980 SoC > + "renesas,sdhi-r8a77990" - SDHI IP on R8A77990 SoC > "renesas,sdhi-r8a77995" - SDHI IP on R8A77995 SoC > "renesas,sdhi-shmobile" - a generic sh-mobile SDHI controller > "renesas,rcar-gen1-sdhi" - a generic R-Car Gen1 SDHI controller > -- > 2.11.0 >
On Sat, Jul 21, 2018 at 01:14:49PM +0200, Wolfram Sang wrote: > This patch adds SDHI support for the R8A77990 SoC (R-Car E3). No driver changes > needed for anything except HS400 which we will enable separately later. No driver update should be required for HS400, see below. > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > > Note: we shouldn't enable HS400 in the DTS files yet, since we don't have the 8 > tap support. But I think we can enable basic support. 8 tap support is included in the following patch which was accepted for inclusion in upstream (search for 4TAP): 26eb2607fa28 ("mmc: renesas_sdhi: add eMMC HS400 mode support") > Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt > index 839f469f4525..c434200d19d5 100644 > --- a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt > +++ b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt > @@ -28,6 +28,7 @@ Required properties: > "renesas,sdhi-r8a7796" - SDHI IP on R8A7796 SoC > "renesas,sdhi-r8a77965" - SDHI IP on R8A77965 SoC > "renesas,sdhi-r8a77980" - SDHI IP on R8A77980 SoC > + "renesas,sdhi-r8a77990" - SDHI IP on R8A77990 SoC > "renesas,sdhi-r8a77995" - SDHI IP on R8A77995 SoC > "renesas,sdhi-shmobile" - a generic sh-mobile SDHI controller > "renesas,rcar-gen1-sdhi" - a generic R-Car Gen1 SDHI controller > -- > 2.11.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Wolfram, On Sat, Jul 21, 2018 at 1:14 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > This patch adds SDHI support for the R8A77990 SoC (R-Car E3). No driver changes > needed for anything except HS400 which we will enable separately later. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> This matches Table 70.1 ("Pin Configuration") of Section 70 ("SD Card/MMC Interfaces"), so Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> However, the figures at the top of Sections 70 and 70.2 indicate SDHI is not available on R-Car E3 (and H3, M3-W, and M3-N)?!? Gr{oetje,eeting}s, Geert
> However, the figures at the top of Sections 70 and 70.2 indicate SDHI is not > available on R-Car E3 (and H3, M3-W, and M3-N)?!? When you look at other chapters, "not available" is usually printed in light gray. I am not sure what these different kinds of styles mean in chapter 70, yet I know that SDHI on D3 is a little different (no HS400). Perhaps it is an indication of that? I can't really tell because I don't know much about SDHI von V3x.
> 8 tap support is included in the following patch which was accepted > for inclusion in upstream (search for 4TAP): > > 26eb2607fa28 ("mmc: renesas_sdhi: add eMMC HS400 mode support") Wow, sorry, I missed that :( I thought there were only 8 TAP preparations in there. Cool, will have a look...
On 21 July 2018 at 13:14, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > This patch adds SDHI support for the R8A77990 SoC (R-Car E3). No driver changes > needed for anything except HS400 which we will enable separately later. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Thanks, applied for next! Kind regards Uffe > --- > > Note: we shouldn't enable HS400 in the DTS files yet, since we don't have the 8 > tap support. But I think we can enable basic support. > > Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt > index 839f469f4525..c434200d19d5 100644 > --- a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt > +++ b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt > @@ -28,6 +28,7 @@ Required properties: > "renesas,sdhi-r8a7796" - SDHI IP on R8A7796 SoC > "renesas,sdhi-r8a77965" - SDHI IP on R8A77965 SoC > "renesas,sdhi-r8a77980" - SDHI IP on R8A77980 SoC > + "renesas,sdhi-r8a77990" - SDHI IP on R8A77990 SoC > "renesas,sdhi-r8a77995" - SDHI IP on R8A77995 SoC > "renesas,sdhi-shmobile" - a generic sh-mobile SDHI controller > "renesas,rcar-gen1-sdhi" - a generic R-Car Gen1 SDHI controller > -- > 2.11.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt index 839f469f4525..c434200d19d5 100644 --- a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt +++ b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt @@ -28,6 +28,7 @@ Required properties: "renesas,sdhi-r8a7796" - SDHI IP on R8A7796 SoC "renesas,sdhi-r8a77965" - SDHI IP on R8A77965 SoC "renesas,sdhi-r8a77980" - SDHI IP on R8A77980 SoC + "renesas,sdhi-r8a77990" - SDHI IP on R8A77990 SoC "renesas,sdhi-r8a77995" - SDHI IP on R8A77995 SoC "renesas,sdhi-shmobile" - a generic sh-mobile SDHI controller "renesas,rcar-gen1-sdhi" - a generic R-Car Gen1 SDHI controller
This patch adds SDHI support for the R8A77990 SoC (R-Car E3). No driver changes needed for anything except HS400 which we will enable separately later. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Note: we shouldn't enable HS400 in the DTS files yet, since we don't have the 8 tap support. But I think we can enable basic support. Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 1 + 1 file changed, 1 insertion(+)