From patchwork Sat Jul 21 19:09:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10539087 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 036DDA6EC for ; Sun, 22 Jul 2018 00:57:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D8CF3288EA for ; Sat, 21 Jul 2018 19:10:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CD39028901; Sat, 21 Jul 2018 19:10:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A9C24288EA for ; Sat, 21 Jul 2018 19:10:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728274AbeGUUEY (ORCPT ); Sat, 21 Jul 2018 16:04:24 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:41389 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbeGUUEY (ORCPT ); Sat, 21 Jul 2018 16:04:24 -0400 Received: by mail-wr1-f65.google.com with SMTP id j5-v6so14117685wrr.8; Sat, 21 Jul 2018 12:10:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vyjd9FGJMy0+TxbD7vXkSRtycDBsk85CQ0K4UBHKE3I=; b=b13ghsMwCn49x6zIuqIF7fwHWATRXhwNTG76khSpodNpCrKknq7olHeXdYg8tY6Jeb 7Vs3Bjq5lNJxMiMkbliAh/O0fr+pulHiFAAXaN+BUPPjao28Rpst5UuRxtKiU+A1/WtC CUafuylOV66+XqSfUauqB0N6JR4X33RbyzLIus0lR0h8sVbHsygGORmQKIO3gg5JePqf 08SvhpLAQE1o2BO7SJowvd8+nr7TuPxtH7kOkfaQAFBosLg2uFQ8IU1B8TclXQJcAdBK CJNu8/u8zZVfUXz/jNsOwfX6QWWsjhUJD0377Etd0i2iyU6t6/n/kyaZesAnuaVQmXDL VJPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vyjd9FGJMy0+TxbD7vXkSRtycDBsk85CQ0K4UBHKE3I=; b=WO5AsFpxS6PfEFFw9jclQ/FGWDngIcyW9MiwQyJgZRIsmRiKDsnrOY6DoFldL4IO4t SBAZQBGBvBENXnAiGGG7Stfy1w2jYmfaI0Dt0337RpV3sqS4LQlyDcKNl180Df6h6GF6 8cFXeen/adO3v+wcdIhW4kwaa5pR894GZlB54H9Yi61X0d7QhvFOuEseKUZnWNj/I+vq PW4UwmJkXQZIPtkL6vVYwFOauhrgTEDF7qWoIHQ517O3LVDU31eaiaLdbAGojP8I+/9R sR/CrjKoQuytkym1IKhgV8/u0ti44oCLo0MDRW4gndY0Y8eDaRUgH2zmv0E6qJiiHp1N F9pQ== X-Gm-Message-State: AOUpUlHpqVLv9SUr6zSUWCnQ8v7Mq5tM4fehv5OnyxnA1s0hXD9ZL+Qs H80+MZWxU8+Q4OvSJF6/+bg= X-Google-Smtp-Source: AAOMgpcYljecTMm9MRpmiuhdCgDAqKG7T6aCGjGkXUIQ04qhobkNHhmdu5Sj3mVKcNePm2vkL+kiuw== X-Received: by 2002:adf:b519:: with SMTP id a25-v6mr4775766wrd.273.1532200236390; Sat, 21 Jul 2018 12:10:36 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id x19-v6sm4241933wrd.32.2018.07.21.12.10.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Jul 2018 12:10:35 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Nick Dyer , Dmitry Torokhov , Simon Budig , Andi Shyti , Luca Ceresoli , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/11] touchscreen: amtel: Use octal permissions Date: Sun, 22 Jul 2018 00:39:44 +0530 Message-Id: <20180721191029.25658-3-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180721191029.25658-1-harshitjain6751@gmail.com> References: <20180721191029.25658-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(fw_version, S_IRUGO, mxt_fw_version_show, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(hw_version, S_IRUGO, mxt_hw_version_show, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(object, S_IRUGO, mxt_object_show, NULL); WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. +static DEVICE_ATTR(update_fw, S_IWUSR, NULL, mxt_update_fw_store); Signed-off-by: dev-harsh1998 --- drivers/input/touchscreen/atmel_mxt_ts.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index 54fe190fd4bc..5202a8244f1d 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -2892,10 +2892,10 @@ static ssize_t mxt_update_fw_store(struct device *dev, return count; } -static DEVICE_ATTR(fw_version, S_IRUGO, mxt_fw_version_show, NULL); -static DEVICE_ATTR(hw_version, S_IRUGO, mxt_hw_version_show, NULL); -static DEVICE_ATTR(object, S_IRUGO, mxt_object_show, NULL); -static DEVICE_ATTR(update_fw, S_IWUSR, NULL, mxt_update_fw_store); +static DEVICE_ATTR(fw_version, 0444, mxt_fw_version_show, NULL); +static DEVICE_ATTR(hw_version, 0444, mxt_hw_version_show, NULL); +static DEVICE_ATTR(object, 0444, mxt_object_show, NULL); +static DEVICE_ATTR(update_fw, 0200, NULL, mxt_update_fw_store); static struct attribute *mxt_attrs[] = { &dev_attr_fw_version.attr,