From patchwork Fri Jul 27 14:44:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 10547273 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 511C9112B for ; Fri, 27 Jul 2018 14:44:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 40C032852D for ; Fri, 27 Jul 2018 14:44:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 34D1E2BDF1; Fri, 27 Jul 2018 14:44:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CBE422852D for ; Fri, 27 Jul 2018 14:44:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730953AbeG0QGZ (ORCPT ); Fri, 27 Jul 2018 12:06:25 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:36804 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730395AbeG0QGZ (ORCPT ); Fri, 27 Jul 2018 12:06:25 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A4B7F40241C8 for ; Fri, 27 Jul 2018 14:44:10 +0000 (UTC) Received: from thuth.com (reserved-198-198.str.redhat.com [10.33.198.198]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6A9BC2156897; Fri, 27 Jul 2018 14:44:09 +0000 (UTC) From: Thomas Huth To: kvm@vger.kernel.org, Paolo Bonzini , =?utf-8?b?UmFk?= =?utf-8?b?aW0gS3LEjW3DocWZ?= Cc: Drew Jones , Laurent Vivier , David Hildenbrand , Laszlo Ersek Subject: [kvm-unit-tests PATCH v2] Makefiles: Remove the executable bit from the .elf and .flat files Date: Fri, 27 Jul 2018 16:44:05 +0200 Message-Id: <1532702645-30780-1-git-send-email-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Fri, 27 Jul 2018 14:44:10 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Fri, 27 Jul 2018 14:44:10 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'thuth@redhat.com' RCPT:'' Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The .elf and .flat files are not runnable on the host operating system, so they should not be marked as executable. Signed-off-by: Thomas Huth Reviewed-by: David Hildenbrand Acked-by: Laszlo Ersek Reviewed-by: Andrew Jones --- v2: - Removed "rpm coloring" sentence from the patch description - Use "@" in front of the chmods arm/Makefile.common | 2 ++ powerpc/Makefile.common | 2 ++ s390x/Makefile | 1 + x86/Makefile.common | 2 ++ 4 files changed, 7 insertions(+) diff --git a/arm/Makefile.common b/arm/Makefile.common index 1cf9cdc..42da24c 100644 --- a/arm/Makefile.common +++ b/arm/Makefile.common @@ -73,9 +73,11 @@ FLATLIBS = $(libcflat) $(LIBFDT_archive) $(libgcc) $(libeabi) -Wl,-T,$(SRCDIR)/arm/flat.lds,--build-id=none,-Ttext=$(start_addr) \ $(filter %.o, $^) $(FLATLIBS) \ $(SRCDIR)/lib/auxinfo.c -DPROGNAME=\"$(@:.elf=.flat)\" -DAUXFLAGS=$(AUXFLAGS) + @chmod a-x $@ %.flat: %.elf $(OBJCOPY) -O binary $^ $@ + @chmod a-x $@ $(libeabi): $(eabiobjs) $(AR) rcs $@ $^ diff --git a/powerpc/Makefile.common b/powerpc/Makefile.common index 81c5074..ac3cab6 100644 --- a/powerpc/Makefile.common +++ b/powerpc/Makefile.common @@ -54,6 +54,7 @@ FLATLIBS = $(libcflat) $(LIBFDT_archive) -T $(SRCDIR)/powerpc/flat.lds --build-id=none \ $(filter %.o, $^) $(FLATLIBS) $(@:.elf=.aux.o) $(RM) $(@:.elf=.aux.o) + @chmod a-x $@ @echo -n Checking $@ for unsupported reloc types... @if $(OBJDUMP) -R $@ | grep R_ | grep -v R_PPC64_RELATIVE; then \ false; \ @@ -70,6 +71,7 @@ $(TEST_DIR)/boot_rom.bin: $(TEST_DIR)/boot_rom.elf $(TEST_DIR)/boot_rom.elf: CFLAGS = -mbig-endian $(TEST_DIR)/boot_rom.elf: $(TEST_DIR)/boot_rom.o $(LD) -EB -nostdlib -Ttext=0x100 --entry=start --build-id=none -o $@ $< + @chmod a-x $@ powerpc_clean: libfdt_clean asm_offsets_clean $(RM) $(TEST_DIR)/*.{o,elf} $(TEST_DIR)/boot_rom.bin \ diff --git a/s390x/Makefile b/s390x/Makefile index 6546a02..8ba2b92 100644 --- a/s390x/Makefile +++ b/s390x/Makefile @@ -53,6 +53,7 @@ FLATLIBS = $(libcflat) $(CC) $(LDFLAGS) -o $@ -T $(SRCDIR)/s390x/flat.lds -Ttext=0x10000 \ $(filter %.o, $^) $(FLATLIBS) $(@:.elf=.aux.o) $(RM) $(@:.elf=.aux.o) + @chmod a-x $@ arch_clean: asm_offsets_clean $(RM) $(TEST_DIR)/*.{o,elf} $(TEST_DIR)/.*.d lib/s390x/.*.d diff --git a/x86/Makefile.common b/x86/Makefile.common index 7dcf8c2..e612dbe 100644 --- a/x86/Makefile.common +++ b/x86/Makefile.common @@ -42,9 +42,11 @@ FLATLIBS = lib/libcflat.a $(libgcc) %.elf: %.o $(FLATLIBS) $(SRCDIR)/x86/flat.lds $(cstart.o) $(CC) $(CFLAGS) -nostdlib -o $@ -Wl,-T,$(SRCDIR)/x86/flat.lds \ $(filter %.o, $^) $(FLATLIBS) + @chmod a-x $@ %.flat: %.elf $(OBJCOPY) -O elf32-i386 $^ $@ + @chmod a-x $@ tests-common = $(TEST_DIR)/vmexit.flat $(TEST_DIR)/tsc.flat \ $(TEST_DIR)/smptest.flat $(TEST_DIR)/port80.flat \