diff mbox series

[v2] scripts: Add Python 3 support to tracing/draw_functrace.py

Message ID 20180728144833.6336-1-jcline@redhat.com (mailing list archive)
State New, archived
Headers show
Series [v2] scripts: Add Python 3 support to tracing/draw_functrace.py | expand

Commit Message

Jeremy Cline July 28, 2018, 2:48 p.m. UTC
Use the print function. This maintains Python 2 support and should have
no functional change.

Signed-off-by: Jeremy Cline <jcline@redhat.com>
---

Changes from v1:
  - Drop "from __future__ import print_function" as Python 2 is not long
    for this world and in this case the statement and function behave
    the same way.

 scripts/tracing/draw_functrace.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Masahiro Yamada July 29, 2018, 2:11 a.m. UTC | #1
2018-07-28 23:48 GMT+09:00 Jeremy Cline <jcline@redhat.com>:
> Use the print function. This maintains Python 2 support and should have
> no functional change.
>
> Signed-off-by: Jeremy Cline <jcline@redhat.com>
> ---

Applied to linux-kbuild. Thanks!


> Changes from v1:
>   - Drop "from __future__ import print_function" as Python 2 is not long
>     for this world and in this case the statement and function behave
>     the same way.
>
>  scripts/tracing/draw_functrace.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/tracing/draw_functrace.py b/scripts/tracing/draw_functrace.py
> index db40fa04cd51..9b6dd4f36335 100755
> --- a/scripts/tracing/draw_functrace.py
> +++ b/scripts/tracing/draw_functrace.py
> @@ -123,7 +123,7 @@ def main():
>                 tree = tree.getParent(caller)
>                 tree = tree.calls(callee, calltime)
>
> -       print CallTree.ROOT
> +       print(CallTree.ROOT)
>
>  if __name__ == "__main__":
>         main()
> --
> 2.17.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox series

Patch

diff --git a/scripts/tracing/draw_functrace.py b/scripts/tracing/draw_functrace.py
index db40fa04cd51..9b6dd4f36335 100755
--- a/scripts/tracing/draw_functrace.py
+++ b/scripts/tracing/draw_functrace.py
@@ -123,7 +123,7 @@  def main():
 		tree = tree.getParent(caller)
 		tree = tree.calls(callee, calltime)
 
-	print CallTree.ROOT
+	print(CallTree.ROOT)
 
 if __name__ == "__main__":
 	main()