| Message ID | 20180730123137.923-6-andre.przywara@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: allwinner: A64 boards DT updates | expand |
On Mon, Jul 30, 2018 at 8:31 PM, Andre Przywara <andre.przywara@arm.com> wrote: > From: Samuel Holland <samuel@sholland.org> > > The Orange Pi Win has a micro USB-B socket, connected to the SoC's > USB-OTG port. Its power is supplied by the AXP PMIC, and the ID pin is > connected to GPIO PH9. It can serve both as a host or a client port. > > Add the respective DT node to enable it. This patch is missing vbus detection and vbus-supply for usb0. The former uses the PMIC's own VBUS detection. The latter, according to the schematics, is a separate fixed regulator controlled by the PMIC's N_VBUSEN pin, so it would correspond to the PMIC's drive_vbus regulator node. Also the commit description is wrong. ChenYu > Signed-off-by: Samuel Holland <samuel@sholland.org> > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts > index a73489850d88..c9cabe987c19 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts > @@ -214,8 +214,13 @@ > status = "okay"; > }; > > +&usb_otg { > + dr_mode = "otg"; > + status = "okay"; > +}; > + > &usbphy { > + usb0_id_det-gpios = <&pio 7 9 GPIO_ACTIVE_HIGH>; /* PH9 */ > usb1_vbus-supply = <®_usb1_vbus>; > status = "okay"; > }; > - > -- > 2.14.4 >
On Tue, Aug 7, 2018 at 1:04 PM, Chen-Yu Tsai <wens@csie.org> wrote: > On Mon, Jul 30, 2018 at 8:31 PM, Andre Przywara <andre.przywara@arm.com> wrote: >> From: Samuel Holland <samuel@sholland.org> >> >> The Orange Pi Win has a micro USB-B socket, connected to the SoC's >> USB-OTG port. Its power is supplied by the AXP PMIC, and the ID pin is >> connected to GPIO PH9. It can serve both as a host or a client port. >> >> Add the respective DT node to enable it. > > This patch is missing vbus detection and vbus-supply for usb0. > > The former uses the PMIC's own VBUS detection. > > The latter, according to the schematics, is a separate fixed regulator > controlled by the PMIC's N_VBUSEN pin, so it would correspond to the > PMIC's drive_vbus regulator node. Also the commit description is wrong. Applied with ehci0 and ohci0 also enabled, since the A64 has a dual routed USB0. Also added vbus-supply supply. The patch (and others) will appear in https://git.kernel.org/pub/scm/linux/kernel/git/wens/linux.git/log/?h=sunxi/dt64-for-4.20 once the mirror completely syncs up. I'm not using the sunxi repo to ease rebasing when the next -rc1 comes out. I.e. I will queue up patches in a separate place so Maxime can rebase the ones he queued up without having to fix up committer info on the ones I did. ChenYu
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts index a73489850d88..c9cabe987c19 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts @@ -214,8 +214,13 @@ status = "okay"; }; +&usb_otg { + dr_mode = "otg"; + status = "okay"; +}; + &usbphy { + usb0_id_det-gpios = <&pio 7 9 GPIO_ACTIVE_HIGH>; /* PH9 */ usb1_vbus-supply = <®_usb1_vbus>; status = "okay"; }; -