ALSA: pcm: Mark expected switch fall-through
diff mbox series

Message ID 20180801155825.GA4876@embeddedor.com
State New
Headers show
Series
  • ALSA: pcm: Mark expected switch fall-through
Related show

Commit Message

Gustavo A. R. Silva Aug. 1, 2018, 3:58 p.m. UTC
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 1357375 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 sound/core/oss/pcm_plugin.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Takashi Iwai Aug. 1, 2018, 4:13 p.m. UTC | #1
On Wed, 01 Aug 2018 17:58:25 +0200,
 Gustavo A. R. Silva  wrote:
> 
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Addresses-Coverity-ID: 1357375 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Applied, thanks.


Takashi

Patch
diff mbox series

diff --git a/sound/core/oss/pcm_plugin.c b/sound/core/oss/pcm_plugin.c
index 85bab92..0391cb1a 100644
--- a/sound/core/oss/pcm_plugin.c
+++ b/sound/core/oss/pcm_plugin.c
@@ -353,6 +353,7 @@  snd_pcm_format_t snd_pcm_plug_slave_format(snd_pcm_format_t format,
 				if (snd_mask_test(format_mask, (__force int)format1))
 					return format1;
 			}
+			/* fall through */
 		default:
 			return (__force snd_pcm_format_t)-EINVAL;
 		}