ALSA: usb: Mark expected switch fall-through
diff mbox series

Message ID 20180801161416.GA8820@embeddedor.com
State New
Headers show
Series
  • ALSA: usb: Mark expected switch fall-through
Related show

Commit Message

Gustavo A. R. Silva Aug. 1, 2018, 4:14 p.m. UTC
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 115084 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 sound/usb/pcm.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Takashi Iwai Aug. 1, 2018, 6:32 p.m. UTC | #1
On Wed, 01 Aug 2018 18:14:16 +0200,
 Gustavo A. R. Silva  wrote:
> 
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Addresses-Coverity-ID: 115084 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Applied, thanks.


Takashi

Patch
diff mbox series

diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
index bbc7116..3828471 100644
--- a/sound/usb/pcm.c
+++ b/sound/usb/pcm.c
@@ -1694,6 +1694,7 @@  static int snd_usb_substream_playback_trigger(struct snd_pcm_substream *substrea
 	switch (cmd) {
 	case SNDRV_PCM_TRIGGER_START:
 		subs->trigger_tstamp_pending_update = true;
+		/* fall through */
 	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
 		subs->data_endpoint->prepare_data_urb = prepare_playback_urb;
 		subs->data_endpoint->retire_data_urb = retire_playback_urb;