| Message ID | 20180801202821.GB4033@amd (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fix vibrations on Droid 4 | expand |
Hi, On Wed, Aug 01, 2018 at 10:28:21PM +0200, Pavel Machek wrote: > Vibration GPIOs don't have anything to do with wakeup. Move it to > normal section; this fixes vibrations on Droid 4. > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > diff --git a/arch/arm/boot/dts/omap4-droid4-xt894.dts b/arch/arm/boot/dts/omap4-droid4-xt894.dts > index c27fc87..7b82179 100644 Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> -- Sebastian > --- a/arch/arm/boot/dts/omap4-droid4-xt894.dts > +++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts > @@ -646,15 +646,6 @@ > OMAP4_IOPAD(0x10c, PIN_INPUT | MUX_MODE1) /* abe_mcbsp3_fsx */ > >; > }; > -}; > - > -&omap4_pmx_wkup { > - usb_gpio_mux_sel2: pinmux_usb_gpio_mux_sel2_pins { > - /* gpio_wk0 */ > - pinctrl-single,pins = < > - OMAP4_IOPAD(0x040, PIN_OUTPUT_PULLDOWN | MUX_MODE3) > - >; > - }; > > vibrator_direction_pin: pinmux_vibrator_direction_pin { > pinctrl-single,pins = < > @@ -669,6 +660,15 @@ > }; > }; > > +&omap4_pmx_wkup { > + usb_gpio_mux_sel2: pinmux_usb_gpio_mux_sel2_pins { > + /* gpio_wk0 */ > + pinctrl-single,pins = < > + OMAP4_IOPAD(0x040, PIN_OUTPUT_PULLDOWN | MUX_MODE3) > + >; > + }; > +}; > + > /* > * As uart1 is wired to mdm6600 with rts and cts, we can use the cts pin for > * uart1 wakeirq. > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
* Sebastian Reichel <sre@kernel.org> [180802 10:59]: > Hi, > > On Wed, Aug 01, 2018 at 10:28:21PM +0200, Pavel Machek wrote: > > Vibration GPIOs don't have anything to do with wakeup. Move it to > > normal section; this fixes vibrations on Droid 4. > > > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > > > diff --git a/arch/arm/boot/dts/omap4-droid4-xt894.dts b/arch/arm/boot/dts/omap4-droid4-xt894.dts > > index c27fc87..7b82179 100644 > > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> Thanks applying into omap-for-v4.19/fixes. Tony
diff --git a/arch/arm/boot/dts/omap4-droid4-xt894.dts b/arch/arm/boot/dts/omap4-droid4-xt894.dts index c27fc87..7b82179 100644 --- a/arch/arm/boot/dts/omap4-droid4-xt894.dts +++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts @@ -646,15 +646,6 @@ OMAP4_IOPAD(0x10c, PIN_INPUT | MUX_MODE1) /* abe_mcbsp3_fsx */ >; }; -}; - -&omap4_pmx_wkup { - usb_gpio_mux_sel2: pinmux_usb_gpio_mux_sel2_pins { - /* gpio_wk0 */ - pinctrl-single,pins = < - OMAP4_IOPAD(0x040, PIN_OUTPUT_PULLDOWN | MUX_MODE3) - >; - }; vibrator_direction_pin: pinmux_vibrator_direction_pin { pinctrl-single,pins = < @@ -669,6 +660,15 @@ }; }; +&omap4_pmx_wkup { + usb_gpio_mux_sel2: pinmux_usb_gpio_mux_sel2_pins { + /* gpio_wk0 */ + pinctrl-single,pins = < + OMAP4_IOPAD(0x040, PIN_OUTPUT_PULLDOWN | MUX_MODE3) + >; + }; +}; + /* * As uart1 is wired to mdm6600 with rts and cts, we can use the cts pin for * uart1 wakeirq.
Vibration GPIOs don't have anything to do with wakeup. Move it to normal section; this fixes vibrations on Droid 4. Signed-off-by: Pavel Machek <pavel@ucw.cz>