Kbuild: Makefile.modbuiltin: include auto.conf and tristate.conf mandatory
diff mbox series

Message ID 20180802134708.26456-1-dirk@gouders.net
State New
Headers show
Series
  • Kbuild: Makefile.modbuiltin: include auto.conf and tristate.conf mandatory
Related show

Commit Message

Dirk Gouders Aug. 2, 2018, 1:47 p.m. UTC
The files auto.conf and tristate.conf are mandatory for building
modules.builtin files, therefore include them as such.

Usually, the top-level Makefile ensures that those files exist but we
want to make sure we get noticed if they are missing for whatever
reason.

Signed-off-by: Dirk Gouders <dirk@gouders.net>
---
 scripts/Makefile.modbuiltin | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Masahiro Yamada Aug. 2, 2018, 3:48 p.m. UTC | #1
2018-08-02 22:47 GMT+09:00 Dirk Gouders <dirk@gouders.net>:
> The files auto.conf and tristate.conf are mandatory for building
> modules.builtin files, therefore include them as such.
>
> Usually, the top-level Makefile ensures that those files exist but we
> want to make sure we get noticed if they are missing for whatever
> reason.
>
> Signed-off-by: Dirk Gouders <dirk@gouders.net>
> ---

Applied. Thanks!

>  scripts/Makefile.modbuiltin | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/Makefile.modbuiltin b/scripts/Makefile.modbuiltin
> index 40867a41615b..a072a4267746 100644
> --- a/scripts/Makefile.modbuiltin
> +++ b/scripts/Makefile.modbuiltin
> @@ -8,10 +8,10 @@ src := $(obj)
>  PHONY := __modbuiltin
>  __modbuiltin:
>
> --include include/config/auto.conf
> +include include/config/auto.conf
>  # tristate.conf sets tristate variables to uppercase 'Y' or 'M'
>  # That way, we get the list of built-in modules in obj-Y
> --include include/config/tristate.conf
> +include include/config/tristate.conf
>
>  include scripts/Kbuild.include
>
> --
> 2.16.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox series

diff --git a/scripts/Makefile.modbuiltin b/scripts/Makefile.modbuiltin
index 40867a41615b..a072a4267746 100644
--- a/scripts/Makefile.modbuiltin
+++ b/scripts/Makefile.modbuiltin
@@ -8,10 +8,10 @@  src := $(obj)
 PHONY := __modbuiltin
 __modbuiltin:
 
--include include/config/auto.conf
+include include/config/auto.conf
 # tristate.conf sets tristate variables to uppercase 'Y' or 'M'
 # That way, we get the list of built-in modules in obj-Y
--include include/config/tristate.conf
+include include/config/tristate.conf
 
 include scripts/Kbuild.include