diff mbox series

[v3,6/9] dt-bindings: iio: tsl2772: add bindings for regulator framework

Message ID 20180803001900.25371-7-masneyb@onstation.org (mailing list archive)
State New, archived
Headers show
Series treewide: add support for various sensors on the LG Nexus 5 (hammerhead) | expand

Commit Message

Brian Masney Aug. 3, 2018, 12:18 a.m. UTC
This patch adds device tree bindings to the tsl2772 driver for the
regulator framework.

Signed-off-by: Brian Masney <masneyb@onstation.org>
---
 Documentation/devicetree/bindings/iio/light/tsl2772.txt | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Jonathan Cameron Aug. 3, 2018, 9:51 p.m. UTC | #1
On Thu,  2 Aug 2018 20:18:57 -0400
Brian Masney <masneyb@onstation.org> wrote:

> This patch adds device tree bindings to the tsl2772 driver for the
> regulator framework.
> 
> Signed-off-by: Brian Masney <masneyb@onstation.org>
I suspect Rob will tell you this should really have been in the same
patch as the earlier bindings.   There is no need for us to wait
for the driver support as the binding describes what is there, not
what we do with it.

Otherwise it's fine and if nothing else comes up I can merge them ;)

Jonathan

> ---
>  Documentation/devicetree/bindings/iio/light/tsl2772.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/tsl2772.txt b/Documentation/devicetree/bindings/iio/light/tsl2772.txt
> index 6f33169344f2..4e7d98627cbf 100644
> --- a/Documentation/devicetree/bindings/iio/light/tsl2772.txt
> +++ b/Documentation/devicetree/bindings/iio/light/tsl2772.txt
> @@ -21,6 +21,8 @@ Optional properties:
>                                 are the only valid values.
>    - led-max-microamp - current for the proximity LED. Must be 100000, 50000,
>                         25000, or 13000.
> +  - vdd-supply: phandle to the regulator that provides power to the sensor.
> +  - vddio-supply: phandle to the regulator that provides power to the bus.
>    - interrupts: the sole interrupt generated by the device
>  
>    Refer to interrupt-controller/interrupts.txt for generic interrupt client
> @@ -32,6 +34,8 @@ tsl2772@39 {
>  	compatible = "amstaos,tsl2772";
>  	reg = <0x39>;
>  	interrupts-extended = <&msmgpio 61 IRQ_TYPE_EDGE_FALLING>;
> +	vdd-supply = <&pm8941_l17>;
> +	vddio-supply = <&pm8941_lvs1>;
>  	amstaos,proximity-diodes = <0>;
>  	led-max-microamp = <100000>;
>  };

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring Aug. 7, 2018, 5:20 p.m. UTC | #2
On Fri, Aug 03, 2018 at 10:51:23PM +0100, Jonathan Cameron wrote:
> On Thu,  2 Aug 2018 20:18:57 -0400
> Brian Masney <masneyb@onstation.org> wrote:
> 
> > This patch adds device tree bindings to the tsl2772 driver for the
> > regulator framework.
> > 
> > Signed-off-by: Brian Masney <masneyb@onstation.org>
> I suspect Rob will tell you this should really have been in the same
> patch as the earlier bindings.   There is no need for us to wait
> for the driver support as the binding describes what is there, not
> what we do with it.

Yep.

> 
> Otherwise it's fine and if nothing else comes up I can merge them ;)
> 
> Jonathan
> 
> > ---
> >  Documentation/devicetree/bindings/iio/light/tsl2772.txt | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/light/tsl2772.txt b/Documentation/devicetree/bindings/iio/light/tsl2772.txt
> > index 6f33169344f2..4e7d98627cbf 100644
> > --- a/Documentation/devicetree/bindings/iio/light/tsl2772.txt
> > +++ b/Documentation/devicetree/bindings/iio/light/tsl2772.txt
> > @@ -21,6 +21,8 @@ Optional properties:
> >                                 are the only valid values.
> >    - led-max-microamp - current for the proximity LED. Must be 100000, 50000,
> >                         25000, or 13000.
> > +  - vdd-supply: phandle to the regulator that provides power to the sensor.
> > +  - vddio-supply: phandle to the regulator that provides power to the bus.
> >    - interrupts: the sole interrupt generated by the device
> >  
> >    Refer to interrupt-controller/interrupts.txt for generic interrupt client
> > @@ -32,6 +34,8 @@ tsl2772@39 {
> >  	compatible = "amstaos,tsl2772";
> >  	reg = <0x39>;
> >  	interrupts-extended = <&msmgpio 61 IRQ_TYPE_EDGE_FALLING>;
> > +	vdd-supply = <&pm8941_l17>;
> > +	vddio-supply = <&pm8941_lvs1>;
> >  	amstaos,proximity-diodes = <0>;
> >  	led-max-microamp = <100000>;
> >  };
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jonathan Cameron Aug. 18, 2018, 5:02 p.m. UTC | #3
On Tue, 7 Aug 2018 11:20:28 -0600
Rob Herring <robh@kernel.org> wrote:

> On Fri, Aug 03, 2018 at 10:51:23PM +0100, Jonathan Cameron wrote:
> > On Thu,  2 Aug 2018 20:18:57 -0400
> > Brian Masney <masneyb@onstation.org> wrote:
> >   
> > > This patch adds device tree bindings to the tsl2772 driver for the
> > > regulator framework.
> > > 
> > > Signed-off-by: Brian Masney <masneyb@onstation.org>  
> > I suspect Rob will tell you this should really have been in the same
> > patch as the earlier bindings.   There is no need for us to wait
> > for the driver support as the binding describes what is there, not
> > what we do with it.  
> 
> Yep.
> 
> > 
> > Otherwise it's fine and if nothing else comes up I can merge them ;)

I merged them.

Jonathan
> > 
> > Jonathan
> >   
> > > ---
> > >  Documentation/devicetree/bindings/iio/light/tsl2772.txt | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/iio/light/tsl2772.txt b/Documentation/devicetree/bindings/iio/light/tsl2772.txt
> > > index 6f33169344f2..4e7d98627cbf 100644
> > > --- a/Documentation/devicetree/bindings/iio/light/tsl2772.txt
> > > +++ b/Documentation/devicetree/bindings/iio/light/tsl2772.txt
> > > @@ -21,6 +21,8 @@ Optional properties:
> > >                                 are the only valid values.
> > >    - led-max-microamp - current for the proximity LED. Must be 100000, 50000,
> > >                         25000, or 13000.
> > > +  - vdd-supply: phandle to the regulator that provides power to the sensor.
> > > +  - vddio-supply: phandle to the regulator that provides power to the bus.
> > >    - interrupts: the sole interrupt generated by the device
> > >  
> > >    Refer to interrupt-controller/interrupts.txt for generic interrupt client
> > > @@ -32,6 +34,8 @@ tsl2772@39 {
> > >  	compatible = "amstaos,tsl2772";
> > >  	reg = <0x39>;
> > >  	interrupts-extended = <&msmgpio 61 IRQ_TYPE_EDGE_FALLING>;
> > > +	vdd-supply = <&pm8941_l17>;
> > > +	vddio-supply = <&pm8941_lvs1>;
> > >  	amstaos,proximity-diodes = <0>;
> > >  	led-max-microamp = <100000>;
> > >  };  
> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/light/tsl2772.txt b/Documentation/devicetree/bindings/iio/light/tsl2772.txt
index 6f33169344f2..4e7d98627cbf 100644
--- a/Documentation/devicetree/bindings/iio/light/tsl2772.txt
+++ b/Documentation/devicetree/bindings/iio/light/tsl2772.txt
@@ -21,6 +21,8 @@  Optional properties:
                                are the only valid values.
   - led-max-microamp - current for the proximity LED. Must be 100000, 50000,
                        25000, or 13000.
+  - vdd-supply: phandle to the regulator that provides power to the sensor.
+  - vddio-supply: phandle to the regulator that provides power to the bus.
   - interrupts: the sole interrupt generated by the device
 
   Refer to interrupt-controller/interrupts.txt for generic interrupt client
@@ -32,6 +34,8 @@  tsl2772@39 {
 	compatible = "amstaos,tsl2772";
 	reg = <0x39>;
 	interrupts-extended = <&msmgpio 61 IRQ_TYPE_EDGE_FALLING>;
+	vdd-supply = <&pm8941_l17>;
+	vddio-supply = <&pm8941_lvs1>;
 	amstaos,proximity-diodes = <0>;
 	led-max-microamp = <100000>;
 };