[2/2] ARM: dts: exynos: Mark 1GHz CPU OPP as suspend OPP
diff mbox series

Message ID 20180803065156eucas1p25c5403bd95410e9b3660b3b4fa3580d5~HTTuSYGZg2952629526eucas1p2n@eucas1p2.samsung.com
State Superseded
Headers show
Series
  • Exynos5250: Fix suspend/resume support
Related show

Commit Message

Marek Szyprowski Aug. 3, 2018, 6:51 a.m. UTC
1GHz CPU OPP is the default boot value for the Exynos5250 SOC, so mark it
as suspend OPP. This fixes suspend/resume on Samsung Exynos5250 Snow
Chomebook, which was broken since switching to generic cpufreq-dt driver
in v4.3.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 arch/arm/boot/dts/exynos5250.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Chanwoo Choi Aug. 3, 2018, 6:58 a.m. UTC | #1
Hi Marek,

On 2018년 08월 03일 15:51, Marek Szyprowski wrote:
> 1GHz CPU OPP is the default boot value for the Exynos5250 SOC, so mark it
> as suspend OPP. This fixes suspend/resume on Samsung Exynos5250 Snow
> Chomebook, which was broken since switching to generic cpufreq-dt driver
> in v4.3.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5250.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 8746189990eb..b85527faa6ea 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -118,6 +118,7 @@
>  			opp-hz = /bits/ 64 <1000000000>;
>  			opp-microvolt = <1075000>;
>  			clock-latency-ns = <140000>;
> +			opp-suspend;
>  		};
>  		opp-1100000000 {
>  			opp-hz = /bits/ 64 <1100000000>;
> 

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Bartlomiej Zolnierkiewicz Aug. 3, 2018, 9:54 a.m. UTC | #2
On Friday, August 03, 2018 08:51:47 AM Marek Szyprowski wrote:
> 1GHz CPU OPP is the default boot value for the Exynos5250 SOC, so mark it
> as suspend OPP. This fixes suspend/resume on Samsung Exynos5250 Snow
> Chomebook, which was broken since switching to generic cpufreq-dt driver
> in v4.3.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Thanks for fixing this.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Krzysztof Kozlowski Aug. 7, 2018, 7:02 a.m. UTC | #3
On 3 August 2018 at 08:51, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
> 1GHz CPU OPP is the default boot value for the Exynos5250 SOC, so mark it
> as suspend OPP. This fixes suspend/resume on Samsung Exynos5250 Snow
> Chomebook, which was broken since switching to generic cpufreq-dt driver
> in v4.3.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5250.dtsi | 1 +
>  1 file changed, 1 insertion(+)

Looks okay. I think this should be backported to stable. The
operating-points-v2 bindings should be supported since v4.2 (after
looking as Documentation/devicetree/bindings/power/opp.txt).

How about adding cc-stable then?

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Marek Szyprowski Aug. 7, 2018, 7:11 a.m. UTC | #4
Hi Krzysztof,

On 2018-08-07 09:02, Krzysztof Kozlowski wrote:
> On 3 August 2018 at 08:51, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>> 1GHz CPU OPP is the default boot value for the Exynos5250 SOC, so mark it
>> as suspend OPP. This fixes suspend/resume on Samsung Exynos5250 Snow
>> Chomebook, which was broken since switching to generic cpufreq-dt driver
>> in v4.3.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> ---
>>   arch/arm/boot/dts/exynos5250.dtsi | 1 +
>>   1 file changed, 1 insertion(+)
> Looks okay. I think this should be backported to stable. The
> operating-points-v2 bindings should be supported since v4.2 (after
> looking as Documentation/devicetree/bindings/power/opp.txt).
>
> How about adding cc-stable then?

I can add cc-stable, but I wonder which tags should be used in this case.
Only patch 2/2 is the real bugfix, while patch 1/2 is just a prerequisite
for it...

Best regards
Krzysztof Kozlowski Aug. 7, 2018, 7:40 a.m. UTC | #5
[1On 7 August 2018 at 09:11, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
> Hi Krzysztof,
>
> On 2018-08-07 09:02, Krzysztof Kozlowski wrote:
>> On 3 August 2018 at 08:51, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>>> 1GHz CPU OPP is the default boot value for the Exynos5250 SOC, so mark it
>>> as suspend OPP. This fixes suspend/resume on Samsung Exynos5250 Snow
>>> Chomebook, which was broken since switching to generic cpufreq-dt driver
>>> in v4.3.
>>>
>>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>>> ---
>>>   arch/arm/boot/dts/exynos5250.dtsi | 1 +
>>>   1 file changed, 1 insertion(+)
>> Looks okay. I think this should be backported to stable. The
>> operating-points-v2 bindings should be supported since v4.2 (after
>> looking as Documentation/devicetree/bindings/power/opp.txt).
>>
>> How about adding cc-stable then?
>
> I can add cc-stable, but I wonder which tags should be used in this case.
> Only patch 2/2 is the real bugfix, while patch 1/2 is just a prerequisite
> for it...

Hi Greg,

We have a stable-candidate fix [1] which depends on first patch in the
same series [2]. They were not applied yet so we wonder how we should
mark them in commit? Just add cc-stable for both of them (fix and
prerequisite)?

Best regards,
Krzysztof

[1] fix: https://patchwork.kernel.org/patch/10554603
[2] prerequisite: https://patchwork.kernel.org/patch/10554607
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Greg KH Aug. 7, 2018, 8:09 a.m. UTC | #6
On Tue, Aug 07, 2018 at 09:40:12AM +0200, Krzysztof Kozlowski wrote:
> [1On 7 August 2018 at 09:11, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
> > Hi Krzysztof,
> >
> > On 2018-08-07 09:02, Krzysztof Kozlowski wrote:
> >> On 3 August 2018 at 08:51, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
> >>> 1GHz CPU OPP is the default boot value for the Exynos5250 SOC, so mark it
> >>> as suspend OPP. This fixes suspend/resume on Samsung Exynos5250 Snow
> >>> Chomebook, which was broken since switching to generic cpufreq-dt driver
> >>> in v4.3.
> >>>
> >>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> >>> ---
> >>>   arch/arm/boot/dts/exynos5250.dtsi | 1 +
> >>>   1 file changed, 1 insertion(+)
> >> Looks okay. I think this should be backported to stable. The
> >> operating-points-v2 bindings should be supported since v4.2 (after
> >> looking as Documentation/devicetree/bindings/power/opp.txt).
> >>
> >> How about adding cc-stable then?
> >
> > I can add cc-stable, but I wonder which tags should be used in this case.
> > Only patch 2/2 is the real bugfix, while patch 1/2 is just a prerequisite
> > for it...
> 
> Hi Greg,
> 
> We have a stable-candidate fix [1] which depends on first patch in the
> same series [2]. They were not applied yet so we wonder how we should
> mark them in commit? Just add cc-stable for both of them (fix and
> prerequisite)?

Yes please, that makes the easiest to handle.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 8746189990eb..b85527faa6ea 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -118,6 +118,7 @@ 
 			opp-hz = /bits/ 64 <1000000000>;
 			opp-microvolt = <1075000>;
 			clock-latency-ns = <140000>;
+			opp-suspend;
 		};
 		opp-1100000000 {
 			opp-hz = /bits/ 64 <1100000000>;