mbox series

drm/imx: ipu-v3 plane offset and IPU id fixes

Message ID 1533552680.4204.14.camel@pengutronix.de (mailing list archive)
State New, archived
Headers show
Series drm/imx: ipu-v3 plane offset and IPU id fixes | expand

Pull-request

git://git.pengutronix.de/git/pza/linux.git tags/imx-drm-fixes-2018-08-03

Message

Philipp Zabel Aug. 6, 2018, 10:51 a.m. UTC
Hi Dave,

please consider merging these two fixes for code used by imx-media.
Setting the IPU id to 0 if there are no OF aliases set fixes probing
on i.MX51 and i.MX53, and calculating odd YUV offsets correctly will
help fixing interlaced capture / deinterleaving.

regards
Philipp

The following changes since commit bbe4a089e299efe696ef520e58513c12c0d497c9:

  gpu: ipu-csi: Check for field type alternate (2018-07-16 16:56:35 +0200)

are available in the git repository at:

  git://git.pengutronix.de/git/pza/linux.git tags/imx-drm-fixes-2018-08-03

for you to fetch changes up to 2d87e6c1b99c402360fdfe19ce4f579ab2f96adf:

  gpu: ipu-v3: default to id 0 on missing OF alias (2018-08-02 12:09:11 +0200)

----------------------------------------------------------------
drm/imx: ipu-v3 plane offset and IPU id fixes

- Fix U/V plane offsets for odd vertical offsets. Due to wrong operator
  order, the y offset was not rounded down properly for vertically
  chroma subsampled planar formats.
- Fix IPU id number for boards that don't have an OF alias for their
  single IPU in the device tree. This is necessary to support imx-media
  on i.MX51 and i.MX53 SoCs.

----------------------------------------------------------------
Philipp Zabel (1):
      gpu: ipu-v3: default to id 0 on missing OF alias

Steve Longerbeam (1):
      gpu: ipu-v3: Fix U/V offset macros for planar 4:2:0

 drivers/gpu/ipu-v3/ipu-common.c | 2 ++
 drivers/gpu/ipu-v3/ipu-cpmem.c  | 6 +++---
 2 files changed, 5 insertions(+), 3 deletions(-)

Comments

Philipp Zabel Aug. 8, 2018, 11:47 a.m. UTC | #1
On Mon, 2018-08-06 at 12:51 +0200, Philipp Zabel wrote:
> Hi Dave,
> 
> please consider merging these two fixes for code used by imx-media.
> Setting the IPU id to 0 if there are no OF aliases set fixes probing
> on i.MX51 and i.MX53, and calculating odd YUV offsets correctly will
> help fixing interlaced capture / deinterleaving.
> 
> regards
> Philipp
> 
> The following changes since commit bbe4a089e299efe696ef520e58513c12c0d497c9:
> 
>   gpu: ipu-csi: Check for field type alternate (2018-07-16 16:56:35 +0200)
> 
> are available in the git repository at:
> 
>   git://git.pengutronix.de/git/pza/linux.git tags/imx-drm-fixes-2018-08-03
> 
> for you to fetch changes up to 2d87e6c1b99c402360fdfe19ce4f579ab2f96adf:
> 
>   gpu: ipu-v3: default to id 0 on missing OF alias (2018-08-02 12:09:11 +0200)
> 
> ----------------------------------------------------------------
> drm/imx: ipu-v3 plane offset and IPU id fixes
> 
> - Fix U/V plane offsets for odd vertical offsets. Due to wrong operator
>   order, the y offset was not rounded down properly for vertically
>   chroma subsampled planar formats.
> - Fix IPU id number for boards that don't have an OF alias for their
>   single IPU in the device tree. This is necessary to support imx-media
>   on i.MX51 and i.MX53 SoCs.
> 
> ----------------------------------------------------------------
> Philipp Zabel (1):
>       gpu: ipu-v3: default to id 0 on missing OF alias
> 
> Steve Longerbeam (1):
>       gpu: ipu-v3: Fix U/V offset macros for planar 4:2:0
> 
>  drivers/gpu/ipu-v3/ipu-common.c | 2 ++
>  drivers/gpu/ipu-v3/ipu-cpmem.c  | 6 +++---
>  2 files changed, 5 insertions(+), 3 deletions(-)

I've resent the pull requests with the missing [GIT PULL] tag added,
sorry for the noise.

regards
Philipp
Dave Airlie Aug. 10, 2018, 1:39 a.m. UTC | #2
>
> I've resent the pull requests with the missing [GIT PULL] tag added,
> sorry for the noise.
>

Since we are at -rc8 and this is late, I've just dropped these fixes
into drm-next, once they land in Linus,
you might want to nominate for stable, but I'd like to avoid sending
Linus anything non-world ending at this point.

Dave.
Philipp Zabel Aug. 10, 2018, 8:24 a.m. UTC | #3
On Fri, 2018-08-10 at 11:39 +1000, Dave Airlie wrote:
> > 
> > I've resent the pull requests with the missing [GIT PULL] tag added,
> > sorry for the noise.
> 
> Since we are at -rc8 and this is late, I've just dropped these fixes
> into drm-next, once they land in Linus,
> you might want to nominate for stable, but I'd like to avoid sending
> Linus anything non-world ending at this point.

Ok, thank you for the notice.

regards
Philipp