| Message ID | 20180807183647.22626-1-chris@chris-wilson.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dma-buf: Remove requirement for ops->map() from dma_buf_export | expand |
On Tue, Aug 07, 2018 at 07:36:47PM +0100, Chris Wilson wrote: > Since commit 9ea0dfbf972 ("dma-buf: make map_atomic and map function > pointers optional"), the core provides the no-op functions when map and > map_atomic are not provided, so we no longer need assert that are > supplied by a dma-buf exporter. > > Fixes: 09ea0dfbf972 ("dma-buf: make map_atomic and map function pointers optional") > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Gerd Hoffmann <kraxel@redhat.com> > Cc: Sumit Semwal <sumit.semwal@linaro.org> Ooops. Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/dma-buf/dma-buf.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > index 13884474d158..02f7f9a89979 100644 > --- a/drivers/dma-buf/dma-buf.c > +++ b/drivers/dma-buf/dma-buf.c > @@ -405,7 +405,6 @@ struct dma_buf *dma_buf_export(const struct dma_buf_export_info *exp_info) > || !exp_info->ops->map_dma_buf > || !exp_info->ops->unmap_dma_buf > || !exp_info->ops->release > - || !exp_info->ops->map > || !exp_info->ops->mmap)) { > return ERR_PTR(-EINVAL); > } > -- > 2.18.0 >
On Tue, Aug 07, 2018 at 07:36:47PM +0100, Chris Wilson wrote: > Since commit 9ea0dfbf972 ("dma-buf: make map_atomic and map function > pointers optional"), the core provides the no-op functions when map and > map_atomic are not provided, so we no longer need assert that are > supplied by a dma-buf exporter. Pushed to drm-misc-next. thanks, Gerd
diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index 13884474d158..02f7f9a89979 100644 --- a/drivers/dma-buf/dma-buf.c +++ b/drivers/dma-buf/dma-buf.c @@ -405,7 +405,6 @@ struct dma_buf *dma_buf_export(const struct dma_buf_export_info *exp_info) || !exp_info->ops->map_dma_buf || !exp_info->ops->unmap_dma_buf || !exp_info->ops->release - || !exp_info->ops->map || !exp_info->ops->mmap)) { return ERR_PTR(-EINVAL); }
Since commit 9ea0dfbf972 ("dma-buf: make map_atomic and map function pointers optional"), the core provides the no-op functions when map and map_atomic are not provided, so we no longer need assert that are supplied by a dma-buf exporter. Fixes: 09ea0dfbf972 ("dma-buf: make map_atomic and map function pointers optional") Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Gerd Hoffmann <kraxel@redhat.com> Cc: Sumit Semwal <sumit.semwal@linaro.org> --- drivers/dma-buf/dma-buf.c | 1 - 1 file changed, 1 deletion(-)