[RFC,11/12] btrfs-progs: replace: disable in HMZONED device

Commit Message

Naohiro Aota Aug. 9, 2018, 6:11 p.m. UTC

As show in the kernel patches, device replace feature needs more works to
complete. Disable the feature for now.

Signed-off-by: Naohiro Aota <[e-mail]>
---
 cmds-replace.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Patch

diff --git a/cmds-replace.c b/cmds-replace.c
index 1fa80284..642fbd4b 100644
--- a/cmds-replace.c
+++ b/cmds-replace.c
@@ -116,6 +116,7 @@  static const char *const cmd_replace_start_usage[] = {
 
 static int cmd_replace_start(int argc, char **argv)
 {
+	struct btrfs_ioctl_feature_flags feature_flags;
 	struct btrfs_ioctl_dev_replace_args start_args = {0};
 	struct btrfs_ioctl_dev_replace_args status_args = {0};
 	int ret;
@@ -123,6 +124,7 @@  static int cmd_replace_start(int argc, char **argv)
 	int c;
 	int fdmnt = -1;
 	int fddstdev = -1;
+	int hmzoned;
 	char *path;
 	char *srcdev;
 	char *dstdev = NULL;
@@ -200,6 +202,13 @@  static int cmd_replace_start(int argc, char **argv)
 		goto leave_with_error;
 	}
 
+	ret = ioctl(fdmnt, BTRFS_IOC_GET_FEATURES, &feature_flags);
+	if (ret) {
+		error("error getting feature flags '%s': %m", path);
+		return 1;
+	}
+	hmzoned = feature_flags.incompat_flags & BTRFS_FEATURE_INCOMPAT_HMZONED;
+
 	if (string_is_numerical(srcdev)) {
 		struct btrfs_ioctl_fs_info_args fi_args;
 		struct btrfs_ioctl_dev_info_args *di_args = NULL;
@@ -238,6 +247,12 @@  static int cmd_replace_start(int argc, char **argv)
 		goto leave_with_error;
 	}
 
+	if (hmzoned) {
+		error("cannot replace device on HMZONED file system '%s'",
+		      dstdev);
+		goto leave_with_error;
+	}
+
 	ret = test_dev_for_mkfs(dstdev, force_using_targetdev);
 	if (ret)
 		goto leave_with_error;