diff mbox series

[2/2] hw/ppc: deprecate the machine type 'prep', replaced by '40p'

Message ID 20180809204010.3579-3-hpoussin@reactos.org (mailing list archive)
State New, archived
Headers show
Series [1/2] hw/ppc: on 40p machine, change default firmware to OpenBIOS | expand

Commit Message

Hervé Poussineau Aug. 9, 2018, 8:40 p.m. UTC
- prep machine is a fictional machine, so has no specifications. Which
  devices can be changed/added/removed without impact? Are interrupts
  correctly mapped?
- prep firmware (OHW) has support only for IDE drives (no SCSI).
  Booting from IDE has been broken approximatively 3 years ago, and nobody complained.
- OHW is limited on IDE boot to a specific set of OS loaders.
  These operating systems are of the 2004 time frame.
- OHW can use -kernel. Linux kernel freezes a long time after PS/2 mouse
  detection, and then screen becomes garbage. This was already broken in
  QEMU v2.7, 2 years ago, and nobody complained.

On the other side:
- 40p is a real machine, so emulation can be checked against
  hardware specifications
- OpenBIOS has support for SCSI block devices, including 40p LSI adapter
- OpenBIOS can start mostly all Linux kernels (including recent ones)
  and recent operating system (like NetBSD 7.1.2)

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
 hw/ppc/prep.c | 1 +
 1 file changed, 1 insertion(+)

Comments

David Gibson Aug. 10, 2018, 1:06 a.m. UTC | #1
On Thu, Aug 09, 2018 at 10:40:10PM +0200, Hervé Poussineau wrote:
> - prep machine is a fictional machine, so has no specifications. Which
>   devices can be changed/added/removed without impact? Are interrupts
>   correctly mapped?
> - prep firmware (OHW) has support only for IDE drives (no SCSI).
>   Booting from IDE has been broken approximatively 3 years ago, and nobody complained.
> - OHW is limited on IDE boot to a specific set of OS loaders.
>   These operating systems are of the 2004 time frame.
> - OHW can use -kernel. Linux kernel freezes a long time after PS/2 mouse
>   detection, and then screen becomes garbage. This was already broken in
>   QEMU v2.7, 2 years ago, and nobody complained.
> 
> On the other side:
> - 40p is a real machine, so emulation can be checked against
>   hardware specifications
> - OpenBIOS has support for SCSI block devices, including 40p LSI adapter
> - OpenBIOS can start mostly all Linux kernels (including recent ones)
>   and recent operating system (like NetBSD 7.1.2)
> 
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>

Applied to ppc-for-3.1.

> ---
>  hw/ppc/prep.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
> index 1558855247..fbcaebabc0 100644
> --- a/hw/ppc/prep.c
> +++ b/hw/ppc/prep.c
> @@ -676,6 +676,7 @@ static void ppc_prep_init(MachineState *machine)
>  
>  static void prep_machine_init(MachineClass *mc)
>  {
> +    mc->deprecation_reason = "use 40p machine type instead";
>      mc->desc = "PowerPC PREP platform";
>      mc->init = ppc_prep_init;
>      mc->block_default_type = IF_IDE;
Daniel P. Berrangé Aug. 10, 2018, 4:20 p.m. UTC | #2
On Thu, Aug 09, 2018 at 10:40:10PM +0200, Hervé Poussineau wrote:
> - prep machine is a fictional machine, so has no specifications. Which
>   devices can be changed/added/removed without impact? Are interrupts
>   correctly mapped?
> - prep firmware (OHW) has support only for IDE drives (no SCSI).
>   Booting from IDE has been broken approximatively 3 years ago, and nobody complained.
> - OHW is limited on IDE boot to a specific set of OS loaders.
>   These operating systems are of the 2004 time frame.
> - OHW can use -kernel. Linux kernel freezes a long time after PS/2 mouse
>   detection, and then screen becomes garbage. This was already broken in
>   QEMU v2.7, 2 years ago, and nobody complained.
> 
> On the other side:
> - 40p is a real machine, so emulation can be checked against
>   hardware specifications
> - OpenBIOS has support for SCSI block devices, including 40p LSI adapter
> - OpenBIOS can start mostly all Linux kernels (including recent ones)
>   and recent operating system (like NetBSD 7.1.2)
> 
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
>  hw/ppc/prep.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
> index 1558855247..fbcaebabc0 100644
> --- a/hw/ppc/prep.c
> +++ b/hw/ppc/prep.c
> @@ -676,6 +676,7 @@ static void ppc_prep_init(MachineState *machine)
>  
>  static void prep_machine_init(MachineClass *mc)
>  {
> +    mc->deprecation_reason = "use 40p machine type instead";
>      mc->desc = "PowerPC PREP platform";
>      mc->init = ppc_prep_init;
>      mc->block_default_type = IF_IDE;

A deprecation needs to be listed in qemu-deprecated.texi for it to
be official.

Regards,
Daniel
diff mbox series

Patch

diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
index 1558855247..fbcaebabc0 100644
--- a/hw/ppc/prep.c
+++ b/hw/ppc/prep.c
@@ -676,6 +676,7 @@  static void ppc_prep_init(MachineState *machine)
 
 static void prep_machine_init(MachineClass *mc)
 {
+    mc->deprecation_reason = "use 40p machine type instead";
     mc->desc = "PowerPC PREP platform";
     mc->init = ppc_prep_init;
     mc->block_default_type = IF_IDE;