From patchwork Fri Aug 17 20:07:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Fredrik_Sch=C3=B6n?= X-Patchwork-Id: 10569345 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0F79A109C for ; Fri, 17 Aug 2018 20:08:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0011D2BD78 for ; Fri, 17 Aug 2018 20:08:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E6DD62BE7A; Fri, 17 Aug 2018 20:08:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A4E342BD78 for ; Fri, 17 Aug 2018 20:08:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AC50B6E6E8; Fri, 17 Aug 2018 20:07:47 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id C80F76E6E8 for ; Fri, 17 Aug 2018 20:07:45 +0000 (UTC) Received: by mail-lj1-x241.google.com with SMTP id v9-v6so7262303ljk.4 for ; Fri, 17 Aug 2018 13:07:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Bh28ZcODVfp0XHo3sqLFnZW2cWzACiLDoGhm4PrU3M0=; b=UCdhsv1DKISgAfLyewBFygwVQzEYsWXtyDJZ5lnQw1CySwkipLrawymbu6F17ylp1K T/SwA9e02Ps9Q+TUpmQRoL0VPjMrYIqTABV6yR/8WVjt8DSpAdA0d69vXWIj3ALeSfPd ABTTaB0nl04XAIzbcpS/OdvwCyzpltbHx//W+ZlX6k5LrbO1NzOvSZNNhjNk7NP++UZO xwm0Gw3mwajYCmWdFG0LwylkoxzPolMjZA2EMAiP70rrCypDo0DnGqnuY7z74JCbKvyI 0ZiS5Q5DEHKM0FluTsnsdrxjU9CA/pEi3fc5TRTQ28/fnNIs7pvWoU5bIa9ioEVZ7eq0 q8sQ== X-Gm-Message-State: AOUpUlHY7h2vCnyAjOkgwxwVGLcEKnFxf2qXgvBFQ/lOXWOVhhjpWXb+ mzpBUu3lXvzW/w8SvNXpEYN03FEAvK0= X-Google-Smtp-Source: AA+uWPw0k1GqGLrLjs8MLoKccXDo+tv+htmkX8x3Ktn320BbF9Pl4+aVmGoM481Cx/2Z4zrMP+HMTw== X-Received: by 2002:a2e:1609:: with SMTP id w9-v6mr15209554ljd.120.1534536463915; Fri, 17 Aug 2018 13:07:43 -0700 (PDT) Received: from localhost.localdomain (h-117-148.A147.priv.bahnhof.se. [82.196.117.148]) by smtp.gmail.com with ESMTPSA id u18-v6sm533449lfg.14.2018.08.17.13.07.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Aug 2018 13:07:42 -0700 (PDT) From: " =?utf-8?q?Fredrik_Sch=C3=B6n?= " X-Google-Original-From: =?utf-8?q?Fredrik_Sch=C3=B6n?= To: intel-gfx@lists.freedesktop.org Date: Fri, 17 Aug 2018 22:07:28 +0200 Message-Id: <20180817200728.8154-1-fredrik.schon@gmail.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH v2] drm/i915: Increase LSPCON timeout X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jani Nikula , =?utf-8?q?Fredrik_Sch=C3=B6n?= , stable@vger.kernel.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP 100 ms is not enough time for the LSPCON adapter on Intel NUC devices to settle. This causes dropped display modes at boot or screen reconfiguration. Empirical testing can reproduce the error up to a timeout of 190 ms. Basic boot and stress testing at 200 ms has not (yet) failed. Increase timeout to 400 ms to get some margin of error. Changes from v1: The initial suggestion of 1000 ms was lowered due to concerns about delaying valid timeout cases. Update patch metadata. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107503 Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1570392 Fixes: 357c0ae9198a ("drm/i915/lspcon: Wait for expected LSPCON mode to settle") Cc: Shashank Sharma Cc: Imre Deak Cc: Jani Nikula Cc: # v4.11+ Reviewed-by: Rodrigo Vivi Signed-off-by: Fredrik Schön Reviewed-by: Shashank Sharma --- drivers/gpu/drm/i915/intel_lspcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_lspcon.c b/drivers/gpu/drm/i915/intel_lspcon.c index 8ae8f42f430a..6b6758419fb3 100644 --- a/drivers/gpu/drm/i915/intel_lspcon.c +++ b/drivers/gpu/drm/i915/intel_lspcon.c @@ -74,7 +74,7 @@ static enum drm_lspcon_mode lspcon_wait_mode(struct intel_lspcon *lspcon, DRM_DEBUG_KMS("Waiting for LSPCON mode %s to settle\n", lspcon_mode_name(mode)); - wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 100); + wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 400); if (current_mode != mode) DRM_ERROR("LSPCON mode hasn't settled\n");