diff mbox series

[PATCHv2] block: Use NULL to compare with pointer-typed value rather than 0

Message ID 1534572666-16086-1-git-send-email-zhongjiang@huawei.com (mailing list archive)
State New, archived
Headers show
Series [PATCHv2] block: Use NULL to compare with pointer-typed value rather than 0 | expand

Commit Message

zhong jiang Aug. 18, 2018, 6:11 a.m. UTC 
We should use NULL to compare with pointer-typed value rather than
0. The issue is detected with the help of Coccinelle.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
 drivers/block/ataflop.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/drivers/block/ataflop.c b/drivers/block/ataflop.c
index dfb2c26..fc63ffd 100644
--- a/drivers/block/ataflop.c
+++ b/drivers/block/ataflop.c
@@ -1354,8 +1354,7 @@  static int floppy_revalidate(struct gendisk *disk)
 	unsigned int drive = p - unit;
 
 	if (test_bit(drive, &changed_floppies) ||
-	    test_bit(drive, &fake_change) ||
-	    p->disktype == 0) {
+	    test_bit(drive, &fake_change) || !p->disktype) { 
 		if (UD.flags & FTD_MSG)
 			printk(KERN_ERR "floppy: clear format %p!\n", UDT);
 		BufferDrive = -1;