ARM: dts: clearfog: fix sdhci supply property name
diff mbox series

Message ID 606cef37c2776bdc7dfa3ef578a18c40004e17af.1534878753.git.baruch@tkos.co.il
State New, archived
Headers show
Series
  • ARM: dts: clearfog: fix sdhci supply property name
Related show

Commit Message

Baruch Siach Aug. 21, 2018, 7:12 p.m. UTC
The vmmc phandle, like all power supply property names, must have the
'-supply' suffix.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 arch/arm/boot/dts/armada-388-clearfog.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gregory CLEMENT Sept. 21, 2018, 1:42 p.m. UTC | #1
Hi Baruch,
 
 On mar., août 21 2018, Baruch Siach <baruch@tkos.co.il> wrote:

> The vmmc phandle, like all power supply property names, must have the
> '-supply' suffix.
>

I also noticed it a few months ago and then I forgot. However, does it
add any value to have this regulator?

Now that I found my note, I considered to just remove this line as well
as the regulator node.

What do you think ?

Gregory

> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  arch/arm/boot/dts/armada-388-clearfog.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-388-clearfog.dtsi b/arch/arm/boot/dts/armada-388-clearfog.dtsi
> index 7c6ad2afb094..1b0d0680c8b6 100644
> --- a/arch/arm/boot/dts/armada-388-clearfog.dtsi
> +++ b/arch/arm/boot/dts/armada-388-clearfog.dtsi
> @@ -48,7 +48,7 @@
>  					     &clearfog_sdhci_cd_pins>;
>  				pinctrl-names = "default";
>  				status = "okay";
> -				vmmc = <&reg_3p3v>;
> +				vmmc-supply = <&reg_3p3v>;
>  				wp-inverted;
>  			};
>  
> -- 
> 2.18.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Russell King - ARM Linux admin Sept. 21, 2018, 1:51 p.m. UTC | #2
On Fri, Sep 21, 2018 at 03:42:09PM +0200, Gregory CLEMENT wrote:
> Hi Baruch,
>  
>  On mar., août 21 2018, Baruch Siach <baruch@tkos.co.il> wrote:
> 
> > The vmmc phandle, like all power supply property names, must have the
> > '-supply' suffix.
> >
> 
> I also noticed it a few months ago and then I forgot. However, does it
> add any value to have this regulator?
> 
> Now that I found my note, I considered to just remove this line as well
> as the regulator node.

The "value" is it's a fuller description of the hardware, and DT is a
hardware description, not a description of what the software requires.
So, imho, it's completely correct to specify the vmmc.  As maintainer
for the Clearfog DT, I'd like it to stay (and be fixed).  Thanks.
Gregory CLEMENT Sept. 21, 2018, 2:05 p.m. UTC | #3
Hi Russell King,
 
 On ven., sept. 21 2018, Russell King - ARM Linux <linux@armlinux.org.uk> wrote:

> On Fri, Sep 21, 2018 at 03:42:09PM +0200, Gregory CLEMENT wrote:
>> Hi Baruch,
>>  
>>  On mar., août 21 2018, Baruch Siach <baruch@tkos.co.il> wrote:
>> 
>> > The vmmc phandle, like all power supply property names, must have the
>> > '-supply' suffix.
>> >
>> 
>> I also noticed it a few months ago and then I forgot. However, does it
>> add any value to have this regulator?
>> 
>> Now that I found my note, I considered to just remove this line as well
>> as the regulator node.
>
> The "value" is it's a fuller description of the hardware, and DT is a
> hardware description, not a description of what the software requires.
> So, imho, it's completely correct to specify the vmmc.  As maintainer
> for the Clearfog DT, I'd like it to stay (and be fixed).  Thanks.

OK so: applied on mvebu/dt

Thanks,

Gregory
>
> -- 
> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up
> According to speedtest.net: 13Mbps down 490kbps up

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/armada-388-clearfog.dtsi b/arch/arm/boot/dts/armada-388-clearfog.dtsi
index 7c6ad2afb094..1b0d0680c8b6 100644
--- a/arch/arm/boot/dts/armada-388-clearfog.dtsi
+++ b/arch/arm/boot/dts/armada-388-clearfog.dtsi
@@ -48,7 +48,7 @@ 
 					     &clearfog_sdhci_cd_pins>;
 				pinctrl-names = "default";
 				status = "okay";
-				vmmc = <&reg_3p3v>;
+				vmmc-supply = <&reg_3p3v>;
 				wp-inverted;
 			};