| Message ID | 1535034166-24798-1-git-send-email-fabrizio.castro@bp.renesas.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Commit | 57e43b30a7cc7e9dd7a0b6db56671cfb393e8470 |
| Delegated to: | Simon Horman |
| Headers | show |
| Series | arm64: dts: renesas: r8a774a1: Add CAN nodes | expand |
On Thu, Aug 23, 2018 at 03:22:46PM +0100, Fabrizio Castro wrote: > From: Chris Paterson <chris.paterson2@renesas.com> > > Add the device nodes for both RZ/G2M CAN channels. > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > Reviewed-by: Biju Das <biju.das@bp.renesas.com> Thanks, This looks fine to me but I will wait to see if there are other reviews before applying. Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
On Mon, Aug 27, 2018 at 11:53:35AM +0200, Simon Horman wrote: > On Thu, Aug 23, 2018 at 03:22:46PM +0100, Fabrizio Castro wrote: > > From: Chris Paterson <chris.paterson2@renesas.com> > > > > Add the device nodes for both RZ/G2M CAN channels. > > > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > > Thanks, > > This looks fine to me but I will wait to see if there are other reviews > before applying. Thanks again, applied for v4.20.
Hi Fabrizio, On Thu, Aug 23, 2018 at 4:22 PM Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote: > From: Chris Paterson <chris.paterson2@renesas.com> > > Add the device nodes for both RZ/G2M CAN channels. > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > --- > > This patch depends on: > https://lkml.org/lkml/2018/8/23/1049 > https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg30550.html > > > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > index 5d0109a..cd204f5 100644 > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > @@ -816,6 +816,30 @@ > status = "disabled"; > }; > > + can0: can@e6c30000 { > + compatible = "renesas,can-r8a774a1", > + "renesas,rzg-gen2-can"; Please don't introduce "renesas,rzg-gen2-can", cfr. my comments in https://lore.kernel.org/lkml/CAMuHMdWPuqfXOgh_-qp8q6wATU3Lj_WpX0bAOxPBX76SKvyXCQ@mail.gmail.com/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Fri, Aug 31, 2018 at 10:44:10AM +0200, Geert Uytterhoeven wrote: > Hi Fabrizio, > > On Thu, Aug 23, 2018 at 4:22 PM Fabrizio Castro > <fabrizio.castro@bp.renesas.com> wrote: > > From: Chris Paterson <chris.paterson2@renesas.com> > > > > Add the device nodes for both RZ/G2M CAN channels. > > > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > > --- > > > > This patch depends on: > > https://lkml.org/lkml/2018/8/23/1049 > > https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg30550.html > > > > > > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 24 ++++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > > index 5d0109a..cd204f5 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > > @@ -816,6 +816,30 @@ > > status = "disabled"; > > }; > > > > + can0: can@e6c30000 { > > + compatible = "renesas,can-r8a774a1", > > + "renesas,rzg-gen2-can"; > > Please don't introduce "renesas,rzg-gen2-can", cfr. my comments in > https://lore.kernel.org/lkml/CAMuHMdWPuqfXOgh_-qp8q6wATU3Lj_WpX0bAOxPBX76SKvyXCQ@mail.gmail.com/ Thanks Geert, I was ok with the compat string but it was unwise to pick up this patch before that discussion had concluded. I have dropped this patch accordingly. Fabrizio, please post a v2 once the binding is agreed on.
Hello Geert, Thank you for your feedback. > Subject: Re: [PATCH] arm64: dts: renesas: r8a774a1: Add CAN nodes > > Hi Fabrizio, > > On Thu, Aug 23, 2018 at 4:22 PM Fabrizio Castro > <fabrizio.castro@bp.renesas.com> wrote: > > From: Chris Paterson <chris.paterson2@renesas.com> > > > > Add the device nodes for both RZ/G2M CAN channels. > > > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > > --- > > > > This patch depends on: > > https://lkml.org/lkml/2018/8/23/1049 > > https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg30550.html > > > > > > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 24 ++++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > > index 5d0109a..cd204f5 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > > @@ -816,6 +816,30 @@ > > status = "disabled"; > > }; > > > > + can0: can@e6c30000 { > > + compatible = "renesas,can-r8a774a1", > > + "renesas,rzg-gen2-can"; > > Please don't introduce "renesas,rzg-gen2-can", cfr. my comments in > https://lore.kernel.org/lkml/CAMuHMdWPuqfXOgh_-qp8q6wATU3Lj_WpX0bAOxPBX76SKvyXCQ@mail.gmail.com/ Agreed, will send a v2. Thanks, Fab > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi index 5d0109a..cd204f5 100644 --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi @@ -816,6 +816,30 @@ status = "disabled"; }; + can0: can@e6c30000 { + compatible = "renesas,can-r8a774a1", + "renesas,rzg-gen2-can"; + reg = <0 0xe6c30000 0 0x1000>; + interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 916>, <&can_clk>; + clock-names = "clkp1", "can_clk"; + power-domains = <&sysc 32>; + resets = <&cpg 916>; + status = "disabled"; + }; + + can1: can@e6c38000 { + compatible = "renesas,can-r8a774a1", + "renesas,rzg-gen2-can"; + reg = <0 0xe6c38000 0 0x1000>; + interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 915>, <&can_clk>; + clock-names = "clkp1", "can_clk"; + power-domains = <&sysc 32>; + resets = <&cpg 915>; + status = "disabled"; + }; + pwm0: pwm@e6e30000 { compatible = "renesas,pwm-r8a774a1", "renesas,pwm-rcar"; reg = <0 0xe6e30000 0 0x8>;