Btrfs: fix alignment in declaration and prototype of btrfs_get_extent
diff mbox series

Message ID 1535176079-78283-1-git-send-email-bo.liu@linux.alibaba.com
State New
Headers show
Series
  • Btrfs: fix alignment in declaration and prototype of btrfs_get_extent
Related show

Commit Message

Liu Bo Aug. 25, 2018, 5:47 a.m. UTC
This fixes btrfs_get_extent to be consistent with our existing
declaration style.

Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
---
 fs/btrfs/ctree.h | 4 ++--
 fs/btrfs/inode.c | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

Comments

David Sterba Sept. 6, 2018, 5:29 p.m. UTC | #1
On Sat, Aug 25, 2018 at 01:47:59PM +0800, Liu Bo wrote:
> This fixes btrfs_get_extent to be consistent with our existing
> declaration style.

For the record, indentation styles that are accepted are both, aligning
under the opening ( and tab or double tab indentation on the next line.
Preferrably not spliting the type or long expressions in the argument
lists.

I personally don't like the alignment under opening ( and in some
excessive cases I reformat the code to be more compact. We'll never
agree on one style, so as long as the code does not look ugly as in the
2nd hunk of this patch, there's no "enforcement".

Patch added to misc-next, thanks.

Patch
diff mbox series

diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
index 1aeed3c0e949..00e506de70ba 100644
--- a/fs/btrfs/ctree.h
+++ b/fs/btrfs/ctree.h
@@ -3177,8 +3177,8 @@  int btrfs_merge_bio_hook(struct page *page, unsigned long offset,
 struct inode *btrfs_iget(struct super_block *s, struct btrfs_key *location,
 			 struct btrfs_root *root, int *was_new);
 struct extent_map *btrfs_get_extent(struct btrfs_inode *inode,
-		struct page *page, size_t pg_offset,
-		u64 start, u64 end, int create);
+				    struct page *page, size_t pg_offset,
+				    u64 start, u64 end, int create);
 int btrfs_update_inode(struct btrfs_trans_handle *trans,
 			      struct btrfs_root *root,
 			      struct inode *inode);
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 1e0af0cc56fc..31d43355f052 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -6787,9 +6787,9 @@  static noinline int uncompress_inline(struct btrfs_path *path,
  * This also copies inline extents directly into the page.
  */
 struct extent_map *btrfs_get_extent(struct btrfs_inode *inode,
-		struct page *page,
-	    size_t pg_offset, u64 start, u64 len,
-		int create)
+				    struct page *page,
+				    size_t pg_offset, u64 start, u64 len,
+				    int create)
 {
 	struct btrfs_fs_info *fs_info = inode->root->fs_info;
 	int ret;