Revert "iio: temperature: maxim_thermocouple: add MAX31856 part"
diff mbox series

Message ID 20180825090048.17438-1-matt.ranostay@konsulko.com
State New
Headers show
Series
  • Revert "iio: temperature: maxim_thermocouple: add MAX31856 part"
Related show

Commit Message

Matt Ranostay Aug. 25, 2018, 9 a.m. UTC
This reverts commit 535fba29b3e1afef4ba201b3c69a6992583ec0bd.

Seems the submitter (er me, hang head in shame) didn't look at the datasheet
enough to see that the registers are quite different.

This needs to be reverted because a) would never work b) to open it  be added
to a Maxim RTDs (Resistance Temperature Detectors) under development by author

Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
---
 drivers/iio/temperature/maxim_thermocouple.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Jonathan Cameron Sept. 2, 2018, 9:19 a.m. UTC | #1
On Sat, 25 Aug 2018 02:00:48 -0700
Matt Ranostay <matt.ranostay@konsulko.com> wrote:

> This reverts commit 535fba29b3e1afef4ba201b3c69a6992583ec0bd.
> 
> Seems the submitter (er me, hang head in shame) didn't look at the datasheet
> enough to see that the registers are quite different.
> 
> This needs to be reverted because a) would never work b) to open it  be added
> to a Maxim RTDs (Resistance Temperature Detectors) under development by author
> 
> Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
Applied to the fixes-to greg branch of iio.git and marked for stable
so we avoid confusing people in the future.

Jonathan

> ---
>  drivers/iio/temperature/maxim_thermocouple.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/temperature/maxim_thermocouple.c b/drivers/iio/temperature/maxim_thermocouple.c
> index 54e383231d1e..c31b9633f32d 100644
> --- a/drivers/iio/temperature/maxim_thermocouple.c
> +++ b/drivers/iio/temperature/maxim_thermocouple.c
> @@ -258,7 +258,6 @@ static int maxim_thermocouple_remove(struct spi_device *spi)
>  static const struct spi_device_id maxim_thermocouple_id[] = {
>  	{"max6675", MAX6675},
>  	{"max31855", MAX31855},
> -	{"max31856", MAX31855},
>  	{},
>  };
>  MODULE_DEVICE_TABLE(spi, maxim_thermocouple_id);
> -- 
> 2.17.1
>

Patch
diff mbox series

diff --git a/drivers/iio/temperature/maxim_thermocouple.c b/drivers/iio/temperature/maxim_thermocouple.c
index 54e383231d1e..c31b9633f32d 100644
--- a/drivers/iio/temperature/maxim_thermocouple.c
+++ b/drivers/iio/temperature/maxim_thermocouple.c
@@ -258,7 +258,6 @@  static int maxim_thermocouple_remove(struct spi_device *spi)
 static const struct spi_device_id maxim_thermocouple_id[] = {
 	{"max6675", MAX6675},
 	{"max31855", MAX31855},
-	{"max31856", MAX31855},
 	{},
 };
 MODULE_DEVICE_TABLE(spi, maxim_thermocouple_id);