From patchwork Wed Aug 29 12:17:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Motai.Hirotaka@aj.MitsubishiElectric.co.jp" X-Patchwork-Id: 10580155 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 95970175A for ; Wed, 29 Aug 2018 12:37:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 858C82AA9C for ; Wed, 29 Aug 2018 12:37:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 79AF42AFB7; Wed, 29 Aug 2018 12:37:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1851D2AA9C for ; Wed, 29 Aug 2018 12:37:07 +0000 (UTC) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 58D44CBB; Wed, 29 Aug 2018 12:36:37 +0000 (UTC) X-Original-To: ltsi-dev@lists.linuxfoundation.org Delivered-To: ltsi-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 36EA1CB7 for ; Wed, 29 Aug 2018 12:36:36 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mx06.melco.co.jp (mx06.melco.co.jp [192.218.140.146]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id CA2277C5 for ; Wed, 29 Aug 2018 12:36:34 +0000 (UTC) Received: from mr06.melco.co.jp (mr06 [133.141.98.164]) by mx06.melco.co.jp (Postfix) with ESMTP id E39C53A2A40 for ; Wed, 29 Aug 2018 21:17:23 +0900 (JST) Received: from mr06.melco.co.jp (unknown [127.0.0.1]) by mr06.imss (Postfix) with ESMTP id 420l4M6BFXzRkBT for ; Wed, 29 Aug 2018 21:17:23 +0900 (JST) Received: from mf03_second.melco.co.jp (unknown [192.168.20.183]) by mr06.melco.co.jp (Postfix) with ESMTP id 420l4M5tpgzRk5W for ; Wed, 29 Aug 2018 21:17:23 +0900 (JST) Received: from mf03.melco.co.jp (unknown [133.141.98.183]) by mf03_second.melco.co.jp (Postfix) with ESMTP id 420l4M5mQWzRk8v for ; Wed, 29 Aug 2018 21:17:23 +0900 (JST) Received: from JPN01-OS2-obe.outbound.protection.outlook.com (unknown [23.103.139.145]) by mf03.melco.co.jp (Postfix) with ESMTP id 420l4M5KsQzRk38 for ; Wed, 29 Aug 2018 21:17:23 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mitsubishielectricgroup.onmicrosoft.com; s=selector1-mitsubishielectricgroup-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0sDZ4z7eWoBYnBCnkBmEELMeyMyBS5fC/NL9un/CRgQ=; b=pBV1OL1eYz6Sq/DIWQshH74TDM1/JOF7hR9xNcgO6db7g20T4BIR52SoJB/bWT+ylgKe0SS5CZhNZe1u+5Y0ALig6WWj0FdfM+M4XxcWZZgoG7Plr57NJDO3oxkB2f8O5iWUyACZ7+wGvW0WJFqelMU9a01oEnYSLC7WG4ieyOI= Received: from TY1PR01MB1692.jpnprd01.prod.outlook.com (52.133.160.145) by TY1PR01MB1231.jpnprd01.prod.outlook.com (10.174.226.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.17; Wed, 29 Aug 2018 12:17:23 +0000 Received: from TY1PR01MB1692.jpnprd01.prod.outlook.com ([fe80::d04e:e6f6:c782:22fa]) by TY1PR01MB1692.jpnprd01.prod.outlook.com ([fe80::d04e:e6f6:c782:22fa%2]) with mapi id 15.20.1080.015; Wed, 29 Aug 2018 12:17:23 +0000 From: "Motai.Hirotaka@aj.MitsubishiElectric.co.jp" To: "ltsi-dev@lists.linuxfoundation.org" Thread-Topic: [LTSI-dev] [PATCH 02/54] tracing: Clean up hist_field_flags enum Thread-Index: AdQ/iMncfvN1V3fJTT+yRH+rtNc08g== Date: Wed, 29 Aug 2018 12:17:03 +0000 Deferred-Delivery: Wed, 29 Aug 2018 12:15:00 +0000 Message-ID: Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-melpop: 1 authentication-results: spf=none (sender IP is ) smtp.mailfrom=Motai.Hirotaka@aj.MitsubishiElectric.co.jp; x-originating-ip: [153.231.200.201] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; TY1PR01MB1231; 6:5AlwGA4puXjiTxWmUwg2An90vD5T4+Iirqpsw91Z+Ibeop068uJOHqaA6DeeyMe4AVg63wmxNozdSBD0LkaoszQcGbxPjAovG4+VoHohdH2GbU6huQb6+onAbHdKZu3Sr1toyN0lb+dBjOxd91EuVesZhTexEKx3yuLBJWomFp4DlKYUX4uTPupEIUeSJ4IGv30hi2oJg6oNjYUHbiNE5cNRuu5DSJEY3u7lUtv2qvUQ5EaUDy1ci1onSikobxzSaP2SN1ewmn0YurF46Oem5Q7smBC1hIA19ExAmBn+SMWOZQZzfCunVemVZ20EJc9ccMtQyza+r9rSb1cpR8GATN0LcsO4jC0S4sPEyH8LN7MfSPzbuoYJcHkzCZdZJvdd5rO7S7hlVrJTac2hCUZAEpL/Qfl3kk4weMi1XGDq7JOuOvw8lOfpFxH+/Egta4NT6d8tY4g3BdBzmwVpBJhAzQ==; 5:98+RvDd7mAp3NB5ZfpgBI3cPXt7nYDaLoU4vs0958s+UY2Qb6AyHHmrUlSfowM7nl9DM9ZzzV901cQOIIkwMy10g2rakPcobIRmsiWSzBSZys7Lma6+SoG7sHEmLvDiYz4A8sJJuw/hD+JLmJwYwmLdZSDHUEji9X+bGUwNgRzI=; 7:j9gici3tp0pQR1gFOO3Y2LHleUY8KWhBo7nRCzSEeJLgBLxRB21x/cJqJ4F+8oma9fRY8eEXpjJBHbQdRpirPvjIO0X/hL7bSETSLpEGXXPmKTffsVOzemiDcs+oVUu7r2ZkxKcQBN3obb5l4ZZQeAo+91FyQQMLCw+ZTJS402ol8zwIBnwf73zWalFz1RdgV/ous4+WJEuP8pXITz3HIJwnbU8df6czNuxW/ZkWLyI0quO3DrWXEDdz6fymtNvh x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 628081d6-5e50-4015-642f-08d60da9601e x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:TY1PR01MB1231; x-ms-traffictypediagnostic: TY1PR01MB1231: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(42068640409301)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231311)(944501410)(52105095)(149027)(150027)(6041310)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(201708071742011)(7699016); SRVR:TY1PR01MB1231; BCL:0; PCL:0; RULEID:; SRVR:TY1PR01MB1231; x-forefront-prvs: 077929D941 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(136003)(396003)(366004)(376002)(346002)(39860400002)(189003)(199004)(478600001)(105586002)(2906002)(14454004)(33656002)(66066001)(966005)(72206003)(6116002)(3846002)(97736004)(2900100001)(2501003)(5250100002)(74482002)(25786009)(7736002)(9686003)(5660300001)(6506007)(26005)(6666003)(6916009)(2351001)(81156014)(106356001)(86362001)(6436002)(6306002)(5640700003)(74316002)(8676002)(1857600001)(81166006)(102836004)(53936002)(7696005)(68736007)(55016002)(305945005)(256004)(316002)(186003)(8936002)(486006)(99286004)(476003); DIR:OUT; SFP:1102; SCL:1; SRVR:TY1PR01MB1231; H:TY1PR01MB1692.jpnprd01.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:0; received-spf: None (protection.outlook.com: aj.MitsubishiElectric.co.jp does not designate permitted sender hosts) x-microsoft-antispam-message-info: Tb7SdMiq1an/upGMKFXj0Ijp2iMjR+jacwAJuSnJanszim1C0nedsBY/qSKFUw5C6VWYCXERvm/DfVY6qRfs2l3w7jJpcnXxQKFBy2GLz2ugwZbHWlrxdSxUioUa3HIKLAQxJdXBVPXP3Iy1w8E6p56fd/s74CBMgCVUH2UnybdylZ6TBkA4s/1YOThkeVb7BTEj2HdWEciZAWfmfr1NQkNT8puJ8L95dibI+EWFnqPFJgYKIg45Ej7hEVowPUMut4R+ey3nn7drmkjogoVGKh5JZkGo6ySalmFfc1LE7rocdz1eDt424iqwE892rP8MDe17M3TVHfrKi4a97t3uj1oAMiTBNue+4uqpfQermi8= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: aj.MitsubishiElectric.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 628081d6-5e50-4015-642f-08d60da9601e X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Aug 2018 12:17:22.6237 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c5a75b62-4bff-4c96-a720-6621ce9978e5 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR01MB1231 Subject: [LTSI-dev] [PATCH 02/54] tracing: Clean up hist_field_flags enum X-BeenThere: ltsi-dev@lists.linuxfoundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "A list to discuss patches, development, and other things related to the LTSI project" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ltsi-dev-bounces@lists.linuxfoundation.org Errors-To: ltsi-dev-bounces@lists.linuxfoundation.org X-Virus-Scanned: ClamAV using ClamSMTP As we add more flags, specifying explicit integers for the flag values becomes more unwieldy and error-prone - switch them over to left-shift values. Link: http://lkml.kernel.org/r/e644e4fb7665aec015f4a2d84a2f990d3dd5b8a1.1506105045.git.tom.zanussi@linux.intel.com Signed-off-by: Tom Zanussi Signed-off-by: Steven Rostedt (VMware) (cherry picked from commit 0d7a8325bf3326c92da2d21b4496a9ddde896d4f) Signed-off-by: Hirotaka MOTAI --- kernel/trace/trace_events_hist.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c index 121d5685..0c7ec304 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -105,26 +105,26 @@ DEFINE_HIST_FIELD_FN(u8); #define HIST_STACKTRACE_DEPTH 16 #define HIST_STACKTRACE_SIZE (HIST_STACKTRACE_DEPTH * sizeof(unsigned long)) #define HIST_STACKTRACE_SKIP 5 #define HITCOUNT_IDX 0 #define HIST_KEY_SIZE_MAX (MAX_FILTER_STR_VAL + HIST_STACKTRACE_SIZE) enum hist_field_flags { - HIST_FIELD_FL_HITCOUNT = 1, - HIST_FIELD_FL_KEY = 2, - HIST_FIELD_FL_STRING = 4, - HIST_FIELD_FL_HEX = 8, - HIST_FIELD_FL_SYM = 16, - HIST_FIELD_FL_SYM_OFFSET = 32, - HIST_FIELD_FL_EXECNAME = 64, - HIST_FIELD_FL_SYSCALL = 128, - HIST_FIELD_FL_STACKTRACE = 256, - HIST_FIELD_FL_LOG2 = 512, + HIST_FIELD_FL_HITCOUNT = 1 << 0, + HIST_FIELD_FL_KEY = 1 << 1, + HIST_FIELD_FL_STRING = 1 << 2, + HIST_FIELD_FL_HEX = 1 << 3, + HIST_FIELD_FL_SYM = 1 << 4, + HIST_FIELD_FL_SYM_OFFSET = 1 << 5, + HIST_FIELD_FL_EXECNAME = 1 << 6, + HIST_FIELD_FL_SYSCALL = 1 << 7, + HIST_FIELD_FL_STACKTRACE = 1 << 8, + HIST_FIELD_FL_LOG2 = 1 << 9, }; struct hist_trigger_attrs { char *keys_str; char *vals_str; char *sort_key_str; char *name; bool pause;