| Message ID | 20180829125803.11227-1-niklas.cassel@linaro.org (mailing list archive) |
|---|---|
| State | Deferred, archived |
| Delegated to: | Andy Gross |
| Headers | show |
| Series | [1/2] arm64: dts: qcom: msm8996: Add a default compatible string | expand |
On Wed 29 Aug 05:58 PDT 2018, Niklas Cassel wrote: > Add a default compatible string. > This compatible is defined in Documentation/devicetree/bindings/arm/qcom.txt > and matches how it's done in arch/arm64/boot/dts/qcom/msm8916.dtsi > > Usually the dts overrides this compatible property, however, if the dts > doesn't specify a compatible, this compatible string will be used. > > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> I think we should just say that the board dts must specify a compatible. Regards, Bjorn > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index cd3865e7a270..354d3f900f72 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -17,6 +17,7 @@ > > / { > model = "Qualcomm Technologies, Inc. MSM8996"; > + compatible = "qcom,msm8996"; > > interrupt-parent = <&intc>; > > -- > 2.17.1 >
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index cd3865e7a270..354d3f900f72 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -17,6 +17,7 @@ / { model = "Qualcomm Technologies, Inc. MSM8996"; + compatible = "qcom,msm8996"; interrupt-parent = <&intc>;
Add a default compatible string. This compatible is defined in Documentation/devicetree/bindings/arm/qcom.txt and matches how it's done in arch/arm64/boot/dts/qcom/msm8916.dtsi Usually the dts overrides this compatible property, however, if the dts doesn't specify a compatible, this compatible string will be used. Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 1 + 1 file changed, 1 insertion(+)