From patchwork Wed Aug 29 15:47:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 10580549 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7323A5A4 for ; Wed, 29 Aug 2018 15:48:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3B7A42B287 for ; Wed, 29 Aug 2018 15:47:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2F7C82B29C; Wed, 29 Aug 2018 15:47:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CF07B2B27D for ; Wed, 29 Aug 2018 15:47:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729257AbeH2Tpa (ORCPT ); Wed, 29 Aug 2018 15:45:30 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:50814 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729046AbeH2Tpa (ORCPT ); Wed, 29 Aug 2018 15:45:30 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1D9AE4023351; Wed, 29 Aug 2018 15:47:57 +0000 (UTC) Received: from t460s.redhat.com (ovpn-116-206.ams2.redhat.com [10.36.116.206]) by smtp.corp.redhat.com (Postfix) with ESMTP id BA94AA9F09; Wed, 29 Aug 2018 15:47:55 +0000 (UTC) From: David Hildenbrand To: kvm@vger.kernel.org Cc: Paolo Bonzini , =?utf-8?b?UmFkaW0gS3LEjW3DocWZ?= , Thomas Huth , Christian Borntraeger , Cornelia Huck , Janosch Frank , David Hildenbrand Subject: [kvm-unit-tests PATCH v2 2/5] s390x: fix storing/loading fregs to right address Date: Wed, 29 Aug 2018 17:47:47 +0200 Message-Id: <20180829154750.12876-3-david@redhat.com> In-Reply-To: <20180829154750.12876-1-david@redhat.com> References: <20180829154750.12876-1-david@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 29 Aug 2018 15:47:57 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 29 Aug 2018 15:47:57 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'david@redhat.com' RCPT:'' Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP LARL is wrong here, as we specify an explicit address. Let's use LA (we could also drop it and fixup all loads/stores, but this is easier). Reviewed-by: Thomas Huth Reviewed-by: Janosch Frank Signed-off-by: David Hildenbrand --- s390x/cstart64.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/s390x/cstart64.S b/s390x/cstart64.S index 2f02d4d..02a4f77 100644 --- a/s390x/cstart64.S +++ b/s390x/cstart64.S @@ -58,7 +58,7 @@ init_psw_cont: /* save grs 0-15 */ stmg %r0, %r15, GEN_LC_SW_INT_GRS /* save fprs 0-15 + fpc */ - larl %r1, GEN_LC_SW_INT_FPRS + la %r1, GEN_LC_SW_INT_FPRS std %f0, 0(%r1) std %f1, 8(%r1) std %f2, 16(%r1) @@ -80,7 +80,7 @@ init_psw_cont: .macro RESTORE_REGS /* restore fprs 0-15 + fpc */ - larl %r1, GEN_LC_SW_INT_FPRS + la %r1, GEN_LC_SW_INT_FPRS ld %f0, 0(%r1) ld %f1, 8(%r1) ld %f2, 16(%r1)