| Message ID | 20180830040922.30426-4-baolu.lu@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vfio/mdev: IOMMU aware mediated device | expand |
On Thu, 30 Aug 2018 12:09:15 +0800 Lu Baolu <baolu.lu@linux.intel.com> wrote: > Otherwise, there will be a build warning: > > drivers/iommu/amd_iommu.c:3083:2: warning: enumeration value > 'IOMMU_CAP_AUX_DOMAIN' not handled in switch [-Wswitch] > > There is no functional change. > > Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> > --- > drivers/iommu/amd_iommu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c > index 4e04fff23977..237ae6db4cfd 100644 > --- a/drivers/iommu/amd_iommu.c > +++ b/drivers/iommu/amd_iommu.c > @@ -3077,6 +3077,8 @@ static bool amd_iommu_capable(enum iommu_cap cap) > return (irq_remapping_enabled == 1); > case IOMMU_CAP_NOEXEC: > return false; > + default: > + break; > } > > return false; Seems like a bug fix that doesn't need to be part of this RFC, send it separately. Thanks, Alex
Hi, On 09/06/2018 03:37 AM, Alex Williamson wrote: > On Thu, 30 Aug 2018 12:09:15 +0800 > Lu Baolu <baolu.lu@linux.intel.com> wrote: > >> Otherwise, there will be a build warning: >> >> drivers/iommu/amd_iommu.c:3083:2: warning: enumeration value >> 'IOMMU_CAP_AUX_DOMAIN' not handled in switch [-Wswitch] >> >> There is no functional change. >> >> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> >> --- >> drivers/iommu/amd_iommu.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c >> index 4e04fff23977..237ae6db4cfd 100644 >> --- a/drivers/iommu/amd_iommu.c >> +++ b/drivers/iommu/amd_iommu.c >> @@ -3077,6 +3077,8 @@ static bool amd_iommu_capable(enum iommu_cap cap) >> return (irq_remapping_enabled == 1); >> case IOMMU_CAP_NOEXEC: >> return false; >> + default: >> + break; >> } >> >> return false; > > Seems like a bug fix that doesn't need to be part of this RFC, send it > separately. Thanks, Sure. Best regards, Lu Baolu
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c index 4e04fff23977..237ae6db4cfd 100644 --- a/drivers/iommu/amd_iommu.c +++ b/drivers/iommu/amd_iommu.c @@ -3077,6 +3077,8 @@ static bool amd_iommu_capable(enum iommu_cap cap) return (irq_remapping_enabled == 1); case IOMMU_CAP_NOEXEC: return false; + default: + break; } return false;
Otherwise, there will be a build warning: drivers/iommu/amd_iommu.c:3083:2: warning: enumeration value 'IOMMU_CAP_AUX_DOMAIN' not handled in switch [-Wswitch] There is no functional change. Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> --- drivers/iommu/amd_iommu.c | 2 ++ 1 file changed, 2 insertions(+)