From patchwork Thu Aug 30 17:41:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josef Bacik X-Patchwork-Id: 10582441 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 795C517DE for ; Thu, 30 Aug 2018 17:42:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 688742C342 for ; Thu, 30 Aug 2018 17:42:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5CD9F2C35E; Thu, 30 Aug 2018 17:42:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0CF7A2C342 for ; Thu, 30 Aug 2018 17:42:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727502AbeH3VqA (ORCPT ); Thu, 30 Aug 2018 17:46:00 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:33380 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726727AbeH3VqA (ORCPT ); Thu, 30 Aug 2018 17:46:00 -0400 Received: by mail-qk1-f194.google.com with SMTP id z78-v6so22638qka.0 for ; Thu, 30 Aug 2018 10:42:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=kU9V3lvyuRw1EbYvwZbyCQBU1wFCwS4cJYSwYekxq9E=; b=lyAGcGSb7g+Fcqcu6s2vChy4m0EZKnWDh68Gng7rXhn4ICGYTy0DWJKC613BzNwBhy HK+jSLtPRokIyTwil+yTtaGnN+32dS/lVb1eSZtCTEGN6gh4/Isdci9lUaJOvgs9q5ZZ kTNV2Kcn72Rrv2Wv/ygyrqagtkROHSmUiyCxvjxwrpHRNjtrl20prZvtYrJu0HYqlJ/A ViMyQcBlDzvLw+eHAbAmaasNsHRsRpydLVnUSTZYRlCn2IdDFGQ8lffNM2WFZHkP/mu4 tkbdBviGSPl9dMxB6Bk+5q9KFe3cK0K3xGxmbnfP7qYAAjw1ULAvHM+a8brkhi+0cCcc UuQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=kU9V3lvyuRw1EbYvwZbyCQBU1wFCwS4cJYSwYekxq9E=; b=BBu1vkDI3j53aOhZZqjn+LEoetPBnY5PMyhpLUQTMxZGJ5pBy2IkhjHRdqdEfbBZLa pYboOJVbBz1F4UQNwYRXPTTlwnLohdoQO7CKkbmzAdA+sl0BRVqDCvnuGg7r2sbPxIUH xL06ly4cE4qb1CL5aoXzK1LODvwZvoHRFdpeMh+NewUSXNkfQqnn4p19s6mWNgnF1Mtw WhmTtbQDzZPXoqKqTkBBlfbdxumGCeFN8a8Ukc+1IgI2aQ8WigwXqlKo6mSXTzrcdSR0 TE6f8Vzv1cgWCBor48us1gBs6BL4ifCb3lB49UUmcH4GE+b33GMN9VCY+Tr6CqGOqbrg 4r1Q== X-Gm-Message-State: APzg51BVIBiJ9TdyNzVMApimYFiuPGon3g34QznhqsaGLBI6ga20bNTb +jtxmrIVm8/kdb6ZhoCVxrDg5V/99eYnng== X-Google-Smtp-Source: ANB0VdZISCWWi/ugJnUeWslqhFXJvu1M8DQ8BqXOdv2V71Ll76bg9EeAk3RTX0flYamV6BNOI2eTmw== X-Received: by 2002:a37:4a46:: with SMTP id x67-v6mr12509106qka.60.1535650964865; Thu, 30 Aug 2018 10:42:44 -0700 (PDT) Received: from localhost ([107.15.81.208]) by smtp.gmail.com with ESMTPSA id y142-v6sm4207288qka.5.2018.08.30.10.42.43 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Aug 2018 10:42:43 -0700 (PDT) From: Josef Bacik To: linux-btrfs@vger.kernel.org Subject: [PATCH 09/35] btrfs: protect space cache inode alloc with nofs Date: Thu, 30 Aug 2018 13:41:59 -0400 Message-Id: <20180830174225.2200-10-josef@toxicpanda.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180830174225.2200-1-josef@toxicpanda.com> References: <20180830174225.2200-1-josef@toxicpanda.com> Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If we're allocating a new space cache inode it's likely going to be under a transaction handle, so we need to use memalloc_nofs_save() in order to avoid deadlocks, and more importantly lockdep messages that make xfstests fail. Signed-off-by: Josef Bacik Reviewed-by: Omar Sandoval --- fs/btrfs/free-space-cache.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c index c3888c113d81..db93a5f035a0 100644 --- a/fs/btrfs/free-space-cache.c +++ b/fs/btrfs/free-space-cache.c @@ -10,6 +10,7 @@ #include #include #include +#include #include "ctree.h" #include "free-space-cache.h" #include "transaction.h" @@ -47,6 +48,7 @@ static struct inode *__lookup_free_space_inode(struct btrfs_root *root, struct btrfs_free_space_header *header; struct extent_buffer *leaf; struct inode *inode = NULL; + unsigned nofs_flag; int ret; key.objectid = BTRFS_FREE_SPACE_OBJECTID; @@ -68,7 +70,9 @@ static struct inode *__lookup_free_space_inode(struct btrfs_root *root, btrfs_disk_key_to_cpu(&location, &disk_key); btrfs_release_path(path); + nofs_flag = memalloc_nofs_save(); inode = btrfs_iget(fs_info->sb, &location, root, NULL); + memalloc_nofs_restore(nofs_flag); if (IS_ERR(inode)) return inode;