From patchwork Mon Sep 3 15:29:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Trond Myklebust X-Patchwork-Id: 10586057 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7B1C317DE for ; Mon, 3 Sep 2018 15:30:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6BE352962F for ; Mon, 3 Sep 2018 15:30:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6016929632; Mon, 3 Sep 2018 15:30:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 161F52962F for ; Mon, 3 Sep 2018 15:30:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727024AbeICTul (ORCPT ); Mon, 3 Sep 2018 15:50:41 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:38753 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726314AbeICTul (ORCPT ); Mon, 3 Sep 2018 15:50:41 -0400 Received: by mail-io0-f195.google.com with SMTP id y3-v6so691189ioc.5 for ; Mon, 03 Sep 2018 08:30:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=wB1vpq+Hf5tAhc6xSDBsSka9UzF0BZ7hMgl4DfIKsP0=; b=iJrmvlY+U/Wf3kqztvvkV/GHU+J8s743JVxbNNggBi1IktpqGOy10WHR173hH/exZ0 pohcIEnZWJMYOYZ0+Q8lAhyyC6QwJ+xQrPROmNj7WP8Eq/2H2tI8cYvN8EpUxBiWkiyM LZ04Gwc6XmOzD1RWp6CEUTnLUPvTZ/1E91PA9uIXrMWLCz5dBMJV98Ap6uXC681FAJ+y CKSLI6KYfHuOPXZBHXBZ4CqXjjTRcUUrJTG8Wih/cUY872hkdkUNWD9+Ua6WT7a5EECC O1v6+DCZ+I/Ks+TtBKy+7JcXlW/ou2+TLterzAGCeH1rSlvlTceqac0Cu6z99gruek0g 992g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wB1vpq+Hf5tAhc6xSDBsSka9UzF0BZ7hMgl4DfIKsP0=; b=U1+roQwDsJCWitDTAdGK44EML0ME6QRJX72cNYA+Zqxi+db3eCJB6Ny83/O9G7K23S 9M+HrnirmNWpm8GQunwk2Jj1kOqirN9Sn1obHW6CtRTHbPbQXNvW1inHqlSswIajtbL3 MazGw4yLwBkQVy1DieuPRmrMkkbGBh+KSQTkLr4/TLLkdYORTatIBnn/7RdS0svMwcyk JojaqDlzIUDiAmb+vn9NNlelSaf7+bE1FT7eMUIg/InIFx7vK3WZgStI/vkPnq0o48DP QFsXgneUMR4cxJaJIafkeKFc1A1FxQtFd680jfdIMQsAeTMYSCk2CFVjx3gy0f1q0jVn N+dA== X-Gm-Message-State: APzg51DNJFZwA5E23vLYNy2LuZbe7HNA6CXaTYWuenhwJx8MPJoS4lMa fZQCA7XjXaHRDKXKVxb/egWjExo= X-Google-Smtp-Source: ANB0VdbF6BWnImMXfyFJ0BxdUvu8qRLQ5An5bo6DCXWaHyq4lmEHsur2oAEEFe/Dk89u8u/gDZcOGw== X-Received: by 2002:a6b:ab87:: with SMTP id u129-v6mr20467937ioe.30.1535988601106; Mon, 03 Sep 2018 08:30:01 -0700 (PDT) Received: from leira.trondhjem.org.localdomain (c-68-40-195-73.hsd1.mi.comcast.net. [68.40.195.73]) by smtp.gmail.com with ESMTPSA id c25-v6sm7040027iob.30.2018.09.03.08.30.00 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Sep 2018 08:30:00 -0700 (PDT) From: Trond Myklebust X-Google-Original-From: Trond Myklebust To: linux-nfs@vger.kernel.org Subject: [PATCH 02/27] SUNRPC: If there is no reply expected, bail early from call_decode Date: Mon, 3 Sep 2018 11:29:11 -0400 Message-Id: <20180903152936.24325-3-trond.myklebust@hammerspace.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180903152936.24325-2-trond.myklebust@hammerspace.com> References: <20180903152936.24325-1-trond.myklebust@hammerspace.com> <20180903152936.24325-2-trond.myklebust@hammerspace.com> MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Trond Myklebust --- net/sunrpc/clnt.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index bc9d020bf71f..4f1ec8013332 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c @@ -2260,6 +2260,11 @@ call_decode(struct rpc_task *task) dprint_status(task); + if (!decode) { + task->tk_action = rpc_exit_task; + return; + } + if (task->tk_flags & RPC_CALL_MAJORSEEN) { if (clnt->cl_chatty) { printk(KERN_NOTICE "%s: server %s OK\n", @@ -2297,13 +2302,11 @@ call_decode(struct rpc_task *task) goto out_retry; return; } - task->tk_action = rpc_exit_task; - if (decode) { - task->tk_status = rpcauth_unwrap_resp(task, decode, req, p, - task->tk_msg.rpc_resp); - } + task->tk_status = rpcauth_unwrap_resp(task, decode, req, p, + task->tk_msg.rpc_resp); + dprintk("RPC: %5u call_decode result %d\n", task->tk_pid, task->tk_status); return;